From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C2AC433EF for ; Fri, 3 Dec 2021 15:01:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 451186B0073; Fri, 3 Dec 2021 10:01:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D9FA6B0074; Fri, 3 Dec 2021 10:01:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 253CC6B0075; Fri, 3 Dec 2021 10:01:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 149436B0073 for ; Fri, 3 Dec 2021 10:01:38 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C0627184823F0 for ; Fri, 3 Dec 2021 15:01:27 +0000 (UTC) X-FDA: 78876796614.04.B215CD1 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by imf12.hostedemail.com (Postfix) with ESMTP id 2E9A110003C3 for ; Fri, 3 Dec 2021 15:01:25 +0000 (UTC) Received: from [172.16.4.185] (unknown [119.41.208.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 58DA83F17A; Fri, 3 Dec 2021 15:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1638543683; bh=/lDkRqJ88v1ucIBzuuXygaFN6pRVMaJgpbg5q1N0Pf4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=tEJIoVoWvd8w81B10BiVIAwIpQ5v21B1QEE10VfAPXH6BL9fZ9GwGL/wJi/QZT9J4 BVIt6IIIdZvTq6IAKHvykkFgbf9AIhnn23kfLw7kuQx3BaDv+u1o78rtTeUrCwWCHL GcGZ0YHq0sW2BiRJhqOX3mXloF+VDMQboEmKSwZGCvJGeyxaVQUvobjlWAT/G/0ZYR GckJ24zwy+zW7Kx5x3j4f4URISfULpWA5Kw2GN3BnkETsX9JKXAzm8VRnDeRhHacoU S5BtAeMpnx8clHGDUFiFGq8qOODBnQlMQLUVSyyXpB1bjnot0o1gG1a0z9DTtWGbHy XqFFEnFAA27xg== Subject: Re: [linux-next:master 3956/5128] sound/soc/sof/intel/hda-codec.c:132:35: error: use of undeclared identifier 'CODEC_PROBE_RETRIES' To: Kai Vehmanen , Pierre-Louis Bossart Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , kbuild-all@lists.01.org, kernel test robot , llvm@lists.linux.dev, Linux Memory Management List , Mark Brown , Bard Liao References: <202112031943.Twg19fWT-lkp@intel.com> From: Hui Wang Message-ID: Date: Fri, 3 Dec 2021 23:01:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2E9A110003C3 X-Stat-Signature: cqfhjjwoifswkeurcu8tkq9kwwhkzf9c Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=canonical.com header.s=20210705 header.b=tEJIoVoW; spf=pass (imf12.hostedemail.com: domain of hui.wang@canonical.com designates 185.125.188.121 as permitted sender) smtp.mailfrom=hui.wang@canonical.com; dmarc=pass (policy=none) header.from=canonical.com X-HE-Tag: 1638543685-70133 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Oh, sorry to introduce this build failure. Thanks Kai to fix it. Thanks. On 12/3/21 10:07 PM, Kai Vehmanen wrote: > Hey, > > > On Fri, 3 Dec 2021, Pierre-Louis Bossart wrote: > >>> 127 do { >>> 128 mutex_lock(&hbus->core.cmd_mutex); >>> 129 snd_hdac_bus_send_cmd(&hbus->core, hda_cmd); >>> 130 snd_hdac_bus_get_response(&hbus->core, address, &resp); >>> 131 mutex_unlock(&hbus->core.cmd_mutex); >>> > 132 } while (resp == -1 && retry++ < CODEC_PROBE_RETRIES); >> Indeed, something's not right here. >> >> CODEC_PROBE_RETRIES is defined conditionally >> >> #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC) >> #define IDISP_VID_INTEL 0x80860000 >> #define CODEC_PROBE_RETRIES 3 >> >> but it's used unconditionally. > yup, the definition needs to be moved out. > >> We could define this constant unconditionally as a quick fix, but this >> compilation problem might expose a larger problem. >> >> Kai, I wonder if this is code from lines 120 to 139 that we didn't >> update when we moved to support HDMI with the generic HDaudio parts? I >> don't see why we could even try to send a command on the bus is there's >> no audio codec support? >> >> hda_codec_use_common_hdmi should be the default assumption now, I don't >> think we support the old solution, do we? > We do still support the hdac-hdmi as well, albeit only for select old > hardware to maintain backwards compatibility. > > I'll send the quick fix. > > Br, Kai