From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E28D9C001DC for ; Thu, 27 Jul 2023 07:26:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4262F8D0001; Thu, 27 Jul 2023 03:26:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D7826B0074; Thu, 27 Jul 2023 03:26:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C5238D0001; Thu, 27 Jul 2023 03:26:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1AF706B0072 for ; Thu, 27 Jul 2023 03:26:51 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DA9F0A0CD9 for ; Thu, 27 Jul 2023 07:26:50 +0000 (UTC) X-FDA: 81056559780.12.2DD0A46 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id EB4B4A0005 for ; Thu, 27 Jul 2023 07:26:48 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690442809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EYZXC01U+v3pKY+IU2N058KWBcAKvVO2g7rE1nWCXdY=; b=l2DNrqkwNC5aS0w+diTLUnKbDSYiFjVDz6k3lOv4Co6bZSuHUKNoe/2jGlZuP5IQ1rrF5L x5i+kpFipj9mUnqknYqo6BXP8O65gQWfOZIFead8RbrGp6ihaKUkuOn1aW/cGEFIAn0xdo lN+voYkp414nzKgfFfa0UfwrWzEOsv0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690442809; a=rsa-sha256; cv=none; b=5LqEDQT6yBTMdASUMDgp9K72iTsjfpRDR1baCCqHObmpK29RE5hUVF1w2r8UKI0KEOFBup /yM94TbCGe2fzp3Oq1JBMdDAdy5p2zuiKdrT+hCN6w7fFqgA/oajFYBDWrREKd0jGfNTZQ Pegcp812fbVrUIHDRDTlGLq82J93ROo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C597FD75; Thu, 27 Jul 2023 00:27:30 -0700 (PDT) Received: from [10.57.77.6] (unknown [10.57.77.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 617EF3F67D; Thu, 27 Jul 2023 00:26:46 -0700 (PDT) Message-ID: Date: Thu, 27 Jul 2023 08:26:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 2/3] mm: Implement folio_remove_rmap_range() To: Matthew Wilcox , "Huang, Ying" Cc: Yu Zhao , Andrew Morton , Yin Fengwei , David Hildenbrand , Yang Shi , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230720112955.643283-1-ryan.roberts@arm.com> <20230720112955.643283-3-ryan.roberts@arm.com> <87r0ouw39n.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EB4B4A0005 X-Rspam-User: X-Stat-Signature: tmyfgbaajkbb7aoaqmrbxp7so4mg85pj X-Rspamd-Server: rspam03 X-HE-Tag: 1690442808-424382 X-HE-Meta: U2FsdGVkX1+XHnaWUjBh8D0S/u+pENWoL52M1VcR79Bs9IEK5cSf4PGu2Lc3o3hvB3ekSbhRjDdbkEzBttSfNONR78kiue++S6zXdUCT4vBO/fNsGBMKN+Wp8uF9EgjMmrTTXrLFMxEGBz7Lqt6y5MY/vwbK2Uzfdpu/LbVTt0K+rnO0MPfw/AmyQ5xxIogGyTMdMArtknLsYzNcKLIF1PYLTmD2z4Hp0apq33RAC5b0qqHbawvXUTW+umRKH7NJNAJS66BogQ8k/zJkwPkcMRZmekIOYMel7KVJM5nqjDf84gQja6xViX47UYqLGDtqxbheCDuswny1T6esJ2gyeDi+TcRDfolEfSPaOWvxPb2/PuJHguhLh82VTj8T2GU+JgArZYGkYrFk5xNqZOHx9qNy54GIgwmNK8+GPILV3TSYgbqXQ/HwPf6VpJW1EMzyi+FhvJ7DP7UByVwpjgeU+vsMnrR1l4lJv3JPpFH4dHl6V1oaOC9bp0sGI65ToOGSF3eX6FN04CB4exRkXxkf4AdCfEPimZ1cEx37SqNMVJpW6/TwumoHmsXnti679CZI5MOY151qFIrbf2aAiTgch7rs+gJWaL8JSxWCdoKs8GvSnPIHj8ITiECyebMdru4wc+y/EPuCRYsB2hevhdQd3B1AJ07SO7d/+Gl0VMNf1hzCGarUOnqZKP07np2YZ7OaC1NctVuav2853z64ut2X9fEiXvVkwtT7ZlVQqE4U8nc+j0ucbK9vySCeytEGNvvJI/CwJKC6UyFvxCIPrnurP5/8pRSe6BhPe/UsPH+aVuRTF+WsL3OnNWGYkBiSvrDYMnWmcokhsKIqWIjmepR4R2zSXikw1wuWiqoW6OTJHpRxSwpLqxUE1fHVzSKFMiGPe/iqa3orFOz5qBsEPqvH9jIT87raulno4V5smEqqd3lVAY5QkgE7Cv7g7qI1s5p59dKL9XhnyruyYZJmQHM ZwuCJku/ OC0sFTn8Mn7mu+y0l/eSGSB4dir6bnzAWE14aplfxV1kYE9hGwWwSHp8VevUOxR59BzcoaG6quOQbO0D/3oT9MRU1D5swDblQ4VZ34RwLsMmJr/5RrylJAB3tjs1HXEFR4iDs9ADGXKbkuqMtR4fyprNhDs0w7ELgbKTmF1ssFiF5A2fhR7HIdrP2K0MfeQptw2l+RDNmA3muV98TuvtHBqedsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27/07/2023 03:35, Matthew Wilcox wrote: > On Thu, Jul 27, 2023 at 09:29:24AM +0800, Huang, Ying wrote: >> Matthew Wilcox writes: >>> I think that can make sense. Because we limit to a single page table, >>> specifying 'nr = 1 << PMD_ORDER' is the same as 'compound = true'. >>> Just make it folio, page, nr, vma. I'd actually prefer it as (vma, >>> folio, page, nr), but that isn't the convention we've had in rmap up >>> until now. >> >> IIUC, even if 'nr = 1 << PMD_ORDER', we may remove one PMD 'compound' >> mapping, or 'nr' PTE mapping. So, we will still need 'compound' (or >> some better name) as parameter. > > Oh, this is removing ... so you're concerned with the case where we've > split the PMD into PTEs, but all the PTEs are still present in a single > page table? OK, I don't have a good answer to that. Maybe that torpedoes > the whole idea; I'll think about it. This is exactly why I think the approach I've already taken is the correct one; a 'range' makes no sense when you are dealing with 'compound' pages because you are accounting the entire folio. So surely its better to reflect that by only accounting small pages in the range version of the API.