From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050D8C3DA4A for ; Wed, 14 Aug 2024 15:28:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773316B007B; Wed, 14 Aug 2024 11:28:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 724636B0089; Wed, 14 Aug 2024 11:28:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612B36B008A; Wed, 14 Aug 2024 11:28:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 457316B007B for ; Wed, 14 Aug 2024 11:28:18 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B15D31C3429 for ; Wed, 14 Aug 2024 15:28:17 +0000 (UTC) X-FDA: 82451232234.25.16DF05B Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by imf11.hostedemail.com (Postfix) with ESMTP id F112E40024 for ; Wed, 14 Aug 2024 15:28:15 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=eyPX261q; spf=pass (imf11.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723649200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MuR0TzKoD/82H6FNhNsVi/6dcgoRuB0EnRcZ5RZ2w38=; b=MOQ+1rcRwFxPsqb8w9FAs0saCsuWEGN9WDB2GKd4R0EwvXrWLqCNnq8dt8Fv0KgGj73KOJ P8N+A5GJhES6TMoXIN3K64Fhr/y2quoHX6gvC/Bfszt9DieZYqqc4yjNrcNiS3qWwJeLHv kitQK4aANMqbtz6Fzy071njIDhYvjFo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=proton.me header.s=protonmail header.b=eyPX261q; spf=pass (imf11.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.43.22 as permitted sender) smtp.mailfrom=benno.lossin@proton.me; dmarc=pass (policy=quarantine) header.from=proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723649200; a=rsa-sha256; cv=none; b=CCkt7B4PrAQVlRC1HvleCB6cZRWwFJIr/ostpPyXoPyIGLBAJ1X9Wrv9wlnmycEF/uWsHP FQE9fCginWM2JTlCV/YKeUrWsxeag/RAohsVWjAcf+otQJjyCTU2y33ln/1PhVJDOTC6bn Rz7hXWvjVYpMD1e42rlaHnHxnqlKT+E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1723649293; x=1723908493; bh=MuR0TzKoD/82H6FNhNsVi/6dcgoRuB0EnRcZ5RZ2w38=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=eyPX261q1+gOa00RCdL3H899nPWsg3bAblFMAyKWWTMD84a+INhfR5feerWgyNj21 KyB6SZlHj2eGIrCmCmvnWmqBusIYbmmhjLi9mzcpAKaV13pMulyRgXgRa3oSj2p3SC 9alhP9UN/h2oZJOBAOPN+vsdxjNdEvbLIOxzRmViDEMbaUYK3mBiiGp4YgpmVljUlE t0HmusHD7/Wiifd/hhmMrCW70tsGBCMcTNjm1SRVV79BzZHrRGNgpgls5W6sy6GhQK 8NiixMLXgWB8hA810jwVM7WlxwerE/ida5NKEd3hHa9AljONB5Cqn01YN3j7Tw5dtx 3KnFtXGBtdYIA== Date: Wed, 14 Aug 2024 15:28:10 +0000 To: Danilo Krummrich , Miguel Ojeda From: Benno Lossin Cc: Alice Ryhl , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc` Message-ID: In-Reply-To: References: <20240812182355.11641-1-dakr@kernel.org> <20240812182355.11641-5-dakr@kernel.org> Feedback-ID: 71780778:user:proton X-Pm-Message-ID: 3b4c5c06824648ccad7be788c21fcae10398f170 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F112E40024 X-Stat-Signature: abkkuc7j3ekoqckm8o883nft1a1u5r6g X-Rspam-User: X-HE-Tag: 1723649295-698081 X-HE-Meta: U2FsdGVkX1+NQEJAi2upLrPfQwCEH7sSrfdP0hCpHI9ceMfRdOziUaZfziLc7arqj21IA0kj4LVt08L9iXZCF4OlGJC3+SxLEM3NF0uH+isRTZ8gRqOhbBMzSAy7of25GQegVyjL+n1Qkcw/d7fgbJXiooW55xtV8ABc2FgmMWUJn5rbFZen3AOpz4FGlf688jLa3foZBVVEpEmVAjcd5nuOyr6AAdL3Fc1fC0oFBQ6AxDxl28KoAa2FbHhoDV8xRcx1PlD+Zs8TXBtRnna+nAj4mpPp0zfoZDCK9FJUnxGBWFD8+Vqmb3pGnKXJcF0n7zsFs6bKcr3dpyq+Nr7qmbcpXvYEfU3uAbi+G4egk74tR8JgnJKHV1kJu1qPR+BUNTgux4PhmUNioBgY97GIDRsTg+Vh0fSuHjGQXGqdi56fWGFf3HdDdzeg6TUT8RoqQ+7ATM7B/S6RcuPHppd+WttIjj+9Jtf6DXqd7J4GdW7I8WRR4BgTcV72Tsn4q6+nhXHu1K0DdBHCLn1tIUQEPEDM7HbzoE08hkAVVsMrbnO0oXZgAMIUxk64QDu6zo/VFeBadWy27ayip2yERfOruKde/TF3VNAfFZHENEJxlLmJVoerZOL21zKq0SyWwehmnfnMyQEqf+FFg+CwWZhnb7DLgsyRYGdghlxIXZZo8VlqOI3Lf2z0QJiu04fqSwhmCHTuZnaAeq4tVozpSlKs8qYhVHLzC54gdzzpJ9cs189BekDK0oh9uv7YMT2Y+EsK7veFKpwpLJax+QybiaEEjUrTPtHzsGXiVyM/Cv3uBVYx/jRhL2ONM7/Vc69ZigBbWgFzZzoK3yySCMos7uYIKFVrHVnjFHsKN9KBX9zFQBtt60PxE5LQ8n9zkBSH3jhvBtltNyqx0Z3ZAOJIxjyhWw3Ut5QGcxvSKBtB2TgrTmX7pgnXTjqUTy11vgqBoawjYeC3TUpwifApezcPOpq dTZtiWoX ouppwIHfk/P3szk/MZQKtMcWpfWH3VBEelqTsHSpQbEkWVrNpfOCXZUt98X5y5D447JXXBm43HsBv3m/Hw5ghNfmhmQ1DxSSPQaJitXtMtGGQdAnRBEDJMyA6fNRkYohtFCMKQP6biBQtclPbo+plB9r+XiAy41C/BgRAlARMLAVdKe18S3Xc6JnCtSMV/a6ilz0mFkjeSYgei5sHxVVmtLwISCdS8t0sc2SRyOSkVkbFp4lBm2+/sev1mrgFF7xqb0ehotHMOGVAVRh8bxD5ocZ0sh5qYUjhI/s2nv4//yEMnI7OWyZexksL8T0DaDyPmJkft+DhoiY4VDskMB2ghMchXFjmZwYGvCmo6WDTfiiUDetOshe8OQNwEjMJ4Hx77JNSclmwFbb3ScNyokvVLBC9fviRLA4qGDoSQVOIF1knGt9c6wGwSoaBs6PPC7b4CZOEOEf6D60XZ7GSE5zNFHjstw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000883, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.08.24 17:19, Danilo Krummrich wrote: > On Wed, Aug 14, 2024 at 05:03:21PM +0200, Miguel Ojeda wrote: >> On Wed, Aug 14, 2024 at 4:00=E2=80=AFPM Danilo Krummrich wrote: >>> >>> If we keep them, we'd consequently also need to add them for vrealloc()= and >>> kvrealloc(). But again, they don't do anything for us, and hence are mo= re >>> misleading than helpful IMO. >> >> In general, they could do something (e.g. `noreturn`), perhaps in the fu= ture. >=20 > Indeed, and I think once they're honored we should add them again. That sounds like it will be a lot of work, going through every function and checking if it has the given attribute. Especially when the attributes are enabled one by one. I think we should keep them (and of course introduce them on new functions). --- Cheers, Benno > It's just that I think as long as compiler attributes aren't honored, we = should > not have them in the first place to avoid confusion about whether they do= or do > not have any effect.