From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB18FC3DA4A for ; Sun, 11 Aug 2024 08:51:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C7B16B008A; Sun, 11 Aug 2024 04:51:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 277CB6B0092; Sun, 11 Aug 2024 04:51:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F2A36B0095; Sun, 11 Aug 2024 04:51:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E535A6B008A for ; Sun, 11 Aug 2024 04:51:49 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8E770121A44 for ; Sun, 11 Aug 2024 08:51:49 +0000 (UTC) X-FDA: 82439346738.05.96D566A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 3D56540002 for ; Sun, 11 Aug 2024 08:51:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cCJcRoIE; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723366253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nO8zDpNtu5TNqECPQNAF0g6rVZ54IeB2gyr7WMkyB+0=; b=Ea2gdMPWw6ujRFSJlRo+aEMpYSpOVKZp0ZDEs+e7HCqpOAW/v/Fy6xgxtULhD9qRZ0XO1H za5LIv2gvne9DCgoILC5J+3/gttbTYM+pBBKBw1+mHJrpxyRk8SrpC8W4eUoJ6MJic1RuW aeCiSdL3lA70jAQlrrKLhB5Euy70mKs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cCJcRoIE; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723366253; a=rsa-sha256; cv=none; b=yf9lykZSuoM/UNuv+Yi2PbYTJXIwTEn7sEyMHh5RfhaD/NphiIOdWQXZ6nzTYRSpbew4Ek 8rbjdko4bxuYtmlC2IQdRp61Hok2ohpPq8eeAy6cGtr9nHhY4WB8BSDShHVIz/kjGycb7v k6IRfrSoaoJrH0KibrRdngkjlYNz3Kc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723366306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nO8zDpNtu5TNqECPQNAF0g6rVZ54IeB2gyr7WMkyB+0=; b=cCJcRoIEPLY48sLIRX/RsyAYjMSzBOPNwvh5aL941Ext1FKXtpQ21OmK3KLO7bS1B1L/4p k5InwJIxFSXqQ+vDLwFt0P2rhY7oQ5j1HHPniAN1cJtxtbselB8uN1yCDXWsdQALz7E5By MiVHILVyqXYPidlQSVuGdaAUYcVxQD0= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-O8XMLMshNGCfOG-zP2v0mQ-1; Sun, 11 Aug 2024 04:51:45 -0400 X-MC-Unique: O8XMLMshNGCfOG-zP2v0mQ-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a7dc32f39c6so283671766b.2 for ; Sun, 11 Aug 2024 01:51:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723366304; x=1723971104; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nO8zDpNtu5TNqECPQNAF0g6rVZ54IeB2gyr7WMkyB+0=; b=dzSxBSKxVGUToFxvlR437NuT/yCYzLiD7YQLdWdqpUigkXj9rzxNk653+6S1NROPRG mwsVHkDtFBRF5TKqcbCxiPBEKOiNcG3jzajGmsVAG7OyewXFiFxsQP/9fSPEt1uxzgEz EakL/g3yzHeIGhQNrUqqDFUsoQ51iuQ6rlaRQwBMvvpMmjYXl2TUjBBcLR652gHU3k71 p3wRCBTUsDwaDUra9kCkjP898NGpm4KrZS1Fd/Fa3AJdEukrSiRIC0BVMHZQB041FNEz EaekFvTd7W2YQGVpQ9ef4HwfahSY2AXj2z4wI56GdO60xjyJYB6qAbMJ/ANrLVwY2aYb pvPg== X-Forwarded-Encrypted: i=1; AJvYcCUfqWsGAs4RpnIDK7q9KIZ/xJ2nlCFiVWQA3r91Zz7KqMNNIayHuN2xePvY5yqPsMCoucxfbWP2LKCE3YuOFMt2vgI= X-Gm-Message-State: AOJu0Yz5Vy8FCCU9a/GOCvxifquf5RVcjfef0fC7rVraOc6RkA85pSfw POXPfH6DeV1G2pkkCj5paS0jF4kDbk8pbtkRv8orh0xhVOfBFDEXyvQMnVbCnyKQy4jjtyHi2sy C1udGRRCHISOy2ZThUjPTboHfu1teF7zI9YQMsqYed+Dt/QFc X-Received: by 2002:a17:907:efe4:b0:a7a:8378:625c with SMTP id a640c23a62f3a-a80aa5dd596mr460885566b.36.1723366303956; Sun, 11 Aug 2024 01:51:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGLTEoCLje1+/EozjL6GLfA0Ify15zjAfHJS26Fb5eQomnIUpFA6R4LxXVepKUXAl2+doTCQA== X-Received: by 2002:a17:907:efe4:b0:a7a:8378:625c with SMTP id a640c23a62f3a-a80aa5dd596mr460884266b.36.1723366303477; Sun, 11 Aug 2024 01:51:43 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80bb1d153csm132038166b.137.2024.08.11.01.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Aug 2024 01:51:43 -0700 (PDT) Message-ID: Date: Sun, 11 Aug 2024 10:51:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, ioworker0@gmail.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, v-songbaohua@oppo.com, ziy@nvidia.com References: <41b49313-5804-46ba-9e1d-358b079274cd@redhat.com> <20240809070412.33847-1-21cnbao@gmail.com> <62d758b1-595a-4c05-ab89-3fe43d79f1bf@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ktsuc78ho8nbta3mhbp5wqxnwarisany X-Rspam-User: X-Rspamd-Queue-Id: 3D56540002 X-Rspamd-Server: rspam02 X-HE-Tag: 1723366307-762628 X-HE-Meta: U2FsdGVkX1808LmbeJdvyz+chDA/5vZFbSEDZ2kshmPy6CpB58K4qy4XjMdV4FUBkC966UA9iwn6UXwTLhovKy9XODe9oL5YfVQOTH4OEfFGPH3oMAKiXaBlnA5t5CvcqVvC1Q4gSi/KBPMPMMjA0MtjJ+qaOvj8oVfYm8CFnoOjkV5uKZyApYVcUF+zcgfJxEUrdGCICOBaKGxgR+K0gu6pIr8DNGBAUtjbYOdEUmxDYyl4Vz3OWpUlm6WcY3Iexv7pgIKMITWvrpGfx0nyWUvDb1kQkvALkI3PBjk3B+IWNZw+N0H2ROzpi4vs+HKMd6nmo4F7knpQwebN7QfJ5bT3OcNGihMNXhwzhMIp9+IyEKagVFgumgm8VIN9hmHzZaGgg8LRjslaQJSMoLTq8Lx7cbgb/b0xKtk250zrI6W9llcIiJX4JrcxhgqZKa0csip8Cm5pYDSg7KCmifdv0TTP4I9Bv/R7Z0Z7Z/JZU0r5Tnzwk3/eu4LdREOnU0LLp4UkoKl352HDXLK3ZIRB1aBllP1CLkuKTHu+TQmDatD4Nl4gx/pJIyYwW87OnocDC87B/ci84hxqRz/eD0nXAqVEf7h2nYOCv2mdVY9lT7BVPwStlJePPKvURL8rQPggXKIfHrMU1qbHRRW7HxHUjz15LPdHf1uQqrnYb0p5vieUu5hxY121glC0JFERIVkCpwqn/H5pbpzWFXKMGCilSuSg+Q4J46PsQPJGq0ieP1vmYYGjuK4dxl04H9g2NckNErPzedR00DT8BUVxq9r5/Dj4j1u8OAqsRIuewfYipvV/u3Id/Pybt0SfBVh9/sHuFg3WMR+mLKlwfj871SLxU4CM+mR9xU3g3/vX9gs+5lNgo89gHkQk4hkAxCeG2w1BLAlx0chufb4gTatH+U8GOZP9mgeyaV29emGxJfvOPij0EjVd6kRoo4dB6MycwqqAKUG+NEEgBk4iiBSMw/N LhGUTHUV BwKgIJ6ubzCyqGaFgUkbUcyxu2QVahzGDyluh0F6Ty5MoCIpSfa67Olmz77TicyoIt/mJslxjAqpLASQn+roWlI3ttn/Oph016f1dgGhLAGUHiK1VzfzuPd7IKCYQ8n3g6claj9vJNeLhaY92Pi73ow7lU7OSMDcZg7GgncVzap4jI+Xg+5jhVvTObi9Jwu8GaLCZ3VkXJvdx5vUCT1W1vniJI6RvsToFtv8PNRcl1JagfEdmtoMka/LFBebV/nLsoNQrUm9Zx1nR05IGdW+UY79fGhicbs4+VM/R7+78/5uBTJdXtL34P71FI6qnzyp4T7k8D/yDoDaxAHo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > the correct place should be: > > @@ -1329,6 +1326,10 @@ static int migrate_folio_move(free_folio_t > put_new_folio, unsigned long private, > if (anon_vma) > put_anon_vma(anon_vma); > folio_unlock(src); > + > + if (folio_test_anon(src)) > + mod_mthp_stat(folio_order(src), MTHP_STAT_NR_ANON, 1); > + > migrate_folio_done(src, reason); > > return rc; > > Without this modification in migration code, my tests fail, anon_num can > become negative. I was wondering if we should do it in __folio_migrate_mapping(). There, we set newfolio->mapping. -- Cheers, David / dhildenb