From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E767C7115A for ; Thu, 19 Jun 2025 11:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DB596B00A1; Thu, 19 Jun 2025 07:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B3446B00A3; Thu, 19 Jun 2025 07:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE4206B00A4; Thu, 19 Jun 2025 07:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DDBE16B00A1 for ; Thu, 19 Jun 2025 07:31:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4A3431D73E8 for ; Thu, 19 Jun 2025 11:31:55 +0000 (UTC) X-FDA: 83571935790.29.0F49459 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id D98CC2000E for ; Thu, 19 Jun 2025 11:31:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ORRDZCJo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CawkEKS+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ORRDZCJo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CawkEKS+; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750332713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vy6q/qAZZ4wtLIbHS8N+vM6XFaUQj9p52F4nf7N5GdM=; b=v8n/6BC+VvMY6htHdtb7+UG4zlfxinOFwD8LcrIGaNV6fnTXwH9OH1VHmBLMnShe4XFLSX 604bfsu6+XqWslFqckC++B7JT/NMf2NHQCW06ytdZ98PGzjsCRSaWT+pztNugyORowOy5n CtW7cTRvJz2JKZMK22HjW/XZ0nXcFYo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ORRDZCJo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CawkEKS+; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ORRDZCJo; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CawkEKS+; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750332713; a=rsa-sha256; cv=none; b=tr8QnZlu395fW9wpTn0BDOPN3w8Nnder7lxTsR2LG2G9ezC8i2vkbc0vS4szDu6flhs13O Z1HbthTqplEECEE3v1jXzO5THktEj07H4iJ7W6gWfZMw8A4o1v6DyiOoAFOpAOTu7qtDdd aBBEtNTfljrHtnWIYpJxgHqxeLpCmYw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F16ED21167; Thu, 19 Jun 2025 11:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750332711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vy6q/qAZZ4wtLIbHS8N+vM6XFaUQj9p52F4nf7N5GdM=; b=ORRDZCJoBM26nDpjd/KgUa/6ZP6tTmYRsVXaRbUN5TowbQQxCyChfOUTcYOFgRdwH7/NWe t93sXgztHbsGfUDdQHOkOYx60mw4QvZHCvcjHbDpI9z36SFidB9BMD9sSeXPPkdlEPPdpx IsNy7wdd8MXe2iaL8Kf+a/WuWlGGaMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750332711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vy6q/qAZZ4wtLIbHS8N+vM6XFaUQj9p52F4nf7N5GdM=; b=CawkEKS+EXyfYcE/uK+4SPivyxpmZHr+oR1eiPkK419rJYeqwUtwQX2UXZTSWdXK6Eq99z EPyKy0xEKIcKsBAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750332711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vy6q/qAZZ4wtLIbHS8N+vM6XFaUQj9p52F4nf7N5GdM=; b=ORRDZCJoBM26nDpjd/KgUa/6ZP6tTmYRsVXaRbUN5TowbQQxCyChfOUTcYOFgRdwH7/NWe t93sXgztHbsGfUDdQHOkOYx60mw4QvZHCvcjHbDpI9z36SFidB9BMD9sSeXPPkdlEPPdpx IsNy7wdd8MXe2iaL8Kf+a/WuWlGGaMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750332711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Vy6q/qAZZ4wtLIbHS8N+vM6XFaUQj9p52F4nf7N5GdM=; b=CawkEKS+EXyfYcE/uK+4SPivyxpmZHr+oR1eiPkK419rJYeqwUtwQX2UXZTSWdXK6Eq99z EPyKy0xEKIcKsBAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8F9E913721; Thu, 19 Jun 2025 11:31:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SfepIib1U2htbAAAD6G6ig (envelope-from ); Thu, 19 Jun 2025 11:31:50 +0000 Message-ID: Date: Thu, 19 Jun 2025 13:31:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: change vm_get_page_prot() to accept vm_flags_t argument Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: Russell King , Catalin Marinas , Will Deacon , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S . Miller" , Andreas Larsson , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Alexander Viro , Christian Brauner , Jan Kara , Kees Cook , Peter Xu , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Xu Xin , Chengming Zhou , Hugh Dickins , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Rik van Riel , Harry Yoo , Dan Williams , Matthew Wilcox , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jason Gunthorpe , John Hubbard , Muchun Song , Oscar Salvador , Jann Horn , Pedro Falcato , Johannes Weiner , Qi Zheng , Shakeel Butt , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, sparclinux@vger.kernel.org, linux-sgx@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-trace-kernel@vger.kernel.org References: From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: D98CC2000E X-Stat-Signature: e5bnqpq4jg9yj13en8jkn535ztqbyheg X-HE-Tag: 1750332712-83002 X-HE-Meta: U2FsdGVkX1+E52vwHpLxgdUQMe8XRK3MpoKR0TLVHwsLZ5NBpI/Va7hIqP2SUId/JS9e++LKULfGyrSpHwetHrFng02eTrdPQAq7AX2hWtHo+lBo18cb2cdl2ChT20DZVzb4UIPqZR5XFZDC3+HQqmQIqqD3ixRptQ4EFc4QMDu3c5FMI9ScXRTR9ctOsrLBjejPxLXA/S63Yabw+IWX1t2QoOUeQdcfiJCoQkNCFVQStmT14H6SRTkFN2sdZaQ9mcCAZb09//bzhZHW6SKnZXuNHHz37OkuOUkDEo+Nbq/mSNdcc/TyxLmrHmTAdmR6V6Xd2rUHLL6HgA3NBEBId7SoUdRdn9or1kUuNjC0JWW/yYGJ5fmhuYrIs69/OxKic1oQKDAKLcPEYaOfkSgJAIW0Q6lv26WtjqZarSpUUP/QM+F5lXhDaompuPGaGfbq21CuJ33FSLYAJc+ID36ed+1AO7n1dL65uNPZ/C+abqn2kgothI4+4YHOwA3MRENjqToJYp3pu2efCC1E6LfGSUrKKZIqekw11wsxu9Xjw/Dm8L1X4m1dxGO2LpDuKfNvRZZyG4BNQ3OlJ2HodGOxGyMGNuZ8TYH7JgzTTBQSyPcHyhVcwKdCtPUwPm36V98ZHOi/30XJPDRNooXQsmPO0RuiwwtOBKzC6OZbL2zWIPAfFQBJ6D3zCnq5/O1OJWUru8fjRgBWh7gdIRQFEltTh0ujQye437w3k4vG5lpoNilYHcAdJuxdA6LrbXXG828nQCcNZJumiGhVBH6ycu6Inf9Kyix3i2SsPF1lNUgItQtUjqDUrpg8pizjQFDC2AIj6ryP+gxbUEKrucByTH9+4VH3wG5mglzS77WkqtrTy1kDlpNtBheOp+/9a4dc/htnsfymS+RwLRtQBSWLVyPEvw0sNJaqkeRa7ORH62kGMGtNlgskeKilMLf8S2YhhQdTnmE1SwMgNX3BPABWKg5 U8VvQfV/ VcwPfnlhsMMDZR0vBEBguoxo1bCk3cKgJwD/2JTjo6inEWNwGTCps5PXmQOLNjGtBHyHjir9jtUZml6KkVr9SbviXWizrXXDAffoEUgBPzY+3CEbbNo4wE2r6PZXSLQ5SovDPJe7mHqrkbKg9Uu1N/ArRQWfFhOWSB5gJoKR5q5IcTCeN0uD0AHinSfRNzWHe/AgnBGwk7B8qQWZlPWHOdVgQk8NMaLGuYwcrkAKrO2Ar4lYV4cHUj7OGmuR2rCqwSUyuwuhY6LnwKmXuDB04wn4BvpmQsvU+uTBuYiOnSGU2AOFHQM6WR6IrT3ftORQi7O+4EoWd4likxwrWutiNKiFWr2/Cgu3yG1mG/B9rPG+a6F9TCI2vAdNYlWOMjinBunV1s5csynPW5c8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/18/25 21:42, Lorenzo Stoakes wrote: > We abstract the type of the VMA flags to vm_flags_t, however in may places > it is simply assumed this is unsigned long, which is simply incorrect. > > At the moment this is simply an incongruity, however in future we plan to > change this type and therefore this change is a critical requirement for > doing so. > > Overall, this patch does not introduce any functional change. > > Signed-off-by: Lorenzo Stoakes > diff --git a/arch/powerpc/include/asm/book3s/64/pkeys.h b/arch/powerpc/include/asm/book3s/64/pkeys.h > index 5b178139f3c0..6f2075636591 100644 > --- a/arch/powerpc/include/asm/book3s/64/pkeys.h > +++ b/arch/powerpc/include/asm/book3s/64/pkeys.h > @@ -4,8 +4,9 @@ > #define _ASM_POWERPC_BOOK3S_64_PKEYS_H > > #include > +#include Hopefully not causing a circular header include. > -static inline u64 vmflag_to_pte_pkey_bits(u64 vm_flags) > +static inline u64 vmflag_to_pte_pkey_bits(vm_flags_t vm_flags) Is this change rather for patch 3? It's not changing vm_get_page_prot(). OTOH git grep shows me you missed: arch/powerpc/mm/book3s64/pgtable.c:pgprot_t vm_get_page_prot(unsigned long vm_flags) With that sorted out, feel free to add: Reviewed-by: Vlastimil Babka Thanks!