From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF478C433EF for ; Mon, 2 May 2022 00:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 861D36B0073; Sun, 1 May 2022 20:13:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80EF46B0074; Sun, 1 May 2022 20:13:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D7186B0075; Sun, 1 May 2022 20:13:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 5F0B36B0073 for ; Sun, 1 May 2022 20:13:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 40277210BA for ; Mon, 2 May 2022 00:13:25 +0000 (UTC) X-FDA: 79418878770.11.D47BBCC Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 86FAF1C002F for ; Mon, 2 May 2022 00:13:19 +0000 (UTC) Received: by mail-pl1-f172.google.com with SMTP id n14so4449420plf.3 for ; Sun, 01 May 2022 17:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=9R9pDWjRYUdR6pwNJcQ0BhfgQvycoYpQ1Dw84U1v8cI=; b=U19vS23LukiEuLMoapkp69LTWVJV0KGALWAFdzg7aIINUEMbbSyJlAdt214ftmsJKy b5s4aVb+usOqiuK3gMbsk2r452wCBBmosOWbCJjuui+3coFh1Ydb91n7yBJ0+BWRLyd4 M18KDCgKoO9zPrr+2lEawjACZLTB+fe9UieGxC5S2Orjuc8MLrwE9bYNyQNlcSGDembS qrB+TneqZ5/Cxiy2pEn7hP1mtjnNHPJHgzfUyojjQBxCzYlk6Yzv/7FR9jOQfp2ISqb1 4BcV0yS4cXArzF2s+GSW8f2PJr1EgEVWpeip1hU0w9DMO5wFFcccUFqwZxmV+J0SfZG6 mkJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=9R9pDWjRYUdR6pwNJcQ0BhfgQvycoYpQ1Dw84U1v8cI=; b=wEcgPTcbRfJNoyDsSXsnoZBYIyOa7RbkkrdSu8Nb40VwuArq54lwdMS/bvWJTGH0+L 4ElJcVX4K5T7oakfBb91PuFYnpqPUvBBOlKcI9O+yj3YEIKwsTviE5m+rDd7QNzr/Wpe dFTZ3XgRjqIZtgJhDTQyAn4xXG/pMe3upLPn9JxK4ApNIZfl3UnaQmYucYKAVjbsO7Y0 07yyEIksk8Kbz6s7ya89gg5qMDsA3+nd925AQZz1lZXLSoN2fgIrp4BdgtKOxFbsFXWe 1R1Y5iJuP2Rh+aLUk/gKzyC3oHjZYWJOL7wAVqcmdj2N9k6BqkGBQ6PHRhHadSKjsyYm yWqA== X-Gm-Message-State: AOAM530rJGI8+uCDYrkKmc5eIX8+ppjeJwxMiRuWSBwGO08P7KaTB5JX f4vyqlK7Uvhyi4HKSU8FwJ0Nxw== X-Google-Smtp-Source: ABdhPJzw8TVyU1eweUd06dvUpu2vHox9CWqMTniqEgpck5aBJTB+93ZXTK/VG9qL0AsMgBN6GEhOQQ== X-Received: by 2002:a17:902:aa46:b0:159:6cb:163 with SMTP id c6-20020a170902aa4600b0015906cb0163mr9152926plr.83.1651450403646; Sun, 01 May 2022 17:13:23 -0700 (PDT) Received: from [2620:15c:29:204:e310:ef81:d548:9992] ([2620:15c:29:204:e310:ef81:d548:9992]) by smtp.gmail.com with ESMTPSA id c5-20020a170902d90500b0015e8d4eb1fasm3384682plz.68.2022.05.01.17.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 May 2022 17:13:23 -0700 (PDT) Date: Sun, 1 May 2022 17:13:22 -0700 (PDT) From: David Rientjes To: andrey.konovalov@linux.dev cc: Andrew Morton , Andrey Konovalov , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Peter Collingbourne , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 2/2] mm: slab: fix comment for __assume_kmalloc_alignment In-Reply-To: <84d8142747230f2015eaf9705ee7c2e1a9f56596.1651161548.git.andreyknvl@google.com> Message-ID: References: <84d8142747230f2015eaf9705ee7c2e1a9f56596.1651161548.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 86FAF1C002F X-Stat-Signature: out7cfdhkmz6qeq5n453ufin45skrgaq Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=U19vS23L; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of rientjes@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=rientjes@google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651450399-192506 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 28 Apr 2022, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > The comment next to the __assume_kmalloc_alignment definition is not > precise: kmalloc relies on kmem_cache_alloc, so kmalloc technically returns > pointers aligned to both ARCH_KMALLOC_MINALIGN and ARCH_SLAB_MINALIGN, > not only to ARCH_KMALLOC_MINALIGN. > > (See create_kmalloc_cache()->create_boot_cache()->calculate_alignment() > for SLAB and SLUB and __do_kmalloc_node() for SLOB.) > > Clarify the comment. > > The assumption specified by __assume_kmalloc_alignment is still correct, > although it can be made stronger. I'll leave this to a separate patch. > > Signed-off-by: Andrey Konovalov Acked-by: David Rientjes