From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65021C433F5 for ; Thu, 17 Feb 2022 08:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E29056B0074; Thu, 17 Feb 2022 03:58:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD8B46B0075; Thu, 17 Feb 2022 03:58:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79A36B0078; Thu, 17 Feb 2022 03:58:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id B85346B0074 for ; Thu, 17 Feb 2022 03:58:31 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7BB8421829 for ; Thu, 17 Feb 2022 08:58:31 +0000 (UTC) X-FDA: 79151670822.01.466DB4A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 20B2540004 for ; Thu, 17 Feb 2022 08:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645088310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GrFM36GXCLpEs5PixdxLnf8cSAbh9T3Q4gJPAQrISRU=; b=GN5Y/COv1cOfj6T3fJ9juzMrq7G75BSB89WmAy8cc7oztm8ANsn4dSXYN8lwKJwliroJNH Z+uVuHf/NuB3wGFyCu2y6hfdtbR/2sfkZmU1gpOdCfwF6FdXWvjg5yHVAso+tr1kM5nryR M+6s9T72mpMOm8mlKOaixq7URgK1tW0= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-58-V1DTlx7FPkKYMwIQpvzrCQ-1; Thu, 17 Feb 2022 03:58:28 -0500 X-MC-Unique: V1DTlx7FPkKYMwIQpvzrCQ-1 Received: by mail-ed1-f72.google.com with SMTP id s7-20020a508dc7000000b0040f29ccd65aso3164847edh.1 for ; Thu, 17 Feb 2022 00:58:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=GrFM36GXCLpEs5PixdxLnf8cSAbh9T3Q4gJPAQrISRU=; b=go0DzZs1FWgggbnez1Uzu+I5RHXdSCkB9mzSyy/3kVxHikXONpS+phn95WPdYVqxgr 2+56dQSlH04YgpbvL8BCqC8hpmOik422CyiLlBD0oBxz5QbLl44vf5reIna9cjjnkO1f HNBhgyXLJpV8AYXyiWyvdQvnPOoFU5v4II5Bs0A1CCK/lqjrAUvqspLkIKWnJBu4n5dg hmpH5O632gUx4c1fhplqK8Rj0v3ugaFQ69Ziy5l63lDpR+mQYao7/hOOTFV/wOQT4gSl c/TqXqntfmK/+G2h2NW5/BuJcmFtVf6eFCVgvN1btwP3bXprgklRPDNnhII2DuERfS5K KOdw== X-Gm-Message-State: AOAM530AXuZ9N0dsE/8DQQEVvbwgnFya1QBDYr8eYnRFbRk7CvI3vSg6 YPyQrkk67yL2b9+9AkaJcDkp+2YjCTe257UVMbOi8YVIq9Z2EaLqYqgSDiGI2NyWGHW1VJNFoGy hbjDQp//GZ6U= X-Received: by 2002:a17:907:9195:b0:6ce:e31e:361e with SMTP id bp21-20020a170907919500b006cee31e361emr1510699ejb.349.1645088307503; Thu, 17 Feb 2022 00:58:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJz79VLxnC2xgHyODxqG8K1CPVfa4ThO9Tuq5uUbZRan2TYF0NgFCw5GjHBbvpCD+tBRn989fA== X-Received: by 2002:a17:907:9195:b0:6ce:e31e:361e with SMTP id bp21-20020a170907919500b006cee31e361emr1510686ejb.349.1645088307249; Thu, 17 Feb 2022 00:58:27 -0800 (PST) Received: from ?IPV6:2003:cb:c711:b800:254c:2d22:aab2:20a? (p200300cbc711b800254c2d22aab2020a.dip0.t-ipconnect.de. [2003:cb:c711:b800:254c:2d22:aab2:20a]) by smtp.gmail.com with ESMTPSA id 29sm935809ejk.107.2022.02.17.00.58.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Feb 2022 00:58:26 -0800 (PST) Message-ID: Date: Thu, 17 Feb 2022 09:58:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 1/3] mm: enable MADV_DONTNEED for hugetlb mappings To: Yin Fengwei , Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Naoya Horiguchi , Axel Rasmussen , Mina Almasry , Michal Hocko , Peter Xu , Andrea Arcangeli , Shuah Khan , Mike Rapoport , Andrew Morton References: <20220215002348.128823-1-mike.kravetz@oracle.com> <20220215002348.128823-2-mike.kravetz@oracle.com> <57fa170a-253b-932f-0261-b4905881d888@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <57fa170a-253b-932f-0261-b4905881d888@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 20B2540004 X-Stat-Signature: f4aj1f1cuy89ajhdq9eq8d48ytg778r5 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GN5Y/COv"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1645088310-261015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.02.22 09:32, Yin Fengwei wrote: > > > On 2022/2/15 08:23, Mike Kravetz wrote: >> MADV_DONTNEED is currently disabled for hugetlb mappings. This >> certainly makes sense in shared file mappings as the pagecache maintains >> a reference to the page and it will never be freed. However, it could >> be useful to unmap and free pages in private mappings. In addition, >> userfaultfd minor fault users may be able to simplify code by using >> MADV_DONTNEED. >> >> The primary thing preventing MADV_DONTNEED from working on hugetlb >> mappings is a check in can_madv_lru_vma(). To allow support for hugetlb >> mappings create and use a new routine madvise_dontneed_free_valid_vma() >> that allows hugetlb mappings in this specific case. >> >> For normal mappings, madvise requires the start address be PAGE aligned >> and rounds up length to the next multiple of PAGE_SIZE. Do similarly > > In man page of mmap, NOTE for "Huge page (Huge TLB) mappings": > > "For munmap(), addr, and length must both be a multiple of the > underlying huge page size." > > Should we apply same rule to MADV_DONTNEED? Thanks. madvise() already has different rules than mmap() for ordinary pages, so we'd much rather try staying consistent with madvise() rules. -- Thanks, David / dhildenb