From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BA5C001DF for ; Mon, 7 Aug 2023 00:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0411F6B0072; Sun, 6 Aug 2023 20:38:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F33C36B0074; Sun, 6 Aug 2023 20:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFB756B0075; Sun, 6 Aug 2023 20:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CE3BA6B0072 for ; Sun, 6 Aug 2023 20:38:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 917A51C95B4 for ; Mon, 7 Aug 2023 00:38:01 +0000 (UTC) X-FDA: 81095446362.29.B12565C Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf17.hostedemail.com (Postfix) with ESMTP id 5C19B40011 for ; Mon, 7 Aug 2023 00:37:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691368679; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hMQpWJkX0DuqGipabtFOBLDGqM64npzRBr+YkoU74zY=; b=XumdbyA0OvTAaG5j5qN0R6o7AZJDkIQNyBLeAQAxbvinMc5RnlWn+/A4ZWwatfgTMI6l/J xleZXx4FlnY38eLy/LzaaIg6BBckLDBUPJDwjWneJVSwQ/zP0MJeYc07ZwO/Dh84IuD+AR ILXZfmHsNBHDri01Z+5/36Q+IfvarZ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691368679; a=rsa-sha256; cv=none; b=7z0M2hP908ErN6rGj3SEPMDR2jAIg04N65DEvQ+dznLoaDbpvjLQKN3kMbu3jUE8dI2Sac +A2B14+m5LTJplI2kGnCi1t9Jsq6ADDvVFRbBvWXV0yRLq/VbruVZnZizl1bQSIxSYY8u+ Yt4in0fxTOlQrPuI5CqTXXlTZHJngec= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RJy8b6D0Vz4f3lDj for ; Mon, 7 Aug 2023 08:37:51 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP1 (Coremail) with SMTP id cCh0CgA3si7fPNBkOuprAA--.26529S2; Mon, 07 Aug 2023 08:37:52 +0800 (CST) Subject: Re: [PATCH 1/9] mm/compaction: use correct list in move_freelist_{head}/{tail} To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com References: <20230805110711.2975149-1-shikemeng@huaweicloud.com> <20230805110711.2975149-2-shikemeng@huaweicloud.com> <20230805101109.740fdc21418d0753c4658df1@linux-foundation.org> From: Kemeng Shi Message-ID: Date: Mon, 7 Aug 2023 08:37:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230805101109.740fdc21418d0753c4658df1@linux-foundation.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:cCh0CgA3si7fPNBkOuprAA--.26529S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Ww4rAw4xKryxJr1UGFW3ZFb_yoW8GFy7pr WFkF4UJF4UArW0yFnrXw4q9w18tF47Zr1Yk3y5uFW7AFn8trZrtF9akF4Uu393GrWjkrs0 vrsrKrsIkrW3Ar7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyKb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04 k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUzsqWUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Stat-Signature: rhhhcm8mcpurutuarub49mp18f6imcxm X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5C19B40011 X-Rspam-User: X-HE-Tag: 1691368677-902699 X-HE-Meta: U2FsdGVkX19Z16BeqBMKMPZoty5gr9Ie/NiF/+2ZmKCV/JtpcL36puiUUJoW8IJoH8UG07cYnUeaSKQB5ivOg/HN68/8EN9Z72FBsq6NwfL9Rx/xCfPy+mV1RR/102tDTeh+gIwai6/6M229a2mMrZPdKrpTr/79JJSZewuVmJ82O23nFfW3wRYnVH/gZcCzZzspDvK37/5lnypeeo8yTmpJdB0hYW/sFySaKIl21kWjg5tfvH+z/6f5IF9p5QQ+Ope/ou2ep/IsQ0zc2x+8UhWx/y+C/TqbS5AEJM5rLnX6CfQ5TkWCx61yczIpnQFs1/czgSIsu56rn+jxe0w2PPRaAr1Q9+GkJor19r8RBVvu4g8uJhG+Yi9HGa5tvfI4zttoIWw/Fo3AN5nPKMItbylooBU03w3O597kNwANQo1Hu38iPhRW9OeGoC2wL1/O8MLkrVEEW68tzGcquOHDiQX4eyGZBtUS+uue4E9pxxWuJC3fYAXJEIllrM1qp0V1+V2fwvuxfpxCg22EGjFJDq26NbK3YxDLW1MThmVMpjSH3KlAoPoy2Lq/dU+HyMpwPaFKIZl4HpfK38SOttDfcWWLI7HXDUEZFEKCTaafcg5iYiPF+tz6DK5bE5QbpLd3HOd7w5I2OY9QD4PFGt4sEiUEAp9cIuzu0i2XBH7ca35Wv4GmVAaxv5IXI4j7vjYybAqzvoLAyniZqCY4WWxdXTLaqYCWrMoO9IJgPf8sONLwiWEq4Hnscm3k7t9EiaskhyK9I7oGf91H37oUGwFFOLlgGGknH/udRP0nddGnElxMrNfQhoqqkeuKSILFPyktCQ+cjTCcuQUHIXe7+ea3xJRh3nw44a1cSMtmoWT66Kgwf66/Iru5Gt9O+x88IcpFiLCGfnrLgOQgXzO83lK2yHZX4SlvKfSnHx7zLXBAB02RlWsGRfiRcZrtCXRvhxLNuyTY1h3o0AhhQkMb2E2 vRe8n58i FvAoPHVI0JmkuHkeNENIeNd9ga/y5NSUKP0yG9/Aveg2/HKiHfO+ih8gjLGuGGk+MLgRZfaRrHpK7ofndsO+PGSF27vQ0MILI9sMRkbevpkEAGlgKsNwUxzDDdJ1kEdLe1etdnMxyJ5/9SEXVUa/sVgMmk0X4s7CbPV9VsjpYutZjsdcXY29s4yrYharg3CYRUeK8PaFmgjIBw14oQ9w/noO5t8UmwBahLUBA4KIHBHRAhJGoP/u7zrsS2Du0zfxAeNQjjjv7e95+9E43mHbp9/pOn00tcs8tL/57 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 8/6/2023 1:11 AM, Andrew Morton wrote: > On Sat, 5 Aug 2023 19:07:03 +0800 Kemeng Shi wrote: > >> The freepage is chained with buddy_list in freelist head. Use buddy_list >> instead of lru to correct the list operation. >> >> ... >> >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -1395,8 +1395,8 @@ move_freelist_head(struct list_head *freelist, struct page *freepage) >> { >> LIST_HEAD(sublist); >> >> - if (!list_is_last(freelist, &freepage->lru)) { >> - list_cut_before(&sublist, freelist, &freepage->lru); >> + if (!list_is_last(freelist, &freepage->buddy_list)) { >> + list_cut_before(&sublist, freelist, &freepage->buddy_list); >> list_splice_tail(&sublist, freelist); >> } >> } >> @@ -1412,8 +1412,8 @@ move_freelist_tail(struct list_head *freelist, struct page *freepage) >> { >> LIST_HEAD(sublist); >> >> - if (!list_is_first(freelist, &freepage->lru)) { >> - list_cut_position(&sublist, freelist, &freepage->lru); >> + if (!list_is_first(freelist, &freepage->buddy_list)) { >> + list_cut_position(&sublist, freelist, &freepage->buddy_list); >> list_splice_tail(&sublist, freelist); >> } >> } > > This looks like a significant error. Can we speculate about the > possible runtime effects? > > > It seems no runtime effects for now as lru and buddy_list share the same memory address in a union.