From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2A8C3DA6E for ; Sat, 23 Dec 2023 13:32:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B7E66B006E; Sat, 23 Dec 2023 08:32:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 366856B0071; Sat, 23 Dec 2023 08:32:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22E786B0072; Sat, 23 Dec 2023 08:32:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1108A6B006E for ; Sat, 23 Dec 2023 08:32:22 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D51A5160ACE for ; Sat, 23 Dec 2023 13:32:21 +0000 (UTC) X-FDA: 81598172082.27.C0C6966 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf21.hostedemail.com (Postfix) with ESMTP id 489971C000D for ; Sat, 23 Dec 2023 13:32:16 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf21.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703338338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mHtLgD4vL+XswVBYByVqVHM5FfBvinzzdh5hkBKfVE8=; b=ruZil2ijkgV2z7qUPWsZdRw638Z4MP49AMc30HtKDEJkSDc0+B0/EKGRdRaqbHOanq4PvK XeIzZZTQHrXen9adsh+vMhPO3LSNeX1Sadeia4JrLwcdCcDP5mS3znKg+E9LHPfMYHuvOI iPtcll8J86efl87RcR3s8Ez1Y8POBQM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf21.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703338338; a=rsa-sha256; cv=none; b=5Qc2/kvT1OJ22LHsZsLaulg1IDjDqrI/iwiXM9oDPHLZpqHipaIJlaTJAIHXI2g15g6Gx1 FcUrArqPYscTL48a5QtgVapVBG/IWGC0TH5pJTy6eo5C9NytR8VZQ2BiNOsSjauFYqeuAG BhKNidH4iBNeIC+jwknj6g1dKygNy4k= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=27;SR=0;TI=SMTPD_---0Vz1O0tF_1703338328; Received: from 30.25.242.252(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vz1O0tF_1703338328) by smtp.aliyun-inc.com; Sat, 23 Dec 2023 21:32:11 +0800 Message-ID: Date: Sat, 23 Dec 2023 21:32:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix EROFS Kconfig To: Jingbo Xu , David Howells , Gao Xiang Cc: Chao Yu , Yue Hu , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-erofs@lists.ozlabs.org, Jeff Layton References: <20231221132400.1601991-5-dhowells@redhat.com> <20231221132400.1601991-1-dhowells@redhat.com> <2265065.1703250126@warthog.procyon.org.uk> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 489971C000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 6ck3kdpq3n11p3sy634sk4d1oj8az1iw X-HE-Tag: 1703338336-186332 X-HE-Meta: U2FsdGVkX1+GRW2dgI/+odzd9j8T1S8dMFQ4zWbW6OSSfhQEPkLB/JVIX6J7IaqEpCeVNGe35YzoVjHQJYyrs7Lnom3lCSlalvPmZArfiV9cVpj3A+n7W1n1rX25jPOSHJCalOpaoDPi7QjR/pijVFxyCUDr7dc760qd74nlwziVFjMl2rmrRiPw0gYmxUKO6Ts56IAurhcJnrnypIOE/wkcw7WM0Jmjm2x1/zt7eoO1DQ2164UNYOFYqt7N9dXIjh4ItO800brYJxsQqLpjrVnVfOkcs/Av7cEgYaVkBYYeddtO6cxMOJXK7NAy+yIoZBw+4A9iFXJuGvijgg9De6nipetUGJaFPq72viYuM8i7lbl52wGlxtNMB1Zg1NotKk+NMgqkfdFWR9vQAjTlKNOLuAF3N+RjhthqiWmPL0k1E8GzgK8kLKuJH87Sk4kQqVfQwh3KDmS76n7yZYCUH9RXyNNcmnmGk5+OYU5kl/iKoFoo6wCLLxhFNInF6x8nRuLoGISqZ8XWqu3yxwUFORC15AGN7CMZOjs26utwyAbk5EIXA3qSGZ/+VEomh/dbMvG+xm3HZSdoktL4aZTEod1+oBNAdnYhJk2dIyjD0KQnryROYNCQymQ3Z3DsWyCNyDOA9yJh3SCCMLjYGQj0AjKxbt4PJVE3HZhAlwboAYI6OdSV97skhgBb00spf5a1aplhQOg8zo6t4rnAXxi6TZlEyW0nIlMPJECZLXjPRNAIo1nEjne9GPGKHMwxbsAt2iPurozg7LH4YrC3pHMDCXpG2IonBlBO1BGnux5NpoSJ6+6a74ccnRRpivK6XVBPw7fCoHhfV43eEwS/Woztd50t7KXI1lqTsmwm105d/7mkEZU73uHxgDqIVOpePxsafoBmqeLKT2d8gps/Sl8vaDmLkXfChBeWM5+T1GtkdPhVGkmFetD6fwI+hSLvYbAjuTfEvENMa3D3kt0cgwi TVSCSXl1 hN8Pv8LmccW6kiDVDklrrDd26T+BVuNtOGGJRiCMBI7ttgoDMX2qYUPH3qv21HZDNz+uVFPh3P8cMgrLIgA+MCiK1pm8NxZR2hH/kEAarKnGkRCGudcXja3Mp5j7b5cdiADeB6Y7618ngY1UZBlf/jKoJ/A2uE060d6T9LJ927ClLzjcvr0lgEd4CMZ39TQo5UF534p3XVax9qSqQ6SKpW4oq7BVUifCKgBOC5/in0ZXFeWD07LMnUtGogg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David and Jingbo, On 2023/12/23 11:55, Jingbo Xu wrote: > Hi, > > On 12/22/23 9:02 PM, David Howells wrote: >> This needs an additional change (see attached). >> >> diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig >> index 1d318f85232d..1949763e66aa 100644 >> --- a/fs/erofs/Kconfig >> +++ b/fs/erofs/Kconfig >> @@ -114,7 +114,8 @@ config EROFS_FS_ZIP_DEFLATE >> >> config EROFS_FS_ONDEMAND >> bool "EROFS fscache-based on-demand read support" >> - depends on CACHEFILES_ONDEMAND && (EROFS_FS=m && FSCACHE || EROFS_FS=y && FSCACHE=y) >> + depends on CACHEFILES_ONDEMAND && FSCACHE && \ >> + (EROFS_FS=m && NETFS_SUPPORT || EROFS_FS=y && NETFS_SUPPORT=y) >> default n >> help >> This permits EROFS to use fscache-backed data blobs with on-demand >> > > Thanks for the special reminder. I noticed that it has been included in > this commit[*] in the dev tree. > > [*] > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=netfs-lib&id=7472173cc3baf4a0bd8c803e56c37efdb8388f1c > > > Besides I noticed an issue when trying to configure EROFS_FS_ONDEMAND. > The above kconfig indicates that EROFS_FS_ONDEMAND depends on > NETFS_SUPPORT, while NETFS_SUPPORT has no prompt in menuconfig and can > only be selected by, e.g. fs/ceph/Kconfig: > > config CEPH_FS > select NETFS_SUPPORT > > IOW EROFS_FS_ONDEMAND will not be prompted and has no way being > configured if NETFS_SUPPORT itself is not selected by any other filesystem. > > > I tried to fix this in following way: > > diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig > index 1949763e66aa..5b7b71e537f1 100644 > --- a/fs/erofs/Kconfig > +++ b/fs/erofs/Kconfig > @@ -5,6 +5,7 @@ config EROFS_FS > depends on BLOCK > select FS_IOMAP > select LIBCRC32C > + select NETFS_SUPPORT if EROFS_FS_ONDEMAND > help > EROFS (Enhanced Read-Only File System) is a lightweight read-only > file system with modern designs (e.g. no buffer heads, inline > @@ -114,8 +115,10 @@ config EROFS_FS_ZIP_DEFLATE > > config EROFS_FS_ONDEMAND > bool "EROFS fscache-based on-demand read support" > - depends on CACHEFILES_ONDEMAND && FSCACHE && \ > - (EROFS_FS=m && NETFS_SUPPORT || EROFS_FS=y && > NETFS_SUPPORT=y) > + depends on EROFS_FS > + select FSCACHE > default n > help > This permits EROFS to use fscache-backed data blobs with on-demand > > > But still the dependency for CACHEFILES_ONDEMAND and CACHEFILES can not > be resolved. Though CACHEFILES is not a must during the linking stage > as EROFS only calls fscache APIs directly, CACHEFILES is indeed needed > to ensure that the EROFS on-demand functionality works at runtime. > > If we let EROFS_FS_ONDEMAND select CACHEFILES_ONDEMAND, then only > CACHEFILES_ONDEMAND will be selected while CACHEFILES can be still N. > Maybe EROFS_FS_ONDEMAND needs to selct both CACHEFILES_ONDEMAND and > CACHEFILES? I think the main point here is that we don't have an explicit menuconfig item for either netfs or fscache directly. In principle, EROFS ondemand feature only needs fscache "volume and cookie" management framework as well as cachefiles since they're all needed to manage EROFS cached blobs, but I'm fine if that needs NETFS_SUPPORT is also enabled. If netfs doesn't have a plan for a new explicit menuconfig item for users to use, I think we have to enable as below: diff --git a/fs/erofs/Kconfig b/fs/erofs/Kconfig index 1d318f85232d..fffd3919343e 100644 --- a/fs/erofs/Kconfig +++ b/fs/erofs/Kconfig @@ -114,8 +114,11 @@ config EROFS_FS_ZIP_DEFLATE config EROFS_FS_ONDEMAND bool "EROFS fscache-based on-demand read support" - depends on CACHEFILES_ONDEMAND && (EROFS_FS=m && FSCACHE || EROFS_FS=y && FSCACHE=y) - default n + depends on EROFS_FS + select NETFS_SUPPORT + select FSCACHE + select CACHEFILES + select CACHEFILES_ONDEMAND help This permits EROFS to use fscache-backed data blobs with on-demand read support. -- 2.39.3 But cachefiles won't be complied as modules anymore. Does it sounds good? Thanks, Gao Xiang