From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A6DCC433EF for ; Mon, 7 Mar 2022 02:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0BD78D0002; Sun, 6 Mar 2022 21:23:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBA228D0001; Sun, 6 Mar 2022 21:23:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA93D8D0002; Sun, 6 Mar 2022 21:23:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 9979A8D0001 for ; Sun, 6 Mar 2022 21:23:58 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3C166A0FBE for ; Mon, 7 Mar 2022 02:23:58 +0000 (UTC) X-FDA: 79215994956.25.2F06195 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by imf08.hostedemail.com (Postfix) with ESMTP id 93F18160002 for ; Mon, 7 Mar 2022 02:23:56 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R481e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=dtcccc@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0V6O3uDQ_1646619831; Received: from 30.97.48.243(mailfrom:dtcccc@linux.alibaba.com fp:SMTPD_---0V6O3uDQ_1646619831) by smtp.aliyun-inc.com(127.0.0.1); Mon, 07 Mar 2022 10:23:52 +0800 Message-ID: Date: Mon, 7 Mar 2022 10:23:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 2/2] kfence: Alloc kfence_pool after system startup Content-Language: en-US To: Marco Elver Cc: Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220305144858.17040-1-dtcccc@linux.alibaba.com> <20220305144858.17040-3-dtcccc@linux.alibaba.com> From: Tianchen Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 93F18160002 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf08.hostedemail.com: domain of dtcccc@linux.alibaba.com designates 115.124.30.45 as permitted sender) smtp.mailfrom=dtcccc@linux.alibaba.com X-Stat-Signature: m6x8gqaffepwwacxzpiob3xizut6mibx X-HE-Tag: 1646619836-212525 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/7 07:52, Marco Elver wrote: > On Sat, 5 Mar 2022 at 15:49, Tianchen Ding w= rote: > [...] >> +static int kfence_init_late(void) >> +{ >> + const unsigned long nr_pages =3D KFENCE_POOL_SIZE / PAGE_SIZE; >> + struct page *pages; >> + >> + pages =3D alloc_contig_pages(nr_pages, GFP_KERNEL, first_onlin= e_node, NULL); >=20 >> mm/kfence/core.c:836:17: error: implicit declaration of function =E2=80= =98alloc_contig_pages=E2=80=99 [-Werror=3Dimplicit-function-declaration] >=20 > This doesn't build without CMA. See ifdef CONFIG_CONTIG_ALLOC in > gfp.h, which declares alloc_contig_pages. >=20 > Will alloc_pages() work as you expect? If so, perhaps only use > alloc_contig_pages() #ifdef CONFIG_CONTIG_ALLOC. >=20 alloc_pages() will be fine. We could free "tail" pages after inited. Will send v3 soon. > Thanks, > -- Marco