From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A805DC25B4E for ; Sun, 22 Jan 2023 11:47:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D2EF6B0072; Sun, 22 Jan 2023 06:47:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35BD36B0073; Sun, 22 Jan 2023 06:47:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AE536B0074; Sun, 22 Jan 2023 06:47:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 05EF06B0072 for ; Sun, 22 Jan 2023 06:47:09 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C372B140477 for ; Sun, 22 Jan 2023 11:47:08 +0000 (UTC) X-FDA: 80382258936.15.9E77346 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf25.hostedemail.com (Postfix) with ESMTP id CD891A0012 for ; Sun, 22 Jan 2023 11:47:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=x60lhg9M; spf=pass (imf25.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674388026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M2dS08c5mDDQCSEte2hJr4AncAP49BS6JfkPW/bfJ8w=; b=3Y998fjCC9WJbuHzLQFTNM76y9Ha4h/uffMrFd6E5J64ucU+VNMxGCmCA1GyKdAlyKIrXA WuVvXiBdbnLaI/RFPFMdlhfoW9ZVOy6XJFlxXUoIc2N0qgSp+V65ZDNBzMEhCPdXbOun5G xUDXos92HDAmTjawvceLuEMgPz+CN8U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=x60lhg9M; spf=pass (imf25.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674388026; a=rsa-sha256; cv=none; b=7CaxdQleT9Q+nbP1qlTcexUoC8dnQajeduvkAJPi/yLMAvdH/vWPcWT+l1osyRfvQGo7rv q2aJC2G1c7TIAjKkKyPxCUHhyFX9EnXD/6S3UnOwGLmTpBjJ8/9M10xw+NwYzAcrjf3bih DTG2SIXwMYzX4JMAkLkuybOiSDKTkkw= Received: by mail-wm1-f52.google.com with SMTP id d4-20020a05600c3ac400b003db1de2aef0so6655124wms.2 for ; Sun, 22 Jan 2023 03:47:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=M2dS08c5mDDQCSEte2hJr4AncAP49BS6JfkPW/bfJ8w=; b=x60lhg9Ma84/nhgHooGxFDRzaGCTbna6N3OaUhRahz7oFK/Ej2LoBvR8cIclfA+YEc 075GAFy/Z+6wvaDI7Vtr/jDBAOmZuEsq7tCWLkeLwtI7bPex58Pm6EjC3JMzpJ+57MIn 5T0guh+4iRpkxNWNtfXUGJ63DWXecs+xrEq2+1kGSbEQy5zzLYNSKRU3hy9nS/WC9k2z Gw7aqPry1lPoo9c8A0gEHtEbhMhcD45BAJ6wFHyQcSt+myMtZ/qlgR2AaS8964Zn2P4p UWrCS1Ld/U0RPkqYhhWftQwPG1iq5ZpzAjpwY1XCjBtkkZztPouO1E9exFAGh5clvnfx PSYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M2dS08c5mDDQCSEte2hJr4AncAP49BS6JfkPW/bfJ8w=; b=napg5WoBoicVa+mQ92TNuMDrLvB4B+Qdvgsz+6OMVzoUfaukISc3Vb40NzjcJlIOq0 EFo9kIPKf1UkCaIhKm38KpT7081qppperQt+boaKM0TaleKOIoVe0J3hhVCDvFDpfM/x SYVh2dHTXFCmaOUMfn9+LNMd8u3p9iJcHqUczhk3AmXohDs/gvucCVjoT83EOV0Wep0O ouH42FkRGVyanopykxG8ucPAaEZMCATcDnvSfWihdoit2SLbKG9NZEGL8hOb3N8mBK6B zH1g+Lc6Er5MEz5GLKghYRCESwMFn67AQL/u67ODMBzF50EKm0Of62bpMW0JoL+Kit9Z tbCg== X-Gm-Message-State: AFqh2kri2Qv7YGlWDUbRQCnK66b5kJhNFpS7hHLrcfthc+O9kya1K30U rOEZ05Fr2G7I+z1LVQxFGlhKGw== X-Google-Smtp-Source: AMrXdXvv5SOq8oLh4MHQyQrfcxkhDTk8DLHjQASO2lJraohGjZ9veTwuZ0pwUHGY71DEX8EYBAct8g== X-Received: by 2002:a05:600c:4f82:b0:3db:25a0:ca5b with SMTP id n2-20020a05600c4f8200b003db25a0ca5bmr11762781wmq.37.1674388025485; Sun, 22 Jan 2023 03:47:05 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c350f00b003db0b0cc2afsm8452351wmq.30.2023.01.22.03.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:47:04 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:47:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 03/31] Documentation: Add binding for kalray,kv3-1-apic-gic Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-4-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-4-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CD891A0012 X-Rspam-User: X-Stat-Signature: gjmroyp7g8p44pnbr1buzyba1qg6xwiq X-HE-Tag: 1674388026-749107 X-HE-Meta: U2FsdGVkX1/jXUTT5ybnGrSFanbjwY4wqKjPGDI40XBQTi9sqahJBB6M2l2RAs4d0LNLAdbNuesY5lK6YquTcQroRvCjVCMQcTKc0POrMuCoqYaGKrQ6whhYyHlLiLjYp6199s4QfUCVJRA9PIljAqctTD1a0ES2W75dHlH8VGrnPo5YiZi4UnRQRSwejf8vgtNrskbgJdb/dKg8dGqUgxQERE9ErbA26SGDThi7ruT7QxAFehQn6XiS7cKBkDdm+wvc5HOVh7gDGL9DzkEytrX4wyaT+OSPKrKUsu1Ctf0/sTdMtod6UtqJ8DIZRtNEbWPBGgaJ7DRGyLSTsb8TPwKRngbJXybXB4bLpDLudlk5Q67tUnGQGCruZPKelEMc63yraPiLsx41Pw8ovcQNXZDWKql+5UnNjQVYpSpxlO7c6kyEP0G8CBF/PYIpeKbeVBdRqJUBjRx2AskTuBO31vsCefc9VzSQuyKNCp5XA/xbtua8QiPRYn0P+qRvPeMHrLVCLNkUoVmbGS/NmzfeALURCdJEvNkwjggqz4N8dSSJKvbz5CjmXCkfTHWDhPOXyYLn3VPl8M5IFuzNvxXEU9U1E3ZqaJFdfcfRYMRoOthjIC0lqrA+1Wa/5K+yaIF/zKGvQmN4/xyIKO47KUMzOZlfAezhnhwm0qyDHhdRquTOULuvRIGpvlNWDDjuW7m44ip8aF8pdsCZjnw6A0d99JYMqSAHjUiWJF7pBz3x67pBRRgfy1lwlr7sw3zqgKKbgjNmGTdLpStLxSyqVbjKHQrmMWZOdjfESlpCc+fTWHKByVUgJ6gkdhnV4PqYIDbzvzd12SwSN+13jzPcILKfMdYqxM9Ptg2RrsXiY7SRsIQRnGIpryDE9EWQagupK6hQaK1Y6xQJpw/Cu9qFn/j0ameknF8h262fsJEdk6wdDj+Z6halF5UieaW14pTCSPypNlukCu6/hZ1ylnY9mag 3MBRLMsO RajRfRs37LK7Pgc2DMrNbEFlzEsjgC+qh5DPtjeiJNQDaox6xNN//K8rseICvBp9CpyUlseyT15OHPK+eGapcHq1SOiP0vWnNaPPg9/5jGNivp1BsmL0Dt/EhYyn0bJjgMXTOBTrmCNibPXvje59H71DORHwqhrtFf+nr/IQudwaod/+7BdypcPrBErAhU2vQBwkKZjWTw6azpk/npwk/+E9nozUlI4RoBXabQt/XqP8DFuac7fHjvSHipWs52YsnXDSs0sMUDsNpnQBbYZLhHHgZsaPIF71ZYJOJXMBQH9zYHXnLpY/sPGo1J2ubeRFXeiBUTP2VHN0s47WSQX74kyoftcEDCzgaStXibnpceYVkxpuJIaBYZRPlrQ4wTYU4fHt71DsMirfKBtOXZ6hK6r7+F21+BcLjUgaBkuvDQYovVBH15sH/RGFrul5rUmaxxYfa9+Ovqz0Gs5Pi+ReZ9g80jLYo81gra+O2IPygDcCRkZwlU3CZvdmaQG/OPC+lW3XZmuo8yLnJHyF17TIeNzlwV7GN2PWoCzSfGyYuZIyfLfs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,kv3-1-apic-gic` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau > --- All the comments apply here and to all your other patches - wrong subject, missing blank lines, missing additionalProperties, missing tests (patches were for sure not tested as you can see from bot's answers) etc. Really, please start from scratch on example-schema. > > Notes: > V1 -> V2: new patch > > .../kalray,kv3-1-apic-gic.yaml | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml > new file mode 100644 > index 000000000000..7a37f19db2fb > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-apic-gic.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-apic-gic# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray kv3-1 APIC-GIC > + > +description: | > + Each cluster in the Coolidge SoC includes an Advanced Programmable Interrupt > + Controller (APIC) which is split in two part: > + - a Generic Interrupt Controller (referred as APIC-GIC) > + - a Mailbox Controller (referred as APIC-Mailbox) > + The APIC-GIC acts as an intermediary interrupt controller, muxing/routing > + incoming interrupts to output interrupts connected to kvx cores interrupts lines. > + The 139 possible input interrupt lines are organized as follow: > + - 128 from the mailbox controller (one it per mailboxes) > + - 1 from the NoC router > + - 5 from IOMMUs > + - 1 from L2 cache DMA job FIFO > + - 1 from cluster watchdog > + - 2 for SECC, DECC > + - 1 from Data NoC > + The 72 possible output interrupt lines: > + - 68 : 4 interrupts per cores (17 cores) > + - 1 for L2 cache controller > + - 3 extra that are for padding > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +properties: > + compatible: > + const: kalray,kv3-1-apic-gic Missing reg > + "#interrupt-cells": > + const: 1 > + description: > + The IRQ number. > + interrupt-controller: true > + interrupt-parent: true Drop, should not be needed. > + interrupts: > + maxItems: 4 > + description: | > + Specifies the interrupt line(s) in the interrupt-parent controller node; > + valid values depend on the type of parent interrupt controller > + > +required: > + - compatible > + - reg > + - "#interrupt-cells" > + - interrupt-controller > + - interrupt-parent > + - interrupts > + > +examples: > + - | > + apic_gic: interrupt-controller@a20000 { > + compatible = "kalray,kv3-1-apic-gic"; > + reg = <0 0xa20000 0 0x12000>; > + #interrupt-cells = <1>; > + interrupt-controller; > + interrupt-parent = <&intc>; > + interrups = <4 5 6 7>; > + }; > + > +... Best regards, Krzysztof