From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 973B7C83F1A for ; Fri, 11 Jul 2025 10:49:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C0CD6B00A0; Fri, 11 Jul 2025 06:49:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 398406B00A1; Fri, 11 Jul 2025 06:49:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 287A16B00A2; Fri, 11 Jul 2025 06:49:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17E646B00A0 for ; Fri, 11 Jul 2025 06:49:33 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DD5811604E2 for ; Fri, 11 Jul 2025 10:49:32 +0000 (UTC) X-FDA: 83651662584.27.8A3DEF6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 6F3F2120009 for ; Fri, 11 Jul 2025 10:49:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=geKFCZZv; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752230970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E8FdYOVeS0rJgUvHx0cKvojaQnDNsgbZopVnLDtjnZ8=; b=DolXEOVsbzVKHaDoNYtelobw5KOnL9vYv2ber/PwxTBja5BFvscVu98SPWIz/TI5bXI5kY 0EAAhTsWdRB5Ln6mawAftpJv/1QSSuc33K6lJwgBK6TzjugMzBEeU3/sgbFNUTf8huqvQL dnxacWR1McFmgj/3cpE5Q0DpLI8Un48= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=geKFCZZv; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752230970; a=rsa-sha256; cv=none; b=feLycYYwiybZG9suzaS4EfdexJvGHnP8mlXlbe0443PuckmlmAC7ucEiIVqcB3OfKxaXR8 WY1BEIz82biIAZlndH1vM8kn+W5p/mwuDbwYF7Mjz/kmhN7Q6w1dSmqTDI4IHE2VTWkfVn NeBQ8oWBsbAYxEDTUYDyHar3yb6o4tk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752230969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=E8FdYOVeS0rJgUvHx0cKvojaQnDNsgbZopVnLDtjnZ8=; b=geKFCZZv7webHZo4lFnGo9GzT6D2tHRgITs4QNg4VRbrGlfW9poLzmaR3zIaA3ao5zEfHE q5gV5QfIhFNr6NEauR7VPP+Uy2ZRzPvx4wdZV7lzWpM+bNwmN16Zc1Dpgw4OSaOW80ThZJ Mxg1skdR6CHHG9i7P0ZabExUaYAs4AY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-SEElo5v2NYu3SKnzAsK9bQ-1; Fri, 11 Jul 2025 06:49:28 -0400 X-MC-Unique: SEElo5v2NYu3SKnzAsK9bQ-1 X-Mimecast-MFC-AGG-ID: SEElo5v2NYu3SKnzAsK9bQ_1752230967 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d7de4ae3so11681445e9.2 for ; Fri, 11 Jul 2025 03:49:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752230967; x=1752835767; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=E8FdYOVeS0rJgUvHx0cKvojaQnDNsgbZopVnLDtjnZ8=; b=N8UyzVLMMKLoz1a+5/5lz1Jnos9OYKNsvdw892OA42UlS3QKqIcrQKuSO6yLCSsI0g 4dRa6veb9cKiWXxtqMRybx+3BUAtMKEeeCRDSaQqsDQHj56Ykeqe1Rxxp0BGEn9GxUKx lQuj/WX2IFGvxpvnR7/HWGPXNxrr5lbstzELhcAEA+ZINaPkIQ/CgnXq7q1eflh6glBh Mc9T15bd+3qNOAl7RLzgmzyhW9zTjfSHIjp4EqBNT9+pVvZMKAeo6tUOLc7dezBCshr8 A3FiH9Dy2rbdJrvv3VaWrgorzHFFrPqXgqEAVlKH+jHRcGhS4VhzUR13nJL5Q//JHo3X giTQ== X-Forwarded-Encrypted: i=1; AJvYcCX8/zPaCJLSBBkUUuV7K1oiMDLSQbqV3sjB/zda5CHQZjE6v1AdJ5i/dyU1xCLnWStha4EnYoSm5A==@kvack.org X-Gm-Message-State: AOJu0YzfJzhluNXzcwqVNge1NTAZ6wLUlw0F0FPd9zORXrxEgI+EDLeU O9GIgi1gZNt+3k2MNP3APF6K67ATosKCvsgVWA6IZkrQxJYhhXUVVDxWrcUNQ867OCFF7KkCc80 7VG9pLh93epz1DmvbygeZdtakoA+iDyQW6IDF9OeEFMv6JyBSOaHj X-Gm-Gg: ASbGncsuoCv1xNWYhJ8Aa4sIIU7NHVMxrqbRGJAfYSB3YvxtVA6ZK+9Y3IUsQAK/EUM QfQ41kwNMwSuRkUCrs9TUta5iHMxuicff+Emq/HiZTmvRtU2JBv/Dm69TpET++lT4ThTuUsZmie Ho+c7kAYdsdAZgViko4WhWu3c0iBfSdh39Ju6nYETr6cLA4HYSvONiz9AoXW2Py7ggfxlfKGIDw AQGdm8cIWNZH7zCR/YuxKP6u5HtKz9+qYMJfNFaPrKs//oEy2BKWXqhTZSuynEH3wgTiNnT9tNM ULf3tD+FcG1DqSOGRf4FjmDQ3hwqXbr7vz+ayusRPUV7UYLwXjqRzTffGGB8sTUK8zw6R00I0NS 4djUqFcGeqXB89X2KCBNFjLFG6EB6WnU9B6R8Bya74NfTSJABCmmTpX08MbwfsBP2JCw= X-Received: by 2002:a05:600c:1c1f:b0:440:9b1a:cd78 with SMTP id 5b1f17b1804b1-454ec16a5b1mr28065515e9.10.1752230967215; Fri, 11 Jul 2025 03:49:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbt8UKpPwWDvR0+0kCm2Qz0XraVSE2GNazJDrmfX1Q7I8cEerDfFZIkIEln2jL8dMShvm5Pw== X-Received: by 2002:a05:600c:1c1f:b0:440:9b1a:cd78 with SMTP id 5b1f17b1804b1-454ec16a5b1mr28065205e9.10.1752230966785; Fri, 11 Jul 2025 03:49:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3c:3a00:5662:26b3:3e5d:438e? (p200300d82f3c3a00566226b33e5d438e.dip0.t-ipconnect.de. [2003:d8:2f3c:3a00:5662:26b3:3e5d:438e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454dd538b63sm43791545e9.19.2025.07.11.03.49.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 03:49:26 -0700 (PDT) Message-ID: Date: Fri, 11 Jul 2025 12:49:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/memory.c: Use folios in __copy_remote_vm_str() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Jordan Rome , Andrew Morton References: <20250709194017.927978-3-vishal.moola@gmail.com> <20250709194017.927978-4-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250709194017.927978-4-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BnFyNLfxpQ_qPhxlvx476VA2dcnlelCijkEoU8uItR0_1752230967 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 8deha5r5z1mskdfaew36gmqp3oisjwg3 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6F3F2120009 X-HE-Tag: 1752230970-483884 X-HE-Meta: U2FsdGVkX18h4FpWgptKVHB30QrxhXHw74KqrM2EBvGg5EJvTHNY1Jcw+s/XBw4OhaPsShhTTKv5TSOVk64PI1WolIX/vTG2nNdbBaOhWhwjtjiVBISZ8nJKKeCPq5PDBAxZbhhot2PRPXZj7LQghanNcSSpBWYc6DNYaasj4JlqzLtzxVrzLxmThCVlSx51OagSzBrtCr2u5mNfM4IYj49H8742Bl9+DvvWcS7hy6RckPOb/bzOkv5YosrFUcraWec2i8mWAzY/SEjnEttpsmIz1MoA4awr63RxKbNdGTJo7QA5rwj5b4C1QAGoyjLQUPwkJChvSRxq57L+sy5VEn9AApguDKMz4uG0y7QGxeVSsBvGukJPV9kvx8LCem1BxZ9DH253FG1wvXSmSi2wlb9DWC0ukKYNZMxbFA/xreHGq527/TrcGV2Hv9RGTWCe25Af1K8+c+dh2ZC7FPr4hf+L9FEhcg0J/eFNAk9meDLUIdSFQt8wZG2+Lw1ZZv7JfTmOyZe8DkILKZMMK9j55N/8UwqW+K7vpJT1coSNseu9NtBTgrQ6Dfyo9Gp0zHV1zUkukDa3cZz2CSaK+7I+9DtDZQpI4AW3bSOsK7G/h3K8Uq4mZNFQcP3db5ZqVKtSFSBjgOQ5Buvk9V95Xwxv0gTyfq9R0+LIuU8/bV+68sOSQzCADI9mB8+hZ7RYUPKTGhZPVJCFWGbhgE+hqP5ZKGFZB7InsTTaBifzg+U1CdQ8M5Qky/0qW9KJl0erP+KpJ+E0GKprwRfmU100Z+Un64Y8qRn97NpbyrFR4fMp1jfmTOn1pKr1FTTMUszQIbOciYnzGKO8e5eAfan/uN4yBLrrFXfwycNfUS2qfqPgnYjPf8Wi9keS4gIOE7oCHHxeKUR+4mSXbFrnXaYTGSe8UmZ+kKuNauD+aU1SiCEqUESUlyODlHxd89L1qo3EVruyysSfmNvV6kcYDOEanpk EmPKWKdZ FIjw1s0QCH+arO0Rtxc+ERgYYzfYiywalyDFEWujoLNOPhYh7hYmiyj8E3immOE1/mkXMdOwKPCKZdJs96/end6Cih26MHIp1j30ZqI6c+VQWh/Y0hiqYCEiLSdqqzIytWFQwUOz2fP3g4Q843LZAZiQ9PDmhf1hyHrcg8rN/SMlMpFnydQ82dQqgsrW4b0vA9YVdKkhqgHPHQHeLWVRSfRowOxH0LpzED/hiZKt5Sw9nErxjRXNSDnyTk68pWI6fA9XeG7QLYI4COHQhVB2DgEdE/xDOGumezUL16IxF8AFbQHOoHZUXEjFmOFdL5LneAzt8/sweoKhlAtStD7DNS47fO+njBTKpeheWfwZI4CkW9hEO/axqNMBMPZa/JuPJCaMF1wiDKHe3KeMig9l1cAaxB+UlRpVy70ZVPSPFfvgqky7x9q92fFAnejQ1Yrq3jO9Q9SploZprcCsiCTWIMqOZifGrcG86psN2hRr/CH5LJ0f8B4b/VipgEJTN2oH9FnZe6NYkBoIZrJ7VjXSVm92tdAuxnlPY5gXr+5GGhQ6GhxkdA5PEgxwu9EMsDKnlnGZ4swNp1dbKs9YODyBpz53V0p+4GI+KsQJ5WtevnVXxWiva9qDgRZoZUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.07.25 21:40, Vishal Moola (Oracle) wrote: > Use kmap_local_folio() instead of kmap_local_page(). > Replaces 2 calls to compound_head() from unmap_and_put_page() with one. > > This prepares us for the removal of unmap_and_put_page(). > > Signed-off-by: Vishal Moola (Oracle) > --- > mm/memory.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 1174f3001307..d63f0d5abcc9 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6815,6 +6815,7 @@ static int __copy_remote_vm_str(struct mm_struct *mm, unsigned long addr, > while (len) { > int bytes, offset, retval; > void *maddr; > + struct folio *folio; > struct page *page; > struct vm_area_struct *vma = NULL; > > @@ -6830,17 +6831,18 @@ static int __copy_remote_vm_str(struct mm_struct *mm, unsigned long addr, > goto out; > } > > + folio = page_folio(page); > bytes = len; > offset = addr & (PAGE_SIZE - 1); > if (bytes > PAGE_SIZE - offset) > bytes = PAGE_SIZE - offset; > > - maddr = kmap_local_page(page); > + maddr = kmap_local_folio(folio, folio_page_idx(folio, page) * PAGE_SIZE); It's weird to go page -> folio -> page ... but maybe that's just the way it's supposed to work here ... :) Acked-by: David Hildenbrand -- Cheers, David / dhildenb