From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8713CD1284 for ; Thu, 4 Apr 2024 07:48:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E13D6B0082; Thu, 4 Apr 2024 03:48:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56AAA6B0083; Thu, 4 Apr 2024 03:48:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40ADB6B0087; Thu, 4 Apr 2024 03:48:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1DD396B0082 for ; Thu, 4 Apr 2024 03:48:28 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9F3F4160EB2 for ; Thu, 4 Apr 2024 07:48:27 +0000 (UTC) X-FDA: 81971071854.06.4AC6C83 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by imf06.hostedemail.com (Postfix) with ESMTP id B5659180007 for ; Thu, 4 Apr 2024 07:48:25 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.200 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712216906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JcSUJTkxP5dCs7blBEZ5y1zqGy5xZCeSoSGbDl4Kfwo=; b=4Op5N6T3nf41grxFayNQEYz1z8FHabcuWg3uX74IegrYG9xAmtK8xMyj1+2EVBuG9LjM1q apmeod9gns5PyEM67mQjyiGiuT+JS94eIyUaV9sNOVJg+IFWRC+5WuDf0lwvLWHZtJ3xJt DDx5vqknnBJ4k8G1rJ9dCwzh3nJNzDc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712216906; a=rsa-sha256; cv=none; b=fkAXPEPF7FFxgB4se4cspRyAseswn3VWh84ZSnYFyGQnX6nwcfyth6jejNTmMLyrLg6E7P cFcnE2M3aV01zvJU3HR7xKR75++z/zBImvffzX/Uh8c6IuCumnQJpvMs54X7LAr8bxtEt3 tiKMSMn73szix7jBXEgLHAnBuZB2cyk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.200 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none Received: by mail.gandi.net (Postfix) with ESMTPSA id C811E20002; Thu, 4 Apr 2024 07:48:18 +0000 (UTC) Message-ID: Date: Thu, 4 Apr 2024 09:48:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 02/13] riscv: Factor out page table TLB synchronization Content-Language: en-US To: Samuel Holland , Palmer Dabbelt , linux-riscv@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexandre Ghiti , Jisheng Zhang , Yunhui Cui References: <20240327045035.368512-1-samuel.holland@sifive.com> <20240327045035.368512-3-samuel.holland@sifive.com> From: Alexandre Ghiti In-Reply-To: <20240327045035.368512-3-samuel.holland@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Rspamd-Queue-Id: B5659180007 X-Rspam-User: X-Stat-Signature: txki6sjoyu4ygth4htwjqa58xei5foqp X-Rspamd-Server: rspam03 X-HE-Tag: 1712216905-388466 X-HE-Meta: U2FsdGVkX19id24RAhVICd4+MbHGGHD7E9A2TS/DkaSfeF5fz9HnZnB8DA3tvkb2l4qjs4ibs16Eyry10mGzDhOB4n6A76iIhLJg9CROa4rhDjNuiSuQOdP8baffezqWVyxIcf1KOPEs5VNgkGIkdt1Pn4PPCKmDxpT/dot7+O/emHbSAsb9HkC6KDGlUTEOY52A3E+Uwv8CQqibiUNuGjBpjxXCBA7ZkPqmagTzxnFgLePRrz//Zomu/I6QhzqIvfnmTA7I+6Rqkd7MP4Ja0VddWcWYyYyAbImc/Hc3l5X0ovbxst9QhvZSwJQSh+apvQdWiy3MK0ey4CrqfSeUpY1Pxhp2pzdLjU8+BfjitZovSEVzwQSox//+qFm695518V5V+/VAscxdOEqm2hoM5H7StVYhJTuzQ5vJSGjb7N4jH5mAEXJomSTNlFwSijD98DHpl5Ki2XKHmIsUextdcRn5+1c6UT8y4CC7a3kEhcGykbLhvXVIaM5y7RhaXIgeBfZVQs2FRLWq7tilWDiYw8xW8O7h/8s9k4PS0eA5k9xo/zSAI4RmHmQgqpVqMzyIEUg9z0AgBNiejez/0hjVpnwgXrdw0GEAzh5UccBs2zAhrQwR9B2o0AIzrwkqV+8XYnhtIgGO/pIfARnM/OvbPrPJowq5pR+aA6zAymGZh7inzBHrm0WvyxN3zzKA/yG6PIB9Fgu04Qhvyob24YhS0Xe3XDxzBElEFrFs39pluXQWZbn+6Oz8JrptMTYHRb3yr3U7bsp88HM7rv4vQ8H4P1msk7WzAfue61Kr19WHtZXginaD7mnpFJ2yFGgrIs9m6N5SjNIfkHw15f1CNUxqgmtpnBE9FvSL5Pp7ISPw08EeK0xJZVVpNQEAnpqFWH4TEve2lpxc6ToKHMJAFI1HAq7fR+OBGBq/zDlm2vt02EEE8a3Zm2XINUK4v3SAOrOpolgzu/FF3lk5qEKUyO4 VJs25AF5 zb+GCjF28U6AeaCapjhCTHFWRZ+auXdu/B57obKwWdDtM7ic/vK6dVF2c2cr9oFyUZVi7rMfJb92rMBJGL4SOsjvxOqt5/npteVag539BQoFBbvk7pu6ZiEFSdkY5ojpHzEpEh7mtblaACzAJN51jqxfVu315LeiXIuDrcPIKj78jNEqCUg2xb7WF++C8C6qjNwtB/TSRN+mHxy8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27/03/2024 05:49, Samuel Holland wrote: > The logic is the same for all page table levels. See commit 69be3fb111e7 > ("riscv: enable MMU_GATHER_RCU_TABLE_FREE for SMP && MMU"). > > Signed-off-by: Samuel Holland > --- > > Changes in v6: > - Move riscv_tlb_remove_ptdesc() definition to fix 32-bit build > > Changes in v5: > - New patch for v5 > > arch/riscv/include/asm/pgalloc.h | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > index deaf971253a2..b34587da8882 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -15,6 +15,14 @@ > #define __HAVE_ARCH_PUD_FREE > #include > > +static inline void riscv_tlb_remove_ptdesc(struct mmu_gather *tlb, void *pt) > +{ > + if (riscv_use_ipi_for_rfence()) > + tlb_remove_page_ptdesc(tlb, pt); > + else > + tlb_remove_ptdesc(tlb, pt); > +} > + > static inline void pmd_populate_kernel(struct mm_struct *mm, > pmd_t *pmd, pte_t *pte) > { > @@ -102,10 +110,7 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > struct ptdesc *ptdesc = virt_to_ptdesc(pud); > > pagetable_pud_dtor(ptdesc); > - if (riscv_use_ipi_for_rfence()) > - tlb_remove_page_ptdesc(tlb, ptdesc); > - else > - tlb_remove_ptdesc(tlb, ptdesc); > + riscv_tlb_remove_ptdesc(tlb, ptdesc); > } > } > > @@ -139,12 +144,8 @@ static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) > static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > unsigned long addr) > { > - if (pgtable_l5_enabled) { > - if (riscv_use_ipi_for_rfence()) > - tlb_remove_page_ptdesc(tlb, virt_to_ptdesc(p4d)); > - else > - tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); > - } > + if (pgtable_l5_enabled) > + riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); > } > #endif /* __PAGETABLE_PMD_FOLDED */ > > @@ -176,10 +177,7 @@ static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, > struct ptdesc *ptdesc = virt_to_ptdesc(pmd); > > pagetable_pmd_dtor(ptdesc); > - if (riscv_use_ipi_for_rfence()) > - tlb_remove_page_ptdesc(tlb, ptdesc); > - else > - tlb_remove_ptdesc(tlb, ptdesc); > + riscv_tlb_remove_ptdesc(tlb, ptdesc); > } > > #endif /* __PAGETABLE_PMD_FOLDED */ > @@ -190,10 +188,7 @@ static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, > struct ptdesc *ptdesc = page_ptdesc(pte); > > pagetable_pte_dtor(ptdesc); > - if (riscv_use_ipi_for_rfence()) > - tlb_remove_page_ptdesc(tlb, ptdesc); > - else > - tlb_remove_ptdesc(tlb, ptdesc); > + riscv_tlb_remove_ptdesc(tlb, ptdesc); > } > #endif /* CONFIG_MMU */ > Reviewed-by: Alexandre Ghiti