From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA17C433EF for ; Fri, 8 Oct 2021 21:27:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 584FF60F4B for ; Fri, 8 Oct 2021 21:27:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 584FF60F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C1E9B6B0071; Fri, 8 Oct 2021 17:27:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCDDD6B0072; Fri, 8 Oct 2021 17:27:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6EF76B0073; Fri, 8 Oct 2021 17:27:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 93F3A6B0071 for ; Fri, 8 Oct 2021 17:27:06 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 266AC18432CD6 for ; Fri, 8 Oct 2021 21:27:06 +0000 (UTC) X-FDA: 78674555652.23.120B5F9 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf23.hostedemail.com (Postfix) with ESMTP id A2C7090018C5 for ; Fri, 8 Oct 2021 21:27:05 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 198LQVQ8007651; Fri, 8 Oct 2021 21:26:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=Y27vKUArL10ktf9Ef1TWcEOgRoVp847aZlrnfNEmNvc=; b=c0oNhkZE1YLBb0e2lWNi86Y0Jrxf+5c3CFvrBlq3vHYMNSgRTdzSK09GNO/04pUGSW+E L0wdgRw1xnpbwG3AYk5iRqtCELvVUzB71EfLlkA1PLxLtwOLHXReiggIpVgv3RuvnlDh 4Kuc95HIClotc0loW56HrYIsChwPODP6uG29yzsT1HYchub2sxE39HfPPLBP01NYygoT dB9KdU2wWaN41cdrMC52LIfTXijkeh71Scs/MkzZ3hRDtXCiopI4+oauic84Uy+pUt4v GaHRnx1rSdS+NvJXymL2hm/Aabgc4FpK3sNc9vwyYXyNCRxXQOPZVld8nZbXRmnKvshS JA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3bj0pwan8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Oct 2021 21:26:53 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 198LGCoq159877; Fri, 8 Oct 2021 21:26:53 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by aserp3030.oracle.com with ESMTP id 3bev7yj3dg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Oct 2021 21:26:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g+uwmQVx3w5N61wFfGusqdu87QgNY8zErWoB4FZJAyOHqtavGzrY4U9uFnBjmUvDq5dqLnpXwKEdShebun4MIC84RPTRTqrXRyPQ7Hu90tLpTYG6xlD0Tucb1Q/wo7j1grp0nG+cJcq2tcZb6Ne9fETqIi/OfBuO5xtbxXHr/6GjYhPQUMWD0uNLbsGc8QM+M1fuvOzA8honVZegOGISHV3CN9wst9JmGPWox6Yf59+HKun79Et2BZi8nOBRcWXyF29ql+QY99cHw0X+L+9nJGSxnpC0EhsyOmSFuZwQRJBI/zIIxISb9hjSN+02GTEqZpciy8zcrDuvM0x/IS5/XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y27vKUArL10ktf9Ef1TWcEOgRoVp847aZlrnfNEmNvc=; b=Q2mACQUt8Pv9rIZ53e7f1+xz5Q7AkZPfqP60WcCxHFnMZtY2/7uTHFf/8z4kLN4aAgfEagUPJQ0DLTo0e2/2NUDbUbF8HlVGCFxgJ+y3S66A7VkHPsYXBwL4XZCTVdEV33swLGDUoh54z/yNKs6rc7OPOIgy6E4ke3MoLURG8jN6tyiaC4YiWnRx/9PIX87q9c2WYLacQq/ZJCDJA75+T0jwPoOrvQdSQU1OUElFnVL1elF5rwHRvAAtwTwG+cGCR/3vXG6ez8hHq/aTL703s7GN9y6w/6swKjmYFRp8/s99j3onmChCqNSyVcn6g0RiihTZI0XPxYCrlbSv8RqwEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y27vKUArL10ktf9Ef1TWcEOgRoVp847aZlrnfNEmNvc=; b=mc7jfDJ4TbTVAL5wAMlNhpcRhLRYZ/lh2VxoStG0aTye/zaukXAIasdyjVs9EnLFwVx8bCbFaaoTfy1NDSkWCFviuEn6AkAtwzITSOlZeMjGkR8F/Ic9N2CeChGnjeBJlZmmKN/5CmZctZilIr7bzat6b+oc7EuRPejr+8rH+pI= Received: from CH2PR10MB4200.namprd10.prod.outlook.com (2603:10b6:610:a5::9) by CH0PR10MB4859.namprd10.prod.outlook.com (2603:10b6:610:da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 8 Oct 2021 21:26:51 +0000 Received: from CH2PR10MB4200.namprd10.prod.outlook.com ([fe80::acc0:d361:da0:dfe7]) by CH2PR10MB4200.namprd10.prod.outlook.com ([fe80::acc0:d361:da0:dfe7%3]) with mapi id 15.20.4587.024; Fri, 8 Oct 2021 21:26:51 +0000 Subject: Re: [PATCH RESEND v2] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB To: zhangyiru , akpm@linux-foundation.org Cc: linux-mm@kvack.org, mhocko@suse.com, wuxu.wu@huawei.com, liusirui@huawei.com, liuzixian4@huawei.com References: <20211008195725.33083-1-zhangyiru3@huawei.com> From: Mike Kravetz Message-ID: Date: Fri, 8 Oct 2021 14:26:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: <20211008195725.33083-1-zhangyiru3@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR03CA0009.namprd03.prod.outlook.com (2603:10b6:300:117::19) To CH2PR10MB4200.namprd10.prod.outlook.com (2603:10b6:610:a5::9) MIME-Version: 1.0 Received: from [192.168.2.123] (50.38.35.18) by MWHPR03CA0009.namprd03.prod.outlook.com (2603:10b6:300:117::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19 via Frontend Transport; Fri, 8 Oct 2021 21:26:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 82e86dbd-f14a-49a4-d5ac-08d98aa257a8 X-MS-TrafficTypeDiagnostic: CH0PR10MB4859: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:18; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2MF/9INteW15ZRFDJRTlVUKZ/c5CxS89jJho3Zc5s30gO1CG4TN7ON+rm0OBvrsyUDQkN+g/+FHO3LGJrVqa+PMshuS5Zt5QcMq3gL8Vwhp4lut2TlP+kPhgHLAWybrhC7V+CNJ3VhboPrhGTNh2W9mmQEnQvKQToI9iwzK7C393WVzbCYGUXIRAqECOLsD1Oc9ZuxqUZ+GJMZQ318ZDFlX2ITLaaMz3xAXQq2dcUINBk4SvpLZA3Ys2//+RGVhzyEY1DxQXluVfX3YQJv+v8rUc4q9VVgbWtzGfthirfIJhx+sW1logdRonADONhok3DMOZIK51OROrnNbU/AwNTBV9OJpooMScPjuwlqzDoSs4yhiEfDFHU1vsZbO+FEt9SQwnR+Ye0NOpbRFFrtv7cJSdL3Way02cDttcOUsN35npFJC6+IaDnBignu8UFJmKiK+wpmnsj4gEbxWLMnzd8hGTifQL/a5Xn2yyGR72W+G8Avf6AtNPMFhy+PYGjZKVxBsZp3u0dxb/DXGHcSLNflLilKGkEh0JSgVLReoBUFsT7o57bzdDEl/+83MORQMr9++7GfZNhWAYVJoIR12rgFON44mkye8V9nARbK4xFnnUtPTJMd7stZRuaPLunx/PwtQlhzG3zl/3E4DRyD28uMzkQNg3LfJVzSzFVgbrVHOVg1uX32CKhixCic6x1SQBN5emWEvYFJenYSDlmi4zq8+X3jr01twjpQcrLj2WJ0ofObHoNTlzu5DyljSoid+gTHfA6Oyh1LG/vyxydL2wUA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4200.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(8936002)(2906002)(53546011)(186003)(26005)(508600001)(31696002)(86362001)(4326008)(8676002)(36756003)(66946007)(2616005)(31686004)(66476007)(316002)(83380400001)(66556008)(956004)(52116002)(44832011)(38350700002)(16576012)(38100700002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVlZOUFRZ0dOdGpQM1VmcGI4Q3VESWRMNW12SzlkamUzc05kTFpMQ2swcjFr?= =?utf-8?B?dU13UHUraUFxRlJXc2NHRHV0bVlkTDE1RDF3SWYwU1kwT3hra241ZlY0U25o?= =?utf-8?B?SG0wMGtYT08xSG1zRFBISnJ5UExnYXh3UTkzSWU0M0YrOHpTRmNCbkhEWGdk?= =?utf-8?B?RWxqdkpwOGQvODczS2ZvRm1zR0RQZ0ZpbXVuKzJ5SUFvRWdMZjRFZ05UY1JH?= =?utf-8?B?a1BNRVM5emlDbUdwd2N4ZVdLQnZLUWsrT0ptcDBtYTF0VDVwUVVQdVlyQjQw?= =?utf-8?B?ay8zN3VianRaRzdqdTFpOTMwZDJBV3RZZlhicWlVcVYrUFpzcUNkL205LytQ?= =?utf-8?B?L0ZvSVNtajJlak5hRldrbVYvMWJ0WU1kRmpQSGlrc1QrR2dyMURSTUR5MWU4?= =?utf-8?B?L0YxOGc1c2hvUlJaTXhiYlMyVUhsbFc1Q1J2ZUd2RkVtTGhwQTgzc1RnVVFr?= =?utf-8?B?ZGViQXZxOW1rbFp1WGJQWCtmUWdOYlk0UEw4UTlsR2xJYVdGWUJkR1N1UFNY?= =?utf-8?B?b3QzakpBRVpNU0VZbWpETG1hWTUxQkdDUEFrRlBqQjZnMHI3ak5xb3VJZnlO?= =?utf-8?B?RTBHdS9IQ2JtenEzVmFhRHpmV3ZYTWd0ZVBCQmhXU0FZSHJrRE1oUllDUWU5?= =?utf-8?B?NVdaYnZrZVhFbktueU04NTAvM2RwanJMaWlGMlVaNnhKY0kvZll2QlNtdzhq?= =?utf-8?B?NlZZd3huNCtqMnVJWTA0NTdsbU82aGljTnN3TlJnTDJGTllZWEZxUHY5V1Ny?= =?utf-8?B?OGV5eTBETnhpN3g5bVZxU2phR0xsTFd1cjFnWm82cnE1Q2tnM0srUHFEMWIw?= =?utf-8?B?aFJLL3JLK1hqNCs4Y2lENW4vQ0IwbWRCcHdNVHZNOVk1MTFsSVJKbkhkWDN4?= =?utf-8?B?cEdNMGpzNms0RGV6aUU0ZDVSMjNyOFJiallLd1QyeU1TdCtieTNzMVJJVVgw?= =?utf-8?B?amRkNzZPUGUwMzhwM0FyT3BIUmo1WkllWE91L0JkaEc4QzZJb2MxUzgrRlZJ?= =?utf-8?B?Ykh6TlhwdFNEMFluUFJCdWVpVHNvcFNISkowOHhST2oxS0pqTWdJRVdtcm1X?= =?utf-8?B?UXdwandYYWwwN3V0TWZpdWUwcURKUlhtMXphS1pVdnNHRll2cXJ2Q3U0WHdu?= =?utf-8?B?S2NGazRjUmVZYWpHNXR3QzBtbXhhNFpGa1lmWjdMMWJYaSs1MUhXaGxjWith?= =?utf-8?B?OUZuWjZhbGdmQVpmaGpGalB6Tlg3U1VVYjFjaVJZUG5ZNk9XYU93REdGR3I1?= =?utf-8?B?bjl4TGhKa3p2Tzg5NDAvSHJLajhYVEUxeUowendwdzZmcnJKZ3RZNlNNMk5V?= =?utf-8?B?VmNPdzJuWEtZQ29YWjlwQ0VnVWRkbzRNS3ZqNjAwOVVtNzU0blhIeGVHd1NV?= =?utf-8?B?ckpCZzVybytlTlRIWlBpZ1VOc0J2R2ZEQmtnNUVFWVlGRnJpbUJjdlhjZVBI?= =?utf-8?B?QndkMkkrUlJudTZZRnN3bjhLZmV0ZEUwSmFDeFp3cTRDMXptc1QzbGx0NmEy?= =?utf-8?B?bFJOaVlkNk5wQi9wOEJxN1NuS3ZiVjFMRXRITDBsQXhBVlFzci9reUU1WWFM?= =?utf-8?B?dFJRajgwZHd5RnZRYWlLeU4ra2pIcXhRYmdHa3hZdDhQUWd2TXNyb1c4NWEv?= =?utf-8?B?ZmNkbzE0aExQRzdKQ0RtMzJhMTdNQ0E2WWl4Z1VMbzZ5dHB5WjdKWkVGRURP?= =?utf-8?B?TENQRWhKSFVKRkk1VG8vUFJrY3p0bWZRZHVycncwbzBQQUp2c2NiTGpJRVlX?= =?utf-8?Q?8jyJ5pYTgEshbCmLyXD+z1TdkyoBO/UJgb7xOH+?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82e86dbd-f14a-49a4-d5ac-08d98aa257a8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4200.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2021 21:26:51.1107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rbns12lGAGaPpXGQIAW9HrT8jWSHkhoazAP2IrPmMj/Ldk02BUdTJtOAqSPb2j8LtawMRgEyNPCdG+zw9Jhlfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4859 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10131 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110080116 X-Proofpoint-ORIG-GUID: WGNvhvznD637fOy7iStxJYFEIiyE7CV- X-Proofpoint-GUID: WGNvhvznD637fOy7iStxJYFEIiyE7CV- X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A2C7090018C5 X-Stat-Signature: g5tgozo5517wxiuc9fmnb9tiqy58n7w3 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=c0oNhkZE; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=mc7jfDJ4; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf23.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com X-HE-Tag: 1633728425-4747 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/8/21 12:57 PM, zhangyiru wrote: > commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to > SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012, > but it is not deleted yet. > > Mike says he still see that message in log files on occasion, > so maybe we should preserve this warning. > > Signed-off-by: zhangyiru > --- > Changelog: > v2: preserve warning message > v1: remove mlock ulimit for SHM_HUGETLB > --- > fs/hugetlbfs/inode.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index cdfb1ae78a3f..877d0ce9526c 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1470,10 +1470,9 @@ struct file *hugetlb_file_setup(const char *name, size_t size, > pr_warn_once("%s (%d): Using mlock ulimits for SHM_HUGETLB is deprecated\n", > current->comm, current->pid); > task_unlock(current); > - } else { > - *ucounts = NULL; > - return ERR_PTR(-EPERM); > } > + *ucounts = NULL; > + return ERR_PTR(-EPERM); IIUC, deprecated means that use of the feature is discouraged but technically still available. With this patch, we use the term deprecated and also remove the functionality. Perhaps change the warning to be the following? pr_warn_once("%s (%d): Using mlock ulimits for SHM_HUGETLB is now obsolete\n", Leaving the 'deprecated' message and removing the functionality may confuse people if their application breaks after this patch. -- Mike Kravetz