From: "Lameter, Christopher" <cl@os.amperecomputing.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Julian Pidancet <julian.pidancet@oracle.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Rafael Aquini <aquini@redhat.com>
Subject: Re: [PATCH] mm/slub: disable slab merging in the default configuration
Date: Thu, 6 Jul 2023 11:27:06 -0700 (PDT) [thread overview]
Message-ID: <fa76dfe5-c9b8-d24b-89a7-2f906e2b1caa@os.amperecomputing.com> (raw)
In-Reply-To: <ZKbKcMehHbo+7cPU@infradead.org>
On Thu, 6 Jul 2023, Christoph Hellwig wrote:
> The slab merging has always been bothering me as it makes debugging
> things really hard. I agree with the other comments on improving
> the commit log, but with that:
Debugging is enabled by specifying "slub_debug" on the kernel command line
which disables merging and also enables checks so that data corruption
does trigger meaningful messages for debugging.
Without that you may see errors coming from the slab subsystem that are
due to data corruption by various subsystems. Without that it will be
difficult to properly attribute errors anyways.
prev parent reply other threads:[~2023-07-06 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 13:21 Julian Pidancet
2023-06-27 19:32 ` David Rientjes
2023-06-28 15:05 ` Julian Pidancet
2023-06-28 16:44 ` Roman Gushchin
2023-06-28 18:50 ` Lameter, Christopher
2023-06-29 7:21 ` Vlastimil Babka
2023-10-12 16:43 ` Kees Cook
2023-06-28 20:59 ` Kees Cook
2023-07-06 14:06 ` Christoph Hellwig
2023-07-06 18:27 ` Lameter, Christopher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa76dfe5-c9b8-d24b-89a7-2f906e2b1caa@os.amperecomputing.com \
--to=cl@os.amperecomputing.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=julian.pidancet@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox