linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Petr Spacek <pspacek@isc.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Vlastimil Babka <vbabka@suse.cz>,
	Liam Howlett <liam.howlett@oracle.com>
Subject: Re: [PATCH RFC] mm: mmap: Change DEFAULT_MAX_MAP_COUNT to INT_MAX
Date: Fri, 30 Aug 2024 17:24:10 +0200	[thread overview]
Message-ID: <fa76bdf0-81e4-4f7c-9dce-217ff8b464ee@redhat.com> (raw)
In-Reply-To: <90f07fec-3f46-4b38-86fd-07c9f8201904@lucifer.local>

On 30.08.24 13:41, Lorenzo Stoakes wrote:
> On Fri, Aug 30, 2024 at 11:56:36AM GMT, Petr Spacek wrote:
>> From: Petr Spacek <pspacek@isc.org>
>>
>> Raise default sysctl vm.max_map_count to INT_MAX, which effectively
>> disables the limit for all sane purposes. The sysctl is kept around in
>> case there is some use-case for this limit.
>>
>> The old default value of vm.max_map_count=65530 provided compatibility
>> with ELF format predating year 2000 and with binutils predating 2010. At
>> the same time the old default caused issues with applications deployed
>> in 2024.
>>
>> State since 2012: Linux 3.2.0 correctly generates coredump from a
>> process with 100 000 mmapped files. GDB 7.4.1, binutils 2.22 work with
>> this coredump fine and can actually read data from the mmaped addresses.
>>
>> Signed-off-by: Petr Spacek <pspacek@isc.org>
> 
> NACK.

Ageed, I could have sworn I NACKed a similar patch just months ago.

If you use that many memory mappings, you re doing something very, very 
wrong.

-- 
Cheers,

David / dhildenb



  parent reply	other threads:[~2024-08-30 15:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  9:56 Petr Spacek
2024-08-30 11:41 ` Lorenzo Stoakes
2024-08-30 12:01   ` Lorenzo Stoakes
2024-08-30 14:28     ` Petr Špaček
2024-08-30 15:04       ` Pedro Falcato
2024-08-30 17:00         ` Petr Špaček
2024-09-02 10:37           ` Petr Špaček
2024-09-02 11:05             ` Pedro Falcato
2024-08-30 15:24   ` David Hildenbrand [this message]
2024-08-30 16:48     ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa76bdf0-81e4-4f7c-9dce-217ff8b464ee@redhat.com \
    --to=david@redhat.com \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=pspacek@isc.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox