From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F74E65D18 for ; Fri, 22 Nov 2024 03:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D4608D0009; Thu, 21 Nov 2024 22:23:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65CD38D0007; Thu, 21 Nov 2024 22:23:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B0B68D0009; Thu, 21 Nov 2024 22:23:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2CCCE8D0007 for ; Thu, 21 Nov 2024 22:23:52 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C076B8136E for ; Fri, 22 Nov 2024 03:23:51 +0000 (UTC) X-FDA: 82812282924.17.E03C82A Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2046.outbound.protection.outlook.com [40.107.237.46]) by imf02.hostedemail.com (Postfix) with ESMTP id 8F24280017 for ; Fri, 22 Nov 2024 03:22:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=aKjdi9AY; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf02.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.46 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1732245761; a=rsa-sha256; cv=pass; b=2yGjXgevw5wXvjdkNIZd0vUf1nYxOgXwIidIhA4FiHGUrhOB3TzWYgrs2bIURoRGMvNIqR 9g+gcGToUAbofseVgZunjJLitRaryaRXVDKxzGr+IikAVPXW01zjPJmTaSX0dB+b3E+vV2 CY+R00NTyytTrRH+xSl9lUdZc0qG+9s= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=aKjdi9AY; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf02.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.46 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732245761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ETSdF40gF8CERm8Rp3zWNAg7pfjE+AtTR3jebknJgsw=; b=c3Swu0vIdfE6knwuXo3Wa7HtvgYq3Jx4ZWYsRmPOQxnDzvf8C9xgBfUdu/fwO/eBlU/2pA GJ0so5yF2wmyi3jL3jSWceNjfdxCjDKrqkvPDXPfsc7Mrsj/6eQD6MvFa12KKcbcGmLTtp JFTW27yjJZjLRlP1eCdCQ5M1XAqZtMs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kI6tLcNYJ+t4Fq5WwFiOBJ0DEgpSpqLGd8P7/+XnFd6RlriKl1d5Uew1L71Zf37fC1YJpZNSEZLOfJaMu1/Qu/hvSd8mFfDx3H9xNW8HyJqUJwOEzpg13RMqv9/2luKnZgQY0PZjMzkpYdubfzE1cD0z6TxP2UBBVFiJ4pXIPn96naBv+fG6gkpI8vmwww9DSo1jHDl6D1hEiRDzPFp+mV4HbxHGe6pUqJIMLtIsszyktSbAk5JjqC4WDHpJn7IogxWh7u6A+oE1zrbbxT5K0o/8ToiEwYADURDxQQ+pFkcL30fKtqnFTh31SGrVVVZ+MF+tSZIuMgY8AjP3C4lL4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ETSdF40gF8CERm8Rp3zWNAg7pfjE+AtTR3jebknJgsw=; b=KxsW3RwA51TGF6cm0kUoMxBSqf2Q3yUt/bEpsoWHC2i4HRreMeYut2NXACZ9cPd+b0FE+0fbbd7XoWOk4cPC9Cw0FH8aqQ17Mh0ZMpX99ECnhxk/4F38jHhC0vK3oqJH4AlKSTEwltWY46uMvKnirNXq7j9jEDxGRNlPvUcZ+uIeLPk4b5/P+Ot9Z95FHaGyeZaNk6Dxv6XNf/C9VBk65ThdI9HIZPkCrFRhGxmOY9HmcyVqHyNqdbA06SQTC7h4GlYD+Y4PtRSivx3bTkVlSEwdUoL3MxHkK1S5CqNhUPeWcrpB/fJdXyN34P0XYiRMN2d83CslKBp9uST4ReGnuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ETSdF40gF8CERm8Rp3zWNAg7pfjE+AtTR3jebknJgsw=; b=aKjdi9AY/yW+qSkiwK4ZxQdqjHotLuHy4ZM/ERXZK8xKbpiXnO/O7xE0agpghMQj+Y7JPCLh6l/vef7anKYW1mirPccXRf2Nj+8cNV8QFIV3BleCf8rJJu4UpMMNK1lnCvURa1WS8TPozz/j24NgzyhgLKJp4iW+S028vHf8C8iHJ2hqhvpbq7PKo+fv6PlO5/df3KGlbz75wi5KzEqaHYNOa+IStLkgYmzUhwOIc478UuDMMm1UK5lpb1izH5tOxhSHWWEvIV2259/DjgQDXVwCFssrZCmSDpCabV9w/hcthC+hV41Jcs6zSgs1Uap+l1dWhiHjvLl29/c34FIZQA== Received: from SJ0P220CA0006.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::29) by SA1PR12MB6895.namprd12.prod.outlook.com (2603:10b6:806:24e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.14; Fri, 22 Nov 2024 03:23:42 +0000 Received: from SJ1PEPF00001CE5.namprd03.prod.outlook.com (2603:10b6:a03:41b:cafe::b2) by SJ0P220CA0006.outlook.office365.com (2603:10b6:a03:41b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.15 via Frontend Transport; Fri, 22 Nov 2024 03:23:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF00001CE5.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.16 via Frontend Transport; Fri, 22 Nov 2024 03:23:42 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 21 Nov 2024 19:23:32 -0800 Received: from [10.110.48.28] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 21 Nov 2024 19:23:31 -0800 Message-ID: Date: Thu, 21 Nov 2024 19:23:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 17/25] gup: Don't allow FOLL_LONGTERM pinning of FS DAX pages To: Alistair Popple , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: Content-Language: en-US From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE5:EE_|SA1PR12MB6895:EE_ X-MS-Office365-Filtering-Correlation-Id: 441ba43f-23a2-42dd-1acb-08dd0aa510a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|376014|1800799024|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OGNPSDZLbHVXdXV5bGFibXRiQlhHd0F0c1JQOFIwc1lFaWUzckJYU3U0WWxI?= =?utf-8?B?Rk9INTJGTzFOcEFYMlZ5cHduanRmUlJtMnp5bmYwTCsxaVZlT3FlUCtpcGRN?= =?utf-8?B?a3c3KzZzZU9hOU5XQ2VwYTNoM1FjaFQxaHpkd1c1Sngzb283ZnhUeFdPbXFY?= =?utf-8?B?YkoybzV3WGZSS0V4SHI5bnAzQVhhZG1hbHpTQVNnM09IWU1PZXJnOFlrN0pD?= =?utf-8?B?SytVVWgxcGdaVlFWa1d6ZkFMNGV3RlpqamdZUzF5RjFMaUd4MGc4Vmx2Zk1a?= =?utf-8?B?L1V4QjRTcC93VVRBZjhHcmVSeW9lcDMrbnZ3NG94RU9aOWJ1dFFYQ2FIRitz?= =?utf-8?B?L0E0bVR4VWVFNDltSzdyRFduRmJmV2JKekdSbDNQVTlvVzZyaFh1aUFKdjh4?= =?utf-8?B?Y0tOZ2NNUHhESzFsNlI3NXBmcGEybFRZSnhWMXp5RGFYZzRsaTRFUW5JNHVa?= =?utf-8?B?S2FpZ2g2SzdLeFBPNHJMVDNiWTBtUnNXN0xGUTVSZnlLSFI1RVhaUVNPcnNJ?= =?utf-8?B?UFE2clBDZTA3dmhaa2dMMHhIK09ZSzV4M2xVNjNLNWV5UnZxZHZsa3ltNXlO?= =?utf-8?B?SFNoTWdVWFB3eGtyMEFOaThWN0l5S3hQUElQMlBQZk83VDFQRm13Q2Z0ZFFr?= =?utf-8?B?ZVZ1RE1vYy81WDQ3N2E1bmNKb1RzbHJyQkRUaWFUN1l1UzdycndYeUs5OElS?= =?utf-8?B?c0JnMFZkRkFpb3Q4V0Y1WG1TdTZSaWJhMnozQS9EVlFIb3M3OGl6c1REVHk2?= =?utf-8?B?blYra0hTa3JybzlaZ2FlVGt5Z0taTW0rKzVBLzkwdXA1dFBsK01IUzhkazM2?= =?utf-8?B?K1I5ZW45K3hMb0xSUkNTNkYwenZrNEtBQ05hSE9WdzliOW9TUklFYnlkQWtv?= =?utf-8?B?MDRINjNYbmFwbnFrWHdlRG1MVytJdmwvbnpOU3d3Qzl6RWdqVTJJQVlvWHVs?= =?utf-8?B?VlJoeEtyNERBMnpYdjVlRHJlNk05TGkrZVJ3UzZ4WkNqOWxmOXdpS0VMQXp6?= =?utf-8?B?M3VGMEpMSXpqakdvR0lIR1h3YUJSNUdxeWNkQnRQaUIvb0Z5WUdNMngwdERj?= =?utf-8?B?czhvSnpzS2E4WU5wSzlVQ1Jkbm8yc054UlpaS3FWUVZjNUMrL3kyT3VpaTV0?= =?utf-8?B?SjlZRkxvWU5vL1krOUlUc3pUOWxwYlM5UzE3UjVQWHVKTFBSMHd6V3BNYjQ3?= =?utf-8?B?R0JvQXE5eUUyOFpDNS9Gc0JDN1A4aE1SNW1VVWxSaklTcDhuN2JLMENTSzJZ?= =?utf-8?B?Y3BoZFY4OWFEdVMxY3IrSnNpUHBDZVBQWmdpeWJDcVZGclYwUC9GZG5OYnhw?= =?utf-8?B?U3dONVF6WUNEUVJiak9HOEVFc0h0a25EbnVlU3JIalpGWEhUSGU4UEIwWW5z?= =?utf-8?B?VHZ6dVJmZ2pxYXpQMlF2dHFYR0U0bTNHMDNmdlVVSzJpWXFHYlcvL1IyNjl0?= =?utf-8?B?eUVXS05JYlIwUzloR1o0WFcrYjJUMFNPSFYxVUFnWkJOQkhmYVBNZHlyQkhD?= =?utf-8?B?M1BDejMyU1JNRUlvRGFnb1VmZDJZMWtCYXVISE5KRWFTWGJPMnluczFFQWYz?= =?utf-8?B?SUdrdHMwWUFrNDEyc0ZlQTV3c29xM1VTOEdZOW9STlFFN0xPdVB3N0NhQk9B?= =?utf-8?B?ckVnZkplU3ZJWUlPRzZVakVISFVWajBrNGRRUnc0czF6SmwyNlBRUVRMUE0v?= =?utf-8?B?Ymk2WEh3MVY0SDczRzNhZHF0OEVNTG5WZ1B3a0pkTzQ0K00zSm9IMHF6WEU5?= =?utf-8?B?VmJhRDFUUzU2aktLMlcwTk8zT1hQRm5NaWZZb04xMzdIV2JHeWFLNWM0aS9U?= =?utf-8?B?d25uOHZpTW5JaHc5MFpLZE1vL0ZReFRsMDhjbExFVm5ld3lMUkFMVC96TFRj?= =?utf-8?B?ZUZJUGRjWmJDWTRlT1owTWkrcU1pUzVnMHhCVnFHVW1QSVE9PQ==?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(376014)(1800799024)(7416014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2024 03:23:42.1237 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 441ba43f-23a2-42dd-1acb-08dd0aa510a4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE5.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6895 X-Rspam-User: X-Rspamd-Queue-Id: 8F24280017 X-Rspamd-Server: rspam11 X-Stat-Signature: aduziusibmy6t68qamthhj199iz8n3b8 X-HE-Tag: 1732245727-316023 X-HE-Meta: U2FsdGVkX1+aBjF37C2ZldDnKu4qGSGZxC1FRwItrKljXf+pSfPEwVdgGCiIuhfbokJwtoLGH/XTuH7brnJdj2IaxeXSoDopNG79uQOSu/K34hn83FLUOPVgVxhBHm2kFuIPnq5CY7H/Xj+fFBy3mu5timYa2y1NKotr5iRW5/Ez8+2ggj5FpIcP2jo6FdpwY5jaBNgsXJSza39KPB/ZP4mXY+utgN9cJuP908XiU18MP/E/4kGBUYP0CK3+G/LKyCyPjA1t5tC2IMlIy9CaQLAXfgD+aEKfIeV6L1qY/8Nn+5YbT05Grh4yf6J5WgsytmZk6ZoA25/b41/4hwcoQvHVPK4FGcX8tS2ED/IuuT4EPLXqnt/hgiOMn8H3pGFF8qMArRaogJDnueqXyhF7dvA1CACPAM+AEeNb/l7/xeg62NVpXz9WdCw/MGNcG7Y8nn4MR9NsKPdwPNeqMROOoSnbu2SJMiT38PYlK6OTgKMvO4EgGpvvJ06mQpPx6vq12eSs3gpYOTIlJaqjJPxQ/KzXNOTtR7qpYYvNAvJ89hQ4teGtza4aLMAPp+o/35RRGI/3fzag7kCplrLW9imD0n9C4wDXZ4aT0skCiRmtmfeYSR4xTcCVOIa5MHAUim6fxLxkQQ8Ehyr7LoCravuqV7QSbDK1VqodN+ICBRxLZ/rqdA28njiQ/I846zotLQlIrtNBXTMoCKWVeWWwE6UTaoI3kErQe/YZyfAs8Lv4pCDdpLmME5HpbOnPqd2W0j5SBZxUiuB+8XEwb1JPQiYTaLYfqZllXf4+usFheb56BiZ9+/zl6QxzwAcg/c2SRRJjleHWtxcGh+dnggqKtI13nSJzfpL7y+zNgu1fPvgEN4YGy72j+27MOS1co44cL3jAjXireWtt/kai4jTXah/R4A2K2yTCadsmEuYKUdREfQxVi/qrEtalmgiJG5nk6V1+to1Bzv2hp6r7Fcmat7I uQrik8GW 5CB7U7rIpSjE+/m23n/+YU1dB/CrtMWD06s1PCipbK066CviaP2OzloJNRzCjlT6tkdTSnJ6Hqy5ntx0m1vwfqXPBocFVaWX3+NHpHKg4Ilv9W2UmYJdTFlQnggVE/I1E/hokTOgK4+5ytKPEn8Shc0OX7Z91czXQiiqHFxNJJuBsX1SuJFd4/FA1b3hfzU+0EOAN6wNcOgkkCZZwKrM5B9p5/vKVXtCwcZ/Ig8WZgUdxBrlPb/Jpb/Pa+ERdNKUdE582gGa+xQmkmSifDG5V3iZnSkLdrfcwkS9hCjHi0JyneQyUYAI3M1stTDBp4ulEvRU/o5ODf3GECG3SQhcWdlI8YGrOI6aXS4Vd0ZLAjWRZebh0G0Z1wpIYJeae1L7aRK637Ii2zNXsoItAt17K/ZktLtyi8THIaws0rvNvtgKpUI1xmRQssVuG6SjuCoLVxHi/mPwGUH6iJWNKDMqTbP6LIzfBHJo1YERFEVChKByLogFfB0Zjk55ow00SkMg+qsH0uZhjP8p30RtntfYt7lIIHpmLqVxoF45pvMLOyB/am0kgvYF2/YbFH6YGqQZEcJv0B35tBdxHeHjVAugXU00LxnmzlGhJEo+FLjLmzSBPwaIFSCvZ2ljIvgevOTBjwER1fGlko9eqOk4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/21/24 5:40 PM, Alistair Popple wrote: > Longterm pinning of FS DAX pages should already be disallowed by > various pXX_devmap checks. However a future change will cause these > checks to be invalid for FS DAX pages so make > folio_is_longterm_pinnable() return false for FS DAX pages. > > Signed-off-by: Alistair Popple > --- > include/linux/mm.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 22c651b..4f9ae37 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2004,6 +2004,10 @@ static inline bool folio_is_longterm_pinnable(struct folio *folio) > if (folio_is_device_coherent(folio)) > return false; > > + /* DAX must also always allow eviction. */ > + if (folio_is_fsdax(folio)) > + return false; > + > /* Otherwise, non-movable zone folios can be pinned. */ > return !folio_is_zone_movable(folio); > Reviewed-by: John Hubbard thanks, -- John Hubbard