From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2078C77B73 for ; Mon, 22 May 2023 02:13:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AC75900003; Sun, 21 May 2023 22:13:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35CD66B0078; Sun, 21 May 2023 22:13:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FCD6900003; Sun, 21 May 2023 22:13:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0D9696B0075 for ; Sun, 21 May 2023 22:13:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BE254A03AF for ; Mon, 22 May 2023 02:13:07 +0000 (UTC) X-FDA: 80816268414.13.565D6C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id A27F88000F for ; Mon, 22 May 2023 02:13:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZD62Au+Y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684721585; a=rsa-sha256; cv=none; b=ZmYGe5vGbcdI1uP2LaTMTkaFZ6EJl86jSf2A18Njt2iZo+UGYggyq6MntdekckSj4l1CMT uwHypo3EA1wIIkvU1hxfr3pNtiYE3Hlj9YI/BqrpK5YNnT/uHVuZ6DwJ1ROK1QMvEh+cN+ vJhuTwrkPoxZtV7WtCkshCurgCJtEU4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZD62Au+Y; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of xiubli@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684721585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gmNRxdDl0Iw5312gWw2B9QxJef2rV33yjDNEcMTuktQ=; b=LlfwrEvVdiwyxPXVZkYn4RYMU6/jmE5oqgTTYbz1tdwoFIbwlGG2IFvzlSelEO/zhzdMA3 Xlx9uUyh/L7sVyVesz2AQ07GAop6FFnN4W3o7KKGQrf9UTyB64t4Ya1AFRzUfbHYMNqVgp B2kW0JLTInFlBIuWcZEsmT90HmXSIEE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684721584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gmNRxdDl0Iw5312gWw2B9QxJef2rV33yjDNEcMTuktQ=; b=ZD62Au+YqhKy/tohfdxWHd2jdCi8Iggn5ueFiliQpm/AyV6lB1R0O9bRO1SBc8df1BvWIi 8eBbPduXHVJQQ4z4g/7MP1GQglQGNqEi1oBJm401xxYU8hcaR3uIRcF0KbmG2JJBIfg86c /ZQRzeiRbY7mRvHzIA2j9Bgy8w3MTbg= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-NoBojvI-MkaDaIuch9NMdA-1; Sun, 21 May 2023 22:13:03 -0400 X-MC-Unique: NoBojvI-MkaDaIuch9NMdA-1 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-5340d9fcdd7so4686548a12.2 for ; Sun, 21 May 2023 19:13:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684721582; x=1687313582; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gmNRxdDl0Iw5312gWw2B9QxJef2rV33yjDNEcMTuktQ=; b=G6Z7bN+UhvQkFfuLNl4Xo5bRDTbaQXzFkiNUSI79yDWXvkMRZJ+vHSL9Y27cUYNAKg ptKSBo4JN0LkpedHjXxNYnEzVrDdq0YwLAqGsC3dcbXWuhes+w/LfZ8TEthGyOf9+HyH 1aLluCenMXATAFa/TjmbRx5crAYvAVRzWkbZQkGG4pxSh84F3qP92ErxwwLQz8HU+5qV 8uT8ueTmiCO/xnpYXXXo65v7VQxYYqrKTKrvUN+vGw6RWL+mEBKYrHOn+qSIIFTZgO3t 7Sgj7Pcam0cnexch6R8xjP19XGglUtXVW2qF3fBRz5cPDKQyNMqyNnjWdXIU3jHi7GBA W5vQ== X-Gm-Message-State: AC+VfDz/JohUc5yjllaYQh5UkHY0tILnuk6VIeY7l1OAdTXFhOLTTGf4 7rvYZLH9dL6pgq2wlepI9YXroHs6tTYcMgsDS6fnrv9+dq8oExgV7hUEloAyJLxSTi/Ref5Yolf +t7CYPKTKiJc= X-Received: by 2002:a05:6a20:5483:b0:10b:e90d:13a2 with SMTP id i3-20020a056a20548300b0010be90d13a2mr590821pzk.36.1684721582506; Sun, 21 May 2023 19:13:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4edrM21wwKnQnIY2WKOKek3wiSXXo/hL8jRVd6QZLFCn+oldEoDVlQ950aoB0pemRSWszePg== X-Received: by 2002:a05:6a20:5483:b0:10b:e90d:13a2 with SMTP id i3-20020a056a20548300b0010be90d13a2mr590790pzk.36.1684721582215; Sun, 21 May 2023 19:13:02 -0700 (PDT) Received: from [10.72.12.68] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id i9-20020aa79089000000b0064559b58eb8sm3081025pfa.154.2023.05.21.19.12.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 May 2023 19:13:01 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 10:12:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v21 16/30] ceph: Provide a splice-read stub To: David Howells , Jens Axboe , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Ilya Dryomov , ceph-devel@vger.kernel.org References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-17-dhowells@redhat.com> From: Xiubo Li In-Reply-To: <20230520000049.2226926-17-dhowells@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A27F88000F X-Stat-Signature: 1jc3f597ctjug4ffna9ssxtywrrhd93a X-HE-Tag: 1684721585-242188 X-HE-Meta: U2FsdGVkX189Rm/ISAU3lR3328UgrWR/LeGsRRpfqsDUxlqp56TP0c8VpK77PURCrUGh83U+msc1NUXyteRyS6EzKcLZFI8jkYh6jCJWJXMIhaAvfzP0U2+F8EESTVXbusgiHYsI6b5EqxFORgpjt9gdCDj0ZtYGDTdSeSGfz2mBK8Jed2L5iR2G1xySTkMzVWpHUKjYqdsjrppsGScwrk/Q9T+WGfoyle+kxWRXWd0Sjm3jXOsiCHq2j8WQ1mlI5wQ7zUhCPwMkSXThWWrpwgrwJiVrr7RT5Dxce0gMjkK2zIiR7pQrhkFEQ9IUhNgB3625xq3M1WyXZxcd7G/elrtVb/m681U9nldob1Kyi3B/mSEltTA31C+cXa2xWa2LRAVR2inoLGipmP/QHxWLnQ5jYLLS1G1jZmETYJJxQwzDbN8NN+LEpzZJXyIqT9aUPb3AwaTh81mPgTgogT5yjYCYCt5EbuWFCMBctqGuoEbFZiuD0MMMfkYSLOGHqV0cpx3HB8ZC9hCscWsbFdtqweUMx9BPjl54JOv/8Qpwgl9VkPHOd2VSh1z25+hATXBStqm0KqYT5c4Lc4hI0Uxn049UHAsx/J3IUOXMQef+6EN0c3JyFHpp6hLR0H7Gln6LzJPrc/RZygRi1w+VIS20SYANRNhVelo5M7ysigZYRYsMeLNbzcNMVC82ITz/Nwta15j4Csh3Y+LPz+MjrdJlwOp8Ctf/x7rGZ2HxEBGzqvSDLVSEVRio7XwFgQpfnbxFan2ojGw6wLTCnhUfZ+BSTXTnbIHuenM/vqUTlmn3Wi1D9I0rRXMIYv9MQ8xIpjaOaGuXz6q3umYvfRa8xV2X121R07O/HDBbKPknVuTMlZiTzV+Xi4YF3omz/qiTQUN8e++4lYgwCAZ2dmpFjSKGsZmI550yweNngyKXWNEM+nd5RCcnvLSgpVL0hHqyoZ/bJJtBOvnlFQsXkamadDr yvNqFVze gcmldhoSHgJMtYNqMSLKH+VAwURy3r40e1xKYqGIQ2HLYfPXmJDSIDODIAMM4A4dTASDoPhnJ5+Cm+A/MBraUumopHcm4DXFXXn3fu5S4kV83kvkTCU/9b5FnpRqxQv6TEZ0iU8GFZpsMDn9scZNs6rAHO+1Dq5o+XFj9w/TbbqBUWZzFw/qVvGAUWEE5VSXj7z9x3PKiR7CJkMmew235sN7oZ295JTlR6SwkkVO1FyUJbuq7sqUYTQF85hdN9kw3sTZfEH4PXoC4B3QdYibn/iW5NnyK+UddSbUu8e/jOLzEJ4XP8aiiPrjQvD24i7CuYLV02vaZIKROhbue56F4NSnwHfqjTkkbKB6mWuAjf91Nq6xpIxlphqeHkBTKsItyZHxJuXfKYoL7HC5tvpId7342iAjxBgzLg+iQG1QDW7e92HygKKxIklxvXHTFMwFbO7LMGaxwF810vEuiur7ySUBUkQ7kdTnpqN8xFGXznCtJn8W1OR0Hpry2acDPpPWQNX2/n/GXvV7RuPVahfb6++KAkidBhwq53K04hV+xU2KoQ5zYN/nY72xZcQlQzvs7YU8u6XoFhleETzf1CQnXjqVoKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/23 08:00, David Howells wrote: > Provide a splice_read stub for Ceph. This does the inode shutdown check > before proceeding and jumps to copy_splice_read() if the file has inline > data or is a synchronous file. > > We try and get FILE_RD and either FILE_CACHE and/or FILE_LAZYIO caps and > hold them across filemap_splice_read(). If we fail to get FILE_CACHE or > FILE_LAZYIO capabilities, we use copy_splice_read() instead. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: Xiubo Li > cc: Ilya Dryomov > cc: Jeff Layton > cc: ceph-devel@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > --- > > Notes: > ver #21) > - Need to drop the caps ref. > - O_DIRECT is handled by the caller. > > fs/ceph/file.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 64 insertions(+), 1 deletion(-) > > diff --git a/fs/ceph/file.c b/fs/ceph/file.c > index f4d8bf7dec88..4285f6cb5d3b 100644 > --- a/fs/ceph/file.c > +++ b/fs/ceph/file.c > @@ -1745,6 +1745,69 @@ static ssize_t ceph_read_iter(struct kiocb *iocb, struct iov_iter *to) > return ret; > } > > +/* > + * Wrap filemap_splice_read with checks for cap bits on the inode. > + * Atomically grab references, so that those bits are not released > + * back to the MDS mid-read. > + */ > +static ssize_t ceph_splice_read(struct file *in, loff_t *ppos, > + struct pipe_inode_info *pipe, > + size_t len, unsigned int flags) > +{ > + struct ceph_file_info *fi = in->private_data; > + struct inode *inode = file_inode(in); > + struct ceph_inode_info *ci = ceph_inode(inode); > + ssize_t ret; > + int want = 0, got = 0; > + CEPH_DEFINE_RW_CONTEXT(rw_ctx, 0); > + > + dout("splice_read %p %llx.%llx %llu~%zu trying to get caps on %p\n", > + inode, ceph_vinop(inode), *ppos, len, inode); > + > + if (ceph_inode_is_shutdown(inode)) > + return -ESTALE; > + > + if (ceph_has_inline_data(ci) || > + (fi->flags & CEPH_F_SYNC)) > + return copy_splice_read(in, ppos, pipe, len, flags); > + > + ceph_start_io_read(inode); > + > + want = CEPH_CAP_FILE_CACHE; > + if (fi->fmode & CEPH_FILE_MODE_LAZY) > + want |= CEPH_CAP_FILE_LAZYIO; > + > + ret = ceph_get_caps(in, CEPH_CAP_FILE_RD, want, -1, &got); > + if (ret < 0) > + goto out_end; > + > + if ((got & (CEPH_CAP_FILE_CACHE | CEPH_CAP_FILE_LAZYIO)) == 0) { > + dout("splice_read/sync %p %llx.%llx %llu~%zu got cap refs on %s\n", > + inode, ceph_vinop(inode), *ppos, len, > + ceph_cap_string(got)); > + > + ceph_put_cap_refs(ci, got); > + ceph_end_io_read(inode); > + return copy_splice_read(in, ppos, pipe, len, flags); > + } > + > + dout("splice_read %p %llx.%llx %llu~%zu got cap refs on %s\n", > + inode, ceph_vinop(inode), *ppos, len, ceph_cap_string(got)); > + > + rw_ctx.caps = got; > + ceph_add_rw_context(fi, &rw_ctx); > + ret = filemap_splice_read(in, ppos, pipe, len, flags); > + ceph_del_rw_context(fi, &rw_ctx); > + > + dout("splice_read %p %llx.%llx dropping cap refs on %s = %zd\n", > + inode, ceph_vinop(inode), ceph_cap_string(got), ret); > + > + ceph_put_cap_refs(ci, got); > +out_end: > + ceph_end_io_read(inode); > + return ret; > +} > + > /* > * Take cap references to avoid releasing caps to MDS mid-write. > * > @@ -2593,7 +2656,7 @@ const struct file_operations ceph_file_fops = { > .lock = ceph_lock, > .setlease = simple_nosetlease, > .flock = ceph_flock, > - .splice_read = generic_file_splice_read, > + .splice_read = ceph_splice_read, > .splice_write = iter_file_splice_write, > .unlocked_ioctl = ceph_ioctl, > .compat_ioctl = compat_ptr_ioctl, > LGTM. Reviewed-by: Xiubo Li Thanks - Xiubo