From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA85C05027 for ; Wed, 1 Feb 2023 09:07:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D854E6B0071; Wed, 1 Feb 2023 04:07:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D35506B0072; Wed, 1 Feb 2023 04:07:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C24CC6B0074; Wed, 1 Feb 2023 04:07:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B8E096B0071 for ; Wed, 1 Feb 2023 04:07:38 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8B46340ADC for ; Wed, 1 Feb 2023 09:07:38 +0000 (UTC) X-FDA: 80418144996.03.F78C40A Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf21.hostedemail.com (Postfix) with ESMTP id C0F1D1C0012 for ; Wed, 1 Feb 2023 09:07:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675242457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svd0hoNX7HC1/uFI9rrqGfsTCiHhXc2+NBFfpj04KDs=; b=rWOOPdgNC4395SVUuhbXI0tI+W7D/lmr0/+kj+v5iMYBKSFlLG7dDAaRXHNo3R7wq3SPoT 1BuncrLPi00AM/3xO0IGfZghamhU9MF9tjWYUUaILI9Kv7KvuHfBIcZtL9uZSntg/toL4i 5PvjYTEyyU6oEs7ks3sYET20EFHn1RI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf21.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675242457; a=rsa-sha256; cv=none; b=aB23BRbJAabYMTx0vIa/IC/1Jr9FkSC+Hflk1O8XILrBvFpiCAXUy5rOR6819YQeM/xuCM EFEUANTsxuAmaWypZNRNlVfZuN6d4u0jmeGkTJ/WQqDvhmpG1sF+LFwei+d1B6UUkt71Ww 3svsJZBN8kO7K7cV+OKhQd/AZid/Kok= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R481e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0Vag58Zn_1675242449; Received: from 30.97.48.53(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vag58Zn_1675242449) by smtp.aliyun-inc.com; Wed, 01 Feb 2023 17:07:30 +0800 Message-ID: Date: Wed, 1 Feb 2023 17:08:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] mm/gup: Add folio to list when folio_isolate_lru() succeed To: Kuan-Ying Lee , Andrew Morton , Matthias Brugger , Alistair Popple , John Hubbard Cc: chinwen.chang@mediatek.com, andrew.yang@mediatek.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230131063206.28820-1-Kuan-Ying.Lee@mediatek.com> From: Baolin Wang In-Reply-To: <20230131063206.28820-1-Kuan-Ying.Lee@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C0F1D1C0012 X-Stat-Signature: tgr8kwxagd1ed7g7qf1576o8ujc6waxj X-HE-Tag: 1675242455-740522 X-HE-Meta: U2FsdGVkX1/k+j1AuS75p9OW2rqNdTOljqqmQVf6PLLVQ85yYAj+MYcXnqxUsLLpq3yzAQ1EMWLngPypGAnzDp53zMpRqmJVImYJuJ4hV0kS5PQT7zUQB47P4HaXI4fnQxDePLzw6E3Zc//Ks/pOPE76iZIRw/UU9PoF7AxVlj/Wg7tSYuvSpxDd85ulzesnZ63t01uQC/F74E22z8R5U4l9/XUdnYGFsY1Co9DHwQAjuj5JS48/8ikuxrsEf6ohjJzwKEF25weTvwbWu7f5ltJlNufBFR8xyLhY5AbXWNa2PeZth55tXruu+fPQW2hbC7D0jStXU8icRBHNNhTKs+JlO25OHoeum5fE/grmH0C+AMrXkb6zXmshaR6R3I+egOnB/4BGBIRthchKYiAnfhZDa97VvLkbpEjAZp56V7FwwTM3VUq24/7JHC3aCM0Gui8FsF+Tm7Ky56+3bWgtm+wwq49UTguzNX6B98RBfNsvATTqcPEwmDoWIlDOCzy7Q+7o4EdU+3dAug5vI30RzsmKlXymR1xwjq/7+BfFWHh18RzCBgHNjhDLRX0/+Av/xc4Cs4bxterlRLOGc4bDeXrWIdT3cFkWdqxVthH1eYG8L704iI1kFUhxOFfKSWCH7mmT37kJmtQIOkyapUOHRqAF49VMzkbCwKqi85wSSklKTtqtIIrSl7N4qCyeJT2Z1f/737rb1k9wpscPrLcahjXDl76NMJ8LqP+XoQG3OxohTlcF+DSFXtwY9bES7GuZGa00fOigpjqBLjOx9LGv6Yq7CEUnDxd3PLDsaZUkaE2OYB+ddBKxfXOa9slZSo/XNsJjwRLVPTAwYiAVkK5N9yVo0IR3U5o0zVdeoRQAf56d7SD4Y1jFuKxOC3FvK4jUi9mRDwBiCQB24n6/0dJozKETn2TT8+R6EqU2C8TTuMff/jWr6ezXfZeXjnVH17VpYOG63FiYe77CnJH3fqN hK5jMZro FiN5FmaIZnRhZtvAW7dmJNSa6IisbQoBJKcL53KlR5yQcHjQKaf7dFJKQmllG14jS8qYJ52Lz92Sbo6cMKHmS/NOmEytpJGlI1B+551uMzpxSlmn8eQ+8FJgjmcK3Yegz4SB9Wt2MOWbiQzwzQAhhtyRCQn91wTyEwIZ0l39l3wydgq/jXkf0Xv1siTe8sm4q9/TAoPZVuXvh9zCR2GBS5MOqYpdy4/Q6BWvRa6SAKayL4Q8ECtPJHJaDQJfCfu52/Iluh7cS55Z+UUEcvI6cs+y9JIg2QsJo13M9um0S0ZWhaMs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/31/2023 2:32 PM, Kuan-Ying Lee wrote: > If we call folio_isolate_lru() successfully, we will get > return value 0. We need to add this folio to the > movable_pages_list. > > Fixes: 67e139b02d99 ("mm/gup.c: refactor check_and_migrate_movable_pages()") > Signed-off-by: Kuan-Ying Lee Good catch. Reviewed-by: Baolin Wang > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index f3d2cccb89f8..918c364d01ac 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1914,7 +1914,7 @@ static unsigned long collect_longterm_unpinnable_pages( > drain_allow = false; > } > > - if (!folio_isolate_lru(folio)) > + if (folio_isolate_lru(folio)) > continue; > > list_add_tail(&folio->lru, movable_page_list);