From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3995D75E2A for ; Fri, 22 Nov 2024 11:23:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21F858D0008; Fri, 22 Nov 2024 06:23:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CF7D8D0007; Fri, 22 Nov 2024 06:23:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070538D0008; Fri, 22 Nov 2024 06:23:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DC8408D0007 for ; Fri, 22 Nov 2024 06:23:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 652A4C0C4C for ; Fri, 22 Nov 2024 11:23:27 +0000 (UTC) X-FDA: 82813494750.29.BD0037F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 93270140015 for ; Fri, 22 Nov 2024 11:22:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gfXIemiU; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732274511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e4sNKfkYLbgxLymNaKWcz5EURpnwdMj1/RfxsrYkQxY=; b=bknvHBBo0JzEcqntOOvsO0KhRKcN1sAhTxzTfL2TRVJW/z0XCKG1NKExaHpZnqE+s4iYA3 ko+ziH/3XnBRy6pBY6m27XY+xwfm8bMQkHDflRD1SQLVB3NZTrvjA3xYpX6saERMLKJYPY +7WHM/sSN2k3P+kn7FRTlnkrCNiIPfA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732274511; a=rsa-sha256; cv=none; b=5wlsZiXr79LZom/bYW1KUD8X8i0bOJmdZPHNsKe4RZBlAu59blXPhOWPH5me4oYKaMG1S9 ++z38QmttHXWIbsL4gkBUgf9QL7w41/mJw7isFWxCTBY6jx0g+EWC5fzVRAmFTPtJD90nv bJkg1kJ77wwYN2RwR8GTE3C/sGq8LXI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gfXIemiU; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732274604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e4sNKfkYLbgxLymNaKWcz5EURpnwdMj1/RfxsrYkQxY=; b=gfXIemiU+jvvEoKyda6YE5O0/4HrsU3zx8RRCwTSKzqB+Xobnc/QKXpdOZWASIucGhx7H7 /5QPUzgIg7H5yFDvrkkp+VmrpsrVjb8a4Cc9OJkV4XbOoJ/C0gVOubJFy3MwjjwhdHQrth TeH5/GNNOQZrRSqKnl8OF/UJg8OFAis= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-_JMPEL2FMBm3wbSpQSFhoA-1; Fri, 22 Nov 2024 06:23:23 -0500 X-MC-Unique: _JMPEL2FMBm3wbSpQSFhoA-1 X-Mimecast-MFC-AGG-ID: _JMPEL2FMBm3wbSpQSFhoA Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-382450d158fso1068973f8f.1 for ; Fri, 22 Nov 2024 03:23:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732274602; x=1732879402; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e4sNKfkYLbgxLymNaKWcz5EURpnwdMj1/RfxsrYkQxY=; b=qogVP5UX4sb6bdq/N9KGXc3v8m+axzMV2B3D8zjHsokO3Hj9h6avMGVKMsMiHv13fk AAatOz4i5g+0ifcghjb5fhafCgUDmGPNkUkn8x0us2RR28mtibgMNo7XiEAzzabAI2RL c7CA4EBgwjvL+QDExf421ks7R7TVFZsvBqeGYZcoq/d8Rr1SNegeRZmn46FEaQ/FM9o5 QLvXuIr+FM+3FMaDkcv2tJvN29M7FZ6zWrIKtT4QQssQvWDddBpTySCmdnq2o/kveRRn zxHavkoN5F+BFps9ehTSjsba26o+jvLWss1AsVhmiqR4W6HnesvhfGG1HJYvhHBoSOsv PHdA== X-Forwarded-Encrypted: i=1; AJvYcCUJtYeOHWqWp2ZaCX+cIZKJzRE1BpSANcVUBuqI0MYoIc16c7APbe7Cs1VeUkSUtSw1Ao0D89kmZQ==@kvack.org X-Gm-Message-State: AOJu0Yx9stYC5it9o1K21xP4RyEIsc2mkYX3tmEu8GtJNqivuG79mLB4 U/C7UFUJD0ZNSVsXGvig7mC9NlXdPdLm3MbTFPES0Que6JdT2OlzGtmxFc/Uao+pbQDPQP21TTg ZEBtv7KS12z8XyLdKZee1m4PKolMbV/WKCvQLCVhnBmefTO3v X-Gm-Gg: ASbGncuIeXHGpW8+xV+v93sKN+wivH2+Nu/dCMA08i+dR6a1UlVoYL35lulfKZeTlTg hNH76TFJW9eB3xqADmhNgTNC9tQxUxYrGE2MP9MgjLnfR7+nywgO6t2jjqa8Ue26JhNBnsIhAGc v0eEpOS4YkomfuASGZQiZViZPSrkijLtWH8YanuFrCxvuqSzPoNARXoJvV3MmYKh5vOVHBjLxTS 7A6ZyI2j7P7PcRLh5TOMInKD1Kk/ulYWpSTW4A0mgm7yXOTkVLSjGskxko42D9qidFO+kyPWAdh F4W7Al2LiQgazWBpjkqqOph1mhhgY14C88QYzAGmkyu5bVnlOrK24SNkZbZyBsS14lofkd2DlvA = X-Received: by 2002:a5d:584d:0:b0:382:4aeb:91c7 with SMTP id ffacd0b85a97d-38260b5f9c8mr1533814f8f.18.1732274602050; Fri, 22 Nov 2024 03:23:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IG1O+JdrBe9e+xVNXaAjMvRC2BeHCRPSoNWXD2QnDk/kh+UW1Cva1MiLJ/BJpMJZRvC5Gl/qQ== X-Received: by 2002:a5d:584d:0:b0:382:4aeb:91c7 with SMTP id ffacd0b85a97d-38260b5f9c8mr1533801f8f.18.1732274601710; Fri, 22 Nov 2024 03:23:21 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:7a00:9ccd:493:d8e2:9ac8? (p200300cbc70b7a009ccd0493d8e29ac8.dip0.t-ipconnect.de. [2003:cb:c70b:7a00:9ccd:493:d8e2:9ac8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b45bdb13sm86546165e9.15.2024.11.22.03.23.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2024 03:23:21 -0800 (PST) Message-ID: Date: Fri, 22 Nov 2024 12:23:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] MM updates for 6.13-rc1 To: Andrew Morton , Matthew Wilcox Cc: Linus Torvalds , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241118193001.6aefcadd7426feafedf824e1@linux-foundation.org> <20241121214229.8fe091954f9bf0d26f54ed88@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241121214229.8fe091954f9bf0d26f54ed88@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pz4qvFgZb1c2OyB8e1JXv-0jCXVs4iBq0LqENqs2MGI_1732274602 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: 7fjmko4hytnj7i7q1eos5gy9cinwsm7e X-Rspamd-Queue-Id: 93270140015 X-Rspam-User: X-HE-Tag: 1732274569-376510 X-HE-Meta: U2FsdGVkX1+Xgx5aDPavAR5IyKz8RfLUrQjNmI2ts/XzR37VIhXp7BnnQrsKHxYn2AV8PspFcDP15QuDol92Ty2JFifMhmryXBIP2cJmUnUrNcBkw1xNwXZpxPJJdGdJvGBt4REMp9WTPXDmKYpV67RTNrui+NUvMmy+tStmTFidSrpKf60rSrCEPY29jVg/O1NZIehVpoLGxkzdEEgL+eTzxxQhMSyBILgz3HzWxm+y2wIIP6mRjkwymfYD29DCrLYbE9k1ch4VZI2qewTtnhhFDK5sGobBw/gvTSHkO2QWEs7nlENaVzJ5tgl1k6GjOz8rkkfpUpSHpjBd94VBhQscKbGjAxB4mFa6OQ0lDX87jgJ5BmbcqEOsAGgp7+JsC1dKHqR+jjEIGRzPmHf1LHnMyGj0z4trLZUBHJs2k9O5ZxHzMs5YMA/gx1amPTnkvNIX8JvUTIU/WWGMhwnmb+9tMTSw1fg+rDF1AQdKHUSf5Q5ZLR9vOtODm5rZ1nj9ifiDoP70pcfg1GXaVwcUMY5SC5DyESKw5aCSmZjSBCqg6vOoAmPS9GmLm+zuoUnMTHRRbxOlel+u6P5X/GwXBUl8NXlDTnzPvAgcL4G/77FbOKA70zMa1AdibErqciWHK41ZdDq3he8sS959J2Iid99yxJXsYAjR9qxV5Cr+tPNsrrNlbMs1vXIqLL8vRlNi+P3FG8S/IcJ09VNWuFlAqlH+XkNjLLkigHsIsFS5mXjgD13DxePRmD0uP9I6LbIFOPd58EKQFu52WTSJ8t3z4/VpZbQ/p+CD9/noGVS2mtQZ1ldfTW6xekGxnv8RgbxEYSzPQjInYSKJUKCIwp6pAQQNHfRQOSgTzsihl6aA8hjcupfwmXUZhUCzr/a4bocZ3/bRjC8w328rXWXG2tgOQqI8VNEM9gWL7kSpmjWubUiLhkCCAcSuFkXx+LeL2Rya7hgcg120gpPblM31Ssg P49P9rKX vTpoJ2/c6F9GTZeBW4ivnVwRyEq96J8Yv7f9mW2VGZyQgpAgyKLh7wrFivR2Te7RElB9mfMmL46bVPU6s4u4kaHKf4vosMUchS+tqMyKR1OrcLeIucKF2EvIIiEy6Wz1f84RFeInx/JZjyfDwCm1Ha3jfiXAVjEkFv6I8oxXqnPNk3EgZn0PVHxPNKD0n1vgMOgAmJMM24f0misaZ2looG1cBeF62XDgu8ppm/IVzFfY08jFuCtVPvW35PyP6QqkogKKWdqbyBxAGxVNxb7T+wTDs0SzqXbEj/nb6Ini/gH0lja2XwtuZgQNTdsPWzFbY4OFwkqkHXl+sWzs4phYXyPFi173u2CwezXZDeOshDGsBIN44pfdLS8JlW12UqcboPppjKrkfLO8WQezm6wON3QUn0gGDLkLTTeZ43kcJWofNUXJ7580m/UFUUpnmcyUb+sLXwIyU6wB1Fm8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.11.24 06:42, Andrew Morton wrote: > On Tue, 19 Nov 2024 04:35:47 +0000 Matthew Wilcox wrote: > >> On Mon, Nov 18, 2024 at 07:30:01PM -0800, Andrew Morton wrote: >>> Matthew Wilcox (Oracle) (13): >>> ksm: use a folio in try_to_merge_one_page() >>> ksm: convert cmp_and_merge_page() to use a folio >> >> Unfortunately you left the crap patch in from Gaosheng. Linus, can you >> apply this fixup? >> >> >From 3d7e7319bbb3ced1dfb9c82bb7e8c7386380799b Mon Sep 17 00:00:00 2001 >> From: "Matthew Wilcox (Oracle)" >> Date: Mon, 18 Nov 2024 23:32:25 -0500 >> Subject: [PATCH] mm: Revert IS_ERR_OR_NULL check >> >> &foo->bar is address arithmetic, not a dereference of foo. >> Huawei engineers seem particularly prone to not knowing this. > > It isn't only Huawai people. David acked Gaosheng's patch and it snuck > past me (again). People keep on getting tricked by this idiom and I > think we'd be better off with some nicely named wrapper to help > readers understand what's going on. The helper we have is "folio_page(folio, 0)" ... and we do have a bunch of that usage in the kernel. Likely we, want a more catchy helper that simply gives us the first (and for small folios the only) page. ... not able to come up with good names though. folio_page0(), folio_first_page(), ... :( Once folios no longer overlay pages, the &folio->page trick will stop working I guess, and I recall a comment from Willy about that. ... and then we'd probably have to dereference the folio to obtain the "struct page"? -- Cheers, David / dhildenb