From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8549AC77B61 for ; Tue, 25 Apr 2023 19:12:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C71226B0071; Tue, 25 Apr 2023 15:12:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB326B0072; Tue, 25 Apr 2023 15:12:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9B5D6B0074; Tue, 25 Apr 2023 15:12:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9A32A6B0071 for ; Tue, 25 Apr 2023 15:12:38 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 34B90ACD31 for ; Tue, 25 Apr 2023 19:12:38 +0000 (UTC) X-FDA: 80720859996.02.A71F104 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 7087DA0017 for ; Tue, 25 Apr 2023 19:12:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hNysl+t5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682449955; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=70g+NCto+HDlpzK8JbdxwRqupO9nxM+GSVF/MBgd8Ck=; b=xx87XiN/bWAG4iMIbViZ666f7Y1JNJ59JM9UKEVoblzhdk9Ycq/iQBsK8CihvUfIEFWzMX yOKUmyUWb6qmS79Vtb6YQ4PNPmE9Si/trSfeLhwtMj+wT/pwxti9D9L+xrbT5dY3p5GU3G hY+qaxmyfJitI0GgUNaWwoErKGnWP+Q= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hNysl+t5; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682449955; a=rsa-sha256; cv=none; b=592/s65y7Gv1B+v3cawT5FPeW9OOJalIvFveklasMrcfobiOgMD0cGCLG4PR4UFV3SY07L gOAtPBX6rGUM7sY4JP9QoMWItox/wfAex/RKphj/4ajevDYjIGj1oOP/R4DKHaDNJbjoCe tPOH6BNcaHFQ3+aopW9QZfJ3U9VXfVs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5465B62B2B; Tue, 25 Apr 2023 19:12:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51489C433EF; Tue, 25 Apr 2023 19:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682449953; bh=lMDAKv+dWFO6VkWUCnMr163Sk2UkfZaflcg85AFNg4o=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=hNysl+t5lkcBFn5CSWQ8toXWyK/+6AVSyIsFdzKmdx2nrRruksUKDv2q+kkco8ldw AatdU65HJvfsAWGaXB3bDdvB8Iyl/lNyjI3HnssP1fPjRZT4BL7xQRpNy+OFjPxyWp R3KEfAr8Pokc522ah0tFu5zUA6wFTCaDiJhgU7wP4eJkStWO7sA5DdiJUAyav5OsqP 5ItJNMp+T+9EZczVDYT+HEAxszUHJgYR9XlJ+m6d7Rl6L8PnRlakPeMx8ArQahyHTt rGKx6HvWdwqt86iZ7RQpBFrO5y3wRJgoq6qmLouQnQtwBQWcxEbbW7iBFlKP4rN1yX z9gGYrOyUWxXA== Message-ID: Subject: Re: [PATCH v2 1/3] fs: add infrastructure for multigrain inode i_m/ctime From: Jeff Layton To: Matthew Wilcox Cc: NeilBrown , Alexander Viro , Christian Brauner , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , Dave Chinner , Chuck Lever , Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Date: Tue, 25 Apr 2023 15:12:30 -0400 In-Reply-To: References: <20230424151104.175456-1-jlayton@kernel.org> <20230424151104.175456-2-jlayton@kernel.org> <168237287734.24821.11016713590413362200@noble.neil.brown.name> <404a9a8066b0735c9f355214d4eadf0d975b3188.camel@kernel.org> <168237601955.24821.11999779095797667429@noble.neil.brown.name> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.0 (3.48.0-1.fc38) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7087DA0017 X-Stat-Signature: w9mn4eqesnn6pckhb8zt9jjuwfedbqxm X-HE-Tag: 1682449955-375255 X-HE-Meta: U2FsdGVkX19f1Am+IH9wVVPHu6GWGVmIRKkBsUHFRgFDmqh67HwCm7M4+2KTTSnHZYj2zqJPTTQjTqsDNzByZinlmorjY0DSHFWIG4Xm1/WVYO527gM95xdFcULJw9fFCdGon9T/QEojeT8pJFcppg2rNyAsdDAP+UA05rDqAAKLIrnQ9lPNvXsfXSitaJ7maiqSIf6nwQ9srFzi9q8w8tVIfJTfT1qNlTdBxK6UkLmUnOWSwObBAvxyF6s4JiIzcx0kwkswj+hCT35/qhB0bynPgg7Uz3r/QKQkKqcFBgxBKRampHseFQU+UgZGyQb5VeiaQsQMLew9olxOJ4Fw4FfkqYXqx7SSR8DuOmjwtT49PDQC/wJdYtZobS6GnJE7rl507Nao5SahIsz/kB0ndaehgV+Nx7xNCr4DTZOmx40wV5GUHSNbpZnBUubvzOQAR2lkdcsWybZ+fzveDQB0up2qt/WkerLk1WFOMpfyG48grUMQDekW80JSVvZmAQe1Wzgbuq1a+wguUAG9igdVvsjHUIceRc3kI1N/PhzsYpJh8RUDOcehqEE9CpCaaGYNZhh61LrZA+G1pcpIPjxcB303vh7PJu9GzQOQgFnmulpSzr+MkqSZYUWyujMuDDXqaNuT7aOjwNg+iV8ENAE2bSzjtVa8SDd00uwQbMsQf/vV9e15b6dS1l1lGcocjCFi4x+oPNVAn/bDgws0FMGatCBzRDQxHc7ZkJzvFeoAw5JtGrmlJcBVej20VHnaeSpfGNM71YiHlN1n5jINRCekubwgGT6bjF8HZlcTQFNJ+ttet780almI8sUxpUHMcNmAgKqV3urTV7LBdoiTbuLWx404Tv0xaaU23NfsR9ufKujb+WMZNfAaJV+hzIwmDmWOYj4BqOr0y4CAToRzofiApx0OQReP70355CRC5e0KUPlrEBSr2jiTRl5J3dV6I2LbFeTKklPTdmgbInssjXs N3H++tiW T7J40xhHFlqIhrJZsLyCp4TeAVYQ3oXHMHKrtX5Q3I5t/TXt1ccfVdAexlGA1RJtMKVZg1jn2uOaizjLbQPMankQw9sTsEagN0/ZKFVNh7nNeT3JNCad+26Uj+WVHaXxFJYZz9qVvRbXUWgXwao8WaPQnsPBzrKJ5fIU/PH51/QKLtcBIYga+cRqIrggGuhbQ14jdpCUeqqSR4MT8h4XDzPQyOCebe3xbC5AgED8cpCWeuZ99ggRd3F8220hS3Vy29CPPf5csCfg59jMP9DizdR/Bc58ELQVlVFvq+tZ2NB5rRWhVP1r7I9fLFG2pQeytpJr+LOdGK2MdLjEwr815iAZB68ARTIee+7BWoIBSkC7qrzL58/ypexrjQIIF2R26oH7rAuAz76CXexw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2023-04-25 at 18:56 +0100, Matthew Wilcox wrote: > On Tue, Apr 25, 2023 at 01:45:19PM -0400, Jeff Layton wrote: > > Erm...it may be an unpopular opinion, but I find that more confusing > > than just ensuring that the s_time_gran > 1. I keep wondering if we > > might want to carve out other low-order bits too for some later purpose= , > > at which point trying to check this using flags wouldn't work right. I > > think I might just stick with what I have here, at least for now. >=20 > But what if I set s_time_gran to 3 or 5? You'd really want a warning > about that. Ugh, I hadn't considered that. I don't see anyone that sets an odd s_time_gran that isn't 1, but OK, good point. I'll change it. --=20 Jeff Layton