From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670AFC28B28 for ; Thu, 13 Mar 2025 01:05:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA207280002; Wed, 12 Mar 2025 21:05:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5073280001; Wed, 12 Mar 2025 21:05:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D18AD280002; Wed, 12 Mar 2025 21:05:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B4A6F280001 for ; Wed, 12 Mar 2025 21:05:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6EF0E12178F for ; Thu, 13 Mar 2025 01:05:28 +0000 (UTC) X-FDA: 83214734736.28.27EB271 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf29.hostedemail.com (Postfix) with ESMTP id 18D98120008 for ; Thu, 13 Mar 2025 01:05:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741827926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VdCmrvZUEzlkQf5Jp+8Vt21F/7kOPID7wyg11kJjAQ8=; b=AFANcX3liq+ZvONPLqAx4t1GTx2zVleNy7ydEGGQBjlZmQRoP9zgS/QT8TSEhwNuOdZpzn icRGOmMRy1Ww23QtUmSU3wYzOSe9WgD8XWjjb7iey2lWo7gZQhsaB8AkAIZ/22ChRlQjHE X4moQ2DFTIkAEY1ZRGL5UB3EZDR8VQw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741827926; a=rsa-sha256; cv=none; b=Lg+MoRJJYqMQCGem0/H4NIvnXG+SrT/p0CJG0KK6hFvllILHX6gnfZJoSRZhtjNBm6MlnW qa2dGm5CNp2A4fR+YxxITx3fjqhr9dOH2jONrqsm0j7eOYVztodPbpK3YLROufNqROvMoh 5ix/tI+1BCdZTl21GU23iMgObcFh4hU= X-UUID: 39e1e5f2ffa711efa216b1d71e6e1362-20250313 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:bbd193c5-dadb-49de-b249-730427404302,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6493067,CLOUDID:ca730cb57221af9a06bb235bb51d9a23,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:80|81|82|83|102,TC:nil,Content:0|52,EDM: -3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0, AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 39e1e5f2ffa711efa216b1d71e6e1362-20250313 Received: from node2.com.cn [(10.44.16.197)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 1052669869; Thu, 13 Mar 2025 09:05:16 +0800 Received: from node2.com.cn (localhost [127.0.0.1]) by node2.com.cn (NSMail) with SMTP id 826CCB804E8F; Thu, 13 Mar 2025 09:05:16 +0800 (CST) X-ns-mid: postfix-67D22F4C-402505127 Received: from [172.30.70.73] (unknown [172.30.70.73]) by node2.com.cn (NSMail) with ESMTPA id 7840DB80758A; Thu, 13 Mar 2025 01:05:15 +0000 (UTC) Message-ID: Date: Thu, 13 Mar 2025 09:04:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/debug: Fix minor issues in mm To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250312032344.297946-1-liuye@kylinos.cn> Content-Language: en-US From: liuye In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 18D98120008 X-Rspamd-Server: rspam03 X-Stat-Signature: fqow19je5csnhw43pe6sfy53urqekdhm X-HE-Tag: 1741827924-89017 X-HE-Meta: U2FsdGVkX1+r8MTB7uObYHjKprSMWTQXPpP+Maw1XuxoXsHoqFlm87842ByxmtHCjeNZc2vkxgzBFyUR4lSDw+MaTKO2O5E4qfgrXM8Z4mC4kpgX6b5iRtx+xzqo4OSy0CJt9KAIgXoD7mu6vZ4ZIosekGqkcvSpgPObvqJ1aC5c250ySwHrjaXndAS5kL/lwqcb/reFUg1SixuVMNzadFbSrmi9Tmrfsu+SDLHCGk4HNA8hFnU+xXxZFOiE5utvOcQ69OAmNPLJwnJB1zYXeIE5So0hpLyrM48DHYJohLNuDtVD9t8VcdtYo9T2T9P83ehSS90Bz0hm83+T0bzNc1TXpF9YN9HzYh/zYISTE/9fYlgRqmG91x/pFZh4Rt5zPW6MErULWarn0urMv6YmzjO4VwFwjBafB6oqd+W/DT2bys5Q/9M+lLcQq8talecETn9cGMZdQTRMSsU+a/spStYiXZY2E8aHbPPkS0yqxcOVz4WMkphwU9FypKDOhuR56J88oVDDp/kqB0ysRsIfg6AVrg604uIYuqKsjaARJoaGkAIrZcyxmQ5KkQmOGzGrXUYlfS63K36FhiqS2q54AhbuyG6vyuJztCOBTgn5ejVapkqzQB1cyiTz0HabgLnz7vYd0SxwYLFpDiTO36+a3IhOZqq5K8xtllA8w/slnQofFMKAzv0ddi8eJMMYYjAOS4rLAvVtxrkN2DgpNpxeigC+SqTTr0ygCxLTNIoP/tQW+H+/wrxZ7eAz/SPtsd/WOSJBYoK896O3lFYUYAjka0fmqVZ+P0t1/6H4nGFt0pvqyIv/8yjVTYIB9fldbNHPktemkTR4Nf3edHtpPvjw8CEMpk1Xa+ESKvI+//PxoAM5C49lU13VQQNtZdstIxU0hoAIUEZWwCAErls2lVcqEc519bqdzhcTPpJ7ssJLJXTkVrade6qtepawcvAQch2pC7RPAdjK6/pbgc3Zjs6 2zxi0LRw A+TC+YQSZnYoeX48vqYdtjMloitsgFcsmBmpJTrQOET6zTPndi3qJJ7vfkAX5N4PRM+Nz/pLZAZfcB0aRaw2ghM3NJd5acsrS1QtOZ6Vs6n4kKJBEZtKQam7K/P5iH/tpV1Gi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: =E5=9C=A8 2025/3/12 20:20, Matthew Wilcox =E5=86=99=E9=81=93: >> - if ((head & 1) =3D=3D 0) { >> + if (head & 1) { >> + foliop =3D (struct folio *)(head - 1); >> + idx =3D folio_page_idx(foliop, page); >> + } else { >> foliop =3D (struct folio *)&precise; >> idx =3D 0; >> if (!folio_test_large(foliop)) >> goto dump; >> foliop =3D (struct folio *)page; >> - } else { >> - foliop =3D (struct folio *)(head - 1); >> - idx =3D folio_page_idx(foliop, page); >> } >> =20 >> if (idx < MAX_FOLIO_NR_PAGES) { >=20 > How is this "simpler"? It seems like churn for the sake of churn. > NACK. This modification simplifies the condition check by directly testing=20 head & 1 instead of using ((head & 1) =3D=3D 0). The updated logic first = handles the case where head & 1 is set, assigning foliop and idx accordingly.=20 This improves code readability and reduces unnecessary branching,=20 making the structure more straightforward and easier to maintain. I am personally accustomed to this format, but if it is not accepted=20 by the majority, then drop it. Thanks, Liu Ye =20