linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Next <linux-next@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH] selftests/vm: fix: make check_config.sh executable
Date: Fri, 2 Oct 2020 00:35:54 -0700	[thread overview]
Message-ID: <fa388abf-c6b6-f975-959c-6bc1be03f026@nvidia.com> (raw)
In-Reply-To: <20201002064811.435769-1-jhubbard@nvidia.com>

On 10/1/20 11:48 PM, John Hubbard wrote:
> commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs
> dependency") created the new check_config.sh file without the execute
> bits set. This is a problem because the Makefile runs it with "./", so
> now "make" is failing in that directory.
> 
> The posted patch [1] does seem to have it as an executable file, so I'm
> not sure how this happened. But in any case, make check_config.sh
> executable again, so that "make" in selftests/vm works once again.
> 
> [1] https://lore.kernel.org/linux-doc/20200929212747.251804-9-jhubbard@nvidia.com/
> 
> Fixes: commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs dependency")
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> 
> Hi,
> 
> This applies to today's 20201001) linux-next. I forgot if this needs to
> be a separate patch or if it can be fixed up in Andrew's tree.
> 

hmm, in fact I think something similar also happened to run_vmtest.sh, in the same
directory. Please let me know if a patch is needed there, or if you can just fix
up this one or the tree or something?

> thanks,
> John Hubbard
> NVIDIA
> 
> 
>   tools/testing/selftests/vm/check_config.sh | 0
>   1 file changed, 0 insertions(+), 0 deletions(-)
>   mode change 100644 => 100755 tools/testing/selftests/vm/check_config.sh
> 
> diff --git a/tools/testing/selftests/vm/check_config.sh b/tools/testing/selftests/vm/check_config.sh
> old mode 100644
> new mode 100755
> 

thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2020-10-02  7:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02  6:48 John Hubbard
2020-10-02  7:35 ` John Hubbard [this message]
2020-10-02  7:59 ` Stephen Rothwell
2020-10-02  8:10   ` John Hubbard
2020-10-02  8:23     ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa388abf-c6b6-f975-959c-6bc1be03f026@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox