From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49A0C77B7F for ; Mon, 8 May 2023 22:46:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 181DD900005; Mon, 8 May 2023 18:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10BA1900002; Mon, 8 May 2023 18:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC745900005; Mon, 8 May 2023 18:46:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DB705900002 for ; Mon, 8 May 2023 18:46:17 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E9711C6BFF for ; Mon, 8 May 2023 22:46:17 +0000 (UTC) X-FDA: 80768572794.19.835BD4C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 73D471C0004 for ; Mon, 8 May 2023 22:46:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ieP/Qv6y"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683585974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lD3YOAKvyxUhdHfZBJC1/c6hdLDImjbDSqv1KoUP1mg=; b=JM3xacyqLZ2spMMczTPAF09IFtNGVcgPkXfw3dfiIkh6ZiU3L8o2oVfyJ+/bZRTHagw97c IaE8hmYIBWpImxSkmzrmFeFTMn0WcmmtzJ4a1fqrolmNSGP7AwaiNLZMLMvp6zomfK1LXN AT1LpJgkhAyw381PAidF3swKSPFjtcc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ieP/Qv6y"; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683585974; a=rsa-sha256; cv=none; b=HZP7+S2Klkxvi3NpP2Izp10B44KnX2gXxJ1A0tqLLJbSg8pdWsPLzzqSRps6FQ1QO2urYW l6mzBpy9f+OQpI/nTQR/tlBKWitRpel33rXKHUV8eTGy7Xv9YOmWrL55/C0GOBvFUbL3ZN ga58bkKTZDnE8tCoZHcQyfXRJbZPMas= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683585973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lD3YOAKvyxUhdHfZBJC1/c6hdLDImjbDSqv1KoUP1mg=; b=ieP/Qv6ywtJ/smSrTQtvFuCoAQtYi4+6hn2WXnGNq64d/oAySZMyZAtOwAXOctexgpyHKi ZiKlbM5OeyN2m+jrVsjIR/dY2b1ITvvZZWjoIipdH3N+NYW0uTWW6Q9oX+nQL7tdjOzQhg fLt6CzqLAwV0FJJ+1gULBKHwJj1RjJA= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-o9qzy3l0P12Dh3K7LjPWAA-1; Mon, 08 May 2023 18:46:10 -0400 X-MC-Unique: o9qzy3l0P12Dh3K7LjPWAA-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-25014b171a4so4826140a91.1 for ; Mon, 08 May 2023 15:46:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683585969; x=1686177969; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lD3YOAKvyxUhdHfZBJC1/c6hdLDImjbDSqv1KoUP1mg=; b=mChr4GqCBtl4K/Ex+mxzyEkOFX+KSloWv8XdEktA5kGTzM+LXIDe+tFFodpDpmXGP/ lRqrkLAQlQtkhYy1MB3dMYcqOOvXcIywcUX+xo/lDMY11OquHOiBBtF5fJ2JurGYK3fL HGbp5o17HRzfJHB2K1U5wD7twDTb4ria+oEM8Fg1ZMsUMKNbImwAipSu0Aj8+6h79DGL hJbB7GKs6GepiLS/C123AFiW1wr3phLmQwTuWAn+P/RXTgT6LhAFpiCQBZddBWVg33Jd Lk03incDkpi3N1BL8OEnmkEYg/z1Rdvx+xZjN+88B3g1grOymxyJE7NIWv2YJ0vxSDsF 6IDA== X-Gm-Message-State: AC+VfDw8vcvdugvr509YYZ6jpDyBKdDhfmyFfmKyu/74uild4t5hsDFj 5aJLRIW1FYiYgA0J1HtbBOZD5V6okkxSkb3H6pNvFeWUksh2NMFaSongPW/CVFV/TUlNKguXRaE MYX23BVq9IUY= X-Received: by 2002:a17:90a:fa5:b0:24d:f992:5286 with SMTP id 34-20020a17090a0fa500b0024df9925286mr286434pjz.36.1683585969506; Mon, 08 May 2023 15:46:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7FnOfreW+z3AaX729z6qwlAR8QXG4aIw5/xthNT3a/mfFk5Hic2Nt7MMEQFGP+gNNHLW2T8Q== X-Received: by 2002:a17:90a:fa5:b0:24d:f992:5286 with SMTP id 34-20020a17090a0fa500b0024df9925286mr286418pjz.36.1683585969158; Mon, 08 May 2023 15:46:09 -0700 (PDT) Received: from ?IPV6:2001:4958:15a0:30:5835:5bd3:f0c8:e5ef? ([2001:4958:15a0:30:5835:5bd3:f0c8:e5ef]) by smtp.gmail.com with ESMTPSA id a1-20020a17090acb8100b0024e2980574asm10500510pju.4.2023.05.08.15.46.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 15:46:08 -0700 (PDT) Message-ID: Date: Tue, 9 May 2023 00:46:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: usbdev_mmap causes type confusion in page_table_check To: Pasha Tatashin , Matthew Wilcox Cc: Ruihan Li , syzbot+fcf1a817ceb50935ce99@syzkaller.appspotmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000258e5e05fae79fc1@google.com> <20230507135844.1231056-1-lrh2000@pku.edu.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 73D471C0004 X-Stat-Signature: jap8mbua7tzqwcttguhgfxigep311qg9 X-HE-Tag: 1683585974-556702 X-HE-Meta: U2FsdGVkX19ni85HxRFTlJxCrXDkoqKRFdnQAtNoWAfb5ipyKISdtiSwVEPH+qjvxx9E758iVuREWNY083SMhvAzxCuC9yULu6/Gr/PyLCbeahCdweNjdR/b1voIwpZzhrpx/T8InR/rtwSeBtTn8aStGpx18PyZpQ6L9FANIEpD+hSaHde7CP3oWa8yn5uSley5V6Vfmiu/GmGLq7f2BGlNKxbX1OHvNUbtQqMzJrQ8dm2r31NzAPm1QWh6Ol0zNkAUyGa0jrXgvN9EqquXwjbzxYSuJGsqusUIrtjv8Ovn/Oeapn/3XL/4ewTVtAlGpSMHXeGnwAJwJ998Yd4wNVDrM7hd+wS+sU5DisDFksthecv1YivYEvm8sb0i/cFmP67J9apRHMy74rDPrVObsHqQcyETYl+eDy7DOqPl9e1b/WLZCeDYGXEoYq4oqERXCg0HVvRTRIEap7mvmdJlxxhbclAAtYohrc35hChk2uWjatEAh+/wB3rhtiBivOR5rKB+QLVZeGLOgMk332NaXOWzi9XrPPfijpwDhTQ1DFYux97HzgHDPwtLjBoFPv73d+WYBynjL7vlF4JAKOfDC4Sgx/AqTaNo5gceCGHWR53Q8EBKCH7lPIdxG+XgyXS4okXNX7PH9tFgNts1OT0Tx7hgcD5aL7vYaU00CZrUCkADl6EgVxsnXuB8CMXGugSaVmSSh35jMo/XqZqz8rgi1RmZGnr5dgXqz27DGcVkMzjDIYDuiAvR4juUNEDJ6HlSRfTGp/mme6aItm9/aFLNM92o7mfG/vR4BoS8B2j4QzI2wxH0aeu0HI9MtXK+6rqTdgoGK2Rvg0c7ZTYc2z5PW613dyeQ4hL6hIsqcHnyRdrVBBgpkmpAfTzXcyXvGLKXq6AktiS3VXQ5km5iBkdNA4YKgaFmlkfxyBva1+dge/Dk3+Ww5JOdrj4N9wCVW+/ly8CTj+4Ziu2m/aFE1ww 1GxMNgiN ep2AMt1xz9U53gtcyxnWXesASRSOD/fRacNFFQ+gbo+Uqe/dTMVwuaEHP8uOHfvzidX8H0EiVg1OVcjetjwc/Jt02kSfM0D6i7HjxDJY02QMotXV1yJRSNw7w4dHr6YOfatJ+/yJ1KfXxR419e7I2E1kblWwr/41YF87RrXqoWrD7JcQJiGMpVWfoUUOyZfJZk628XvgpxCivQnQwpJeKe7ncYpInAKYUvFL85vsIOQ7upnVpYjRW6KnSyMAWV/MY2SV7EpeK0F3DX2mYlUQX1yrAkmEWAUZsbRf60/dFHLOcnerNulF72ic2GQzT/xxPiXuFkjWqKWiebCj/Nt5Lu1sy21/XD/6+iIHhBmU2lpPMaxtdcaz6fkTq0G9iaAR0hzP93qzhIAlomFbK2XB4cNUllZMzSWTeLiMMJYBH/31GWZ+2ZAuUrg1iuj//UIetNYMQxLf7lnwvIfwNrYJKAOxMd6rYnQoIJ9qWiI/Q04hTMrhHnLX6j3PX8+tekL+j2lfc6wQvJMo+VbhUCoXDB4LprBcpGrDqCfpKzFdpqJrO/4+u/WFdJz5bGgxFg5dWz33UTwsyY6eRcX8u515JTZkNmtcWMEv38/Q0SRvvgl9LXno= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.05.23 23:55, Pasha Tatashin wrote: > On Mon, May 8, 2023 at 2:52 PM Matthew Wilcox wrote: >> >> On Mon, May 08, 2023 at 02:48:59PM -0700, Pasha Tatashin wrote: >>> On Mon, May 8, 2023 at 2:36 PM Matthew Wilcox wrote: >>>> >>>> On Mon, May 08, 2023 at 05:27:10PM -0400, Pasha Tatashin wrote: >>>>>> static void page_table_check_set(struct mm_struct *mm, unsigned long addr, >>>>>> unsigned long pfn, unsigned long pgcnt, >>>>>> bool rw) >>>>>> { >>>>>> // ... >>>>>> anon = PageAnon(page); >>>>>> for (i = 0; i < pgcnt; i++) { >>>>>> // ... >>>>>> if (anon) { >>>>>> BUG_ON(atomic_read(&ptc->file_map_count)); >>>>>> BUG_ON(atomic_inc_return(&ptc->anon_map_count) > 1 && rw); >>>>>> } else { >>>>>> BUG_ON(atomic_read(&ptc->anon_map_count)); >>>>>> BUG_ON(atomic_inc_return(&ptc->file_map_count) < 0); >>>>>> } >>>>>> // ... >>>>>> } >>>>>> // ... >>>>>> } >>>>>> >>>>>> This call to PageAnon is invalid for slab pages because slab reuses the bits >>>>>> in struct page/folio to store its internal states, and the anonymity bit only >>>>>> exists in struct page/folio. As a result, the counters are incorrectly updated >>>>>> and checked in page_table_check_set and page_table_check_clear, leading to the >>>>>> bug being raised. >>>>> >>>>> We should change anon boolean to be: >>>>> >>>>> anon = !PageSlab(page) && PageAnon(page); >>>> >>>> No. Slab pages are not elegible for mapping into userspace. That's >>> >>> Sure, I can add BUG_ON(PageSlab(page)); to page_table_check_set. >>> >>>> all. There should be a BUG() for that. And I do mean BUG(), not >>>> "return error to user". Something has gone horribly wrong, and it's >>>> time to crash. >>> >>> It is just too easy to make slab available via remap_pfn_range(), but >>> I do not think we want to add BUG() into the remap function, otherwise >>> we will break devices such as /dev/mem. >> >> Slab pages can't be mmaped. Really, no matter what interface you're >> using. page->_mapcount is necessarily incremented by mapping to >> userspace, and slab uses that space for its own purposes (and has >> for decades). It's similar for page tables and other allocations that >> use PageType. > > Mapping random memory in /dev/mem can cause mapping slab pages in to > userspace, the page->_mapcount is not incremented (and other fields > are not accessed) in that case, as we are using VM_PFNMAP type VMA, > which does not access "struct page". We should be using vm_normal_page() to identify if we should be looking at the struct page or not, no? -- Thanks, David / dhildenb