From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6867FC43334 for ; Mon, 13 Jun 2022 11:55:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1FEF8D017F; Mon, 13 Jun 2022 07:55:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCF278D0171; Mon, 13 Jun 2022 07:55:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B96878D017F; Mon, 13 Jun 2022 07:55:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A95EB8D0171 for ; Mon, 13 Jun 2022 07:55:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7945D3507A for ; Mon, 13 Jun 2022 11:55:07 +0000 (UTC) X-FDA: 79573056654.30.0B54205 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf28.hostedemail.com (Postfix) with ESMTP id D93FBC000A for ; Mon, 13 Jun 2022 11:55:00 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LM91S5pwBz1K9RY; Mon, 13 Jun 2022 19:53:00 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 13 Jun 2022 19:54:56 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 13 Jun 2022 19:54:54 +0800 Message-ID: Date: Mon, 13 Jun 2022 19:54:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 6/6] memblock: Disable mirror feature if kernelcore is not specified Content-Language: en-US To: Ard Biesheuvel , Mike Rapoport CC: Wupeng Ma , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20220613082147.183145-1-mawupeng1@huawei.com> <20220613082147.183145-7-mawupeng1@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655121301; a=rsa-sha256; cv=none; b=lqrhhPxQIDT0aRfnW2e4UXmA7LRN8YasZKCuBQ6RBmZmfzCd6hoyMxoP2TfKJllsJ4nsCb F6gri1ZGVmS+LRADJc/OXjiq7Gg6yx2q0N8KSbPXkeXMdaFZniDUaBMnhU9Vg2gH8soddn Bh0SFUXBgchWdVp9ePru1jEEho0ZjVQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655121301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rpxyp+2Q2iQeRCPu0PWApWgY5T9qDkWus5Aybv4QV1o=; b=Eu9mUlYGhXntcpojWHlvHGHJo66jCPCRKM2NgNRLFVUWzERq5hLYy71ZxrSsjoEESrdB37 YxcmFpQg7l7ii9cK50TXlbiXSOAm2l0RbTVYcdLVJSzxftsSxYZsCwrdY8cj1Cbg5tYofb AmYLZuNoM5fj5WbgopYS06VI6lmWzp0= X-Stat-Signature: b5hq3zdh5jgjrxuojijg9577w4iyoumy X-Rspam-User: X-Rspamd-Queue-Id: D93FBC000A X-Rspamd-Server: rspam07 Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-HE-Tag: 1655121300-193641 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/13 19:25, Ard Biesheuvel wrote: > On Mon, 13 Jun 2022 at 13:05, Mike Rapoport wrote: >> On Mon, Jun 13, 2022 at 04:21:47PM +0800, Wupeng Ma wrote: >>> From: Ma Wupeng >>> >>> If system have some mirrored memory and mirrored feature is not specified >>> in boot parameter, the basic mirrored feature will be enabled and this will >>> lead to the following situations: >>> >>> - memblock memory allocation prefers mirrored region. This may have some >>> unexpected influence on numa affinity. >>> >>> - contiguous memory will be split into several parts if parts of them >>> is mirrored memory via memblock_mark_mirror(). ... > Also, on second thought, I don't think marking as mirror is what > should be affected by the policy. Instead, choose_memblock_flags() > should take this into account, in a way that we could refine later if > needed. > . The choose_memblock_flags() only solve the issue of memblock allocation, but the memblock could be splitted and fragmentized, the kernel won't treat the mirror memory as special if no mirrored_kernelcore for now, so I think we'd better to add the check into memblock_mark_mirror().