From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Ard Biesheuvel <ardb@kernel.org>, Mike Rapoport <rppt@kernel.org>
Cc: Wupeng Ma <mawupeng1@huawei.com>, <corbet@lwn.net>,
<will@kernel.org>, <catalin.marinas@arm.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<anshuman.khandual@arm.com>, <thunder.leizhen@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <vijayb@linux.microsoft.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v4 6/6] memblock: Disable mirror feature if kernelcore is not specified
Date: Mon, 13 Jun 2022 19:54:53 +0800 [thread overview]
Message-ID: <fa1416be-f940-4c28-5c67-911e61ac024f@huawei.com> (raw)
In-Reply-To: <CAMj1kXGwOczo1bgftMX9xTf8fRkrVYq8BjXJ6=XPj_yarbDYrA@mail.gmail.com>
On 2022/6/13 19:25, Ard Biesheuvel wrote:
> On Mon, 13 Jun 2022 at 13:05, Mike Rapoport <rppt@kernel.org> wrote:
>> On Mon, Jun 13, 2022 at 04:21:47PM +0800, Wupeng Ma wrote:
>>> From: Ma Wupeng <mawupeng1@huawei.com>
>>>
>>> If system have some mirrored memory and mirrored feature is not specified
>>> in boot parameter, the basic mirrored feature will be enabled and this will
>>> lead to the following situations:
>>>
>>> - memblock memory allocation prefers mirrored region. This may have some
>>> unexpected influence on numa affinity.
>>>
>>> - contiguous memory will be split into several parts if parts of them
>>> is mirrored memory via memblock_mark_mirror().
...
> Also, on second thought, I don't think marking as mirror is what
> should be affected by the policy. Instead, choose_memblock_flags()
> should take this into account, in a way that we could refine later if
> needed.
> .
The choose_memblock_flags() only solve the issue of memblock allocation, but
the memblock could be splitted and fragmentized, the kernel won't treat the
mirror memory as special if no mirrored_kernelcore for now, so I think
we'd better
to add the check into memblock_mark_mirror().
prev parent reply other threads:[~2022-06-13 11:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 8:21 [PATCH v4 0/6] introduce mirrored memory support for arm64 Wupeng Ma
2022-06-13 8:21 ` [PATCH v4 1/6] efi: Make efi_find_mirror() public Wupeng Ma
2022-06-13 8:21 ` [PATCH v4 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges Wupeng Ma
2022-06-13 9:41 ` Ard Biesheuvel
2022-06-13 8:21 ` [PATCH v4 3/6] mm: Ratelimited mirrored memory related warning messages Wupeng Ma
2022-06-13 8:21 ` [PATCH v4 4/6] mm: Limit warning message in vmemmap_verify() to once Wupeng Ma
2022-06-13 11:03 ` David Hildenbrand
2022-06-13 8:21 ` [PATCH v4 5/6] mm: Only remove nomap flag for initrd Wupeng Ma
2022-06-13 9:42 ` Ard Biesheuvel
2022-06-13 10:50 ` mawupeng
2022-06-13 8:21 ` [PATCH v4 6/6] memblock: Disable mirror feature if kernelcore is not specified Wupeng Ma
2022-06-13 9:13 ` mawupeng
2022-06-13 9:44 ` Ard Biesheuvel
2022-06-13 11:05 ` Mike Rapoport
2022-06-13 11:25 ` Ard Biesheuvel
2022-06-13 11:54 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1416be-f940-4c28-5c67-911e61ac024f@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy@infradead.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dvhart@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mawupeng1@huawei.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vijayb@linux.microsoft.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox