From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1488C4338F for ; Fri, 23 Jul 2021 11:11:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C26060E75 for ; Fri, 23 Jul 2021 11:11:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C26060E75 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E98446B005D; Fri, 23 Jul 2021 07:11:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E46EC6B006C; Fri, 23 Jul 2021 07:11:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0E1F6B0070; Fri, 23 Jul 2021 07:11:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id BA8FB6B005D for ; Fri, 23 Jul 2021 07:11:03 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6F78622C00 for ; Fri, 23 Jul 2021 11:11:03 +0000 (UTC) X-FDA: 78393585606.34.E8B0B57 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 0B7EB1005589 for ; Fri, 23 Jul 2021 11:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627038662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G1IbpdoBanVv+55BsmPU96RSVm4RAh235zsiGQqev7Q=; b=cfEKSRhO2T8ycgZbL8YTOz/ATs+PXbbeOMl7tWnCfjwHfxBVKBGDJrf46Ny7Yopb1BlFVl +UlD+baUl3sAPpKckAddEwPIMJgVOUzAILUD89+1qrfvazsm9XPyygHNf2FBSaWDILzS1M o4JWoXTxhcBQDwjIzrMKU1OnyXEyV9I= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-45-XCwYawiwMwGSXBpQHI3veg-1; Fri, 23 Jul 2021 07:11:01 -0400 X-MC-Unique: XCwYawiwMwGSXBpQHI3veg-1 Received: by mail-wr1-f71.google.com with SMTP id r17-20020adfda510000b02901526f76d738so907400wrl.0 for ; Fri, 23 Jul 2021 04:11:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G1IbpdoBanVv+55BsmPU96RSVm4RAh235zsiGQqev7Q=; b=YsfCSZa1E+QUpngnfE8Sw8vIh7RTNtv/ZDnGvwzXWXLl8JPiXLN+weIEafLegum2Z9 s5k6ZW4FObHN03qPvufvBmoNYMIAQhetQlD4YBZeKf4jGjBbC7sJrbD2MM6+ELUEg6A7 4lgyr5Fw9d12XHwFnL0u96NKBffQSUlNbKBORTC46S9HT5//UHnYh2iKe8PrmVA33Am2 acO9DN0igDtflol8cCRLuADcXUekVDSn0LCZU2gHsHexq21nkOnt/gAL/IkvLH76IxGC G6s9gbY9fp3dsAAslMX1ds29KXQwnDBn1BWrvnlhESACk3Cw00dtDuU8GH2xWeFuZ38H OW7g== X-Gm-Message-State: AOAM532vKO4P+yr+Cl0PmvtT1c2eo+PpnnrJ4fc2rZBR5+1N/eUOaFnS zk6mhfkUkChjy3iVNj3rPen4ewEzg2Zt19I2ClvOXgy2QBzKQqetBfthc5rWPpkPQw7dwSbD2Sl xhqGhoh4mhag= X-Received: by 2002:a1c:a709:: with SMTP id q9mr13456356wme.23.1627038659896; Fri, 23 Jul 2021 04:10:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUcdi6qHZiPRl09NrK7l/BF1ixG4/TVNsxh9PxInN/mhKZtGyFGZDWScCkKjkehy42GwCdgA== X-Received: by 2002:a1c:a709:: with SMTP id q9mr13456325wme.23.1627038659656; Fri, 23 Jul 2021 04:10:59 -0700 (PDT) Received: from [192.168.3.132] (p5b0c676e.dip0.t-ipconnect.de. [91.12.103.110]) by smtp.gmail.com with ESMTPSA id t5sm33068215wrw.38.2021.07.23.04.10.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 04:10:59 -0700 (PDT) Subject: Re: [PATCH] mm,shmem: Fix a typo in shmem_swapin_page() To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Miaohe Lin , Hugh Dickins , Johannes Weiner , Michal Hocko , Joonsoo Kim , Matthew Wilcox , Minchan Kim References: <20210723080000.93953-1-ying.huang@intel.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 23 Jul 2021 13:10:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210723080000.93953-1-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0B7EB1005589 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cfEKSRhO; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: cr1w3j8shc94hhzefhqn4k1rt3po7w94 X-HE-Tag: 1627038662-937307 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.07.21 10:00, Huang Ying wrote: > "-" is missing before "EINVAL". > Ehm, that's not a typo, that's a real BUG. What are the symptoms? -- Thanks, David / dhildenb