From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FA0C433F5 for ; Tue, 11 Jan 2022 18:44:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA24F6B00AA; Tue, 11 Jan 2022 13:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B51306B00AB; Tue, 11 Jan 2022 13:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19436B00AC; Tue, 11 Jan 2022 13:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 927E66B00AA for ; Tue, 11 Jan 2022 13:44:26 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 52FE718024AC1 for ; Tue, 11 Jan 2022 18:44:26 +0000 (UTC) X-FDA: 79018881732.04.A418B36 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf12.hostedemail.com (Postfix) with ESMTP id BB5134000F for ; Tue, 11 Jan 2022 18:44:25 +0000 (UTC) Received: by mail-il1-f169.google.com with SMTP id f4so6868865ilr.9 for ; Tue, 11 Jan 2022 10:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:subject:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=tFQdNQtIewtBRmToXsBxMfMj4p5l4AEslzFqKCLLZoo=; b=GdEjlM8FyzZ4u7cfUSmXq9/e8NZxUgid+VOT/R6BIHZ5aD7SFRsoNjIpkQaFGbcG8j 19fy/aHOQ0207AUuCGfdVh9WnvoV15WvgHQ5kbLmY1GF6ohyIxKSVKYoNrw9yMkYZQvK B5Rr8jAOLYajqR8P6y6mDbDT7FtPCd7Klqo52FNrNvOodGHJ89nJnEdPZdFN2iK7Bgyd JwvZQ907iFM0gO9kh//euTlVC5zoELSyW+vRET2zt/VXeD8JlB/R/3almX44YnAxV4mU psuy8QJjYKcfPyBrx5wEYe93qU0nBZLt5PmidG3ScCW2LZ/+CYpTHfKsssHS12ZgoQK9 B9GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:subject:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=tFQdNQtIewtBRmToXsBxMfMj4p5l4AEslzFqKCLLZoo=; b=DXjOx90nr9eavJ4p4f3bOVyR8ThXZowhtZj1dfS5vVQ20ayxBfvE3sKTWdcNEpbn0M lfrJQ0w3685AaLFlO8iM8IS2qgYK9x5QCm1LCPPYwp6x8k1cM8UazZRenKRSEaK6WOId 7q6wdwHQq5NmZtTET/vsRVma5UMA/Q5lBkdYmFiOJGbbtne+2WbtC212Hxifisj4FFYS tFr0ujDOVrNoYNNMMJlT3ULEImk9ZzJ/A08p8UDo7thXI0ho3dQXufGlsTdRgbWSeANr xfk8J6Eg376vldJOwe33DApIpg2OpQ1sNAXg8YXEtzvqgvFyWBR7NIRFNlLY39bHBNxF RkAg== X-Gm-Message-State: AOAM5333vfhclIO7PEa9+QDiX6LB1GNshuVffJxJTvbzIKCsjN6kjv8i lms+faZWz66A1FdBdYRHvsc= X-Google-Smtp-Source: ABdhPJycIt+kcebpXTE6Q4i4yJqb8HjKebhXN8no1tlBBpnhYCUis/oMlIg+OSiYmNDyhc95tlcGyw== X-Received: by 2002:a05:6e02:1aad:: with SMTP id l13mr3290017ilv.4.1641926664781; Tue, 11 Jan 2022 10:44:24 -0800 (PST) Received: from lat7420.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.googlemail.com with ESMTPSA id d11sm6381489ilv.6.2022.01.11.10.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 10:44:24 -0800 (PST) From: Khalid Aziz X-Google-Original-From: Khalid Aziz Message-ID: Subject: Re: [PATCH] mm/pgtable: define pte_index so that preprocessor could recognize it To: Mike Rapoport , Andrew Morton Cc: Christian Dietrich , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Tue, 11 Jan 2022 11:44:23 -0700 In-Reply-To: <20220111145457.20748-1-rppt@kernel.org> References: <20220111145457.20748-1-rppt@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4-1 MIME-Version: 1.0 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BB5134000F X-Stat-Signature: 4d6nz6wbyrkfgr3cxpk4qw6jyw4p1ykr Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GdEjlM8F; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of gonehacking@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=gonehacking@gmail.com X-HE-Tag: 1641926665-347404 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000484, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2022-01-11 at 16:54 +0200, Mike Rapoport wrote: > From: Mike Rapoport >=20 > Since commit 974b9b2c68f3 ("mm: consolidate pte_index() and > pte_offset_*() > definitions") pte_index is a static inline and there is no define for > it > that can be recognized by the preprocessor. As the result, > vm_insert_pages() uses slower loop over vm_insert_page() instead of > insert_pages() that amortizes the cost of spinlock operations when > inserting multiple pages. >=20 > Fixes: 974b9b2c68f3 ("mm: consolidate pte_index() and pte_offset_*() > definitions") > Reported-by: Christian Dietrich > Signed-off-by: Mike Rapoport > Cc: stable@vger.kernel.org > --- > =C2=A0include/linux/pgtable.h | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index e24d2c992b11..d468efcf48f4 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -62,6 +62,7 @@ static inline unsigned long pte_index(unsigned long > address) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return (address >> PAGE= _SHIFT) & (PTRS_PER_PTE - 1); > =C2=A0} > +#define pte_index pte_index > =C2=A0 > =C2=A0#ifndef pmd_index > =C2=A0static inline unsigned long pmd_index(unsigned long address) >=20 > base-commit: 2585cf9dfaaddf00b069673f27bb3f8530e2039c This is a good fix with positive performance impact. Reviewed-by: Khalid Aziz