From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EBBFC54EAA for ; Fri, 27 Jan 2023 16:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0122C6B0075; Fri, 27 Jan 2023 11:24:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F04436B0078; Fri, 27 Jan 2023 11:24:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF3796B007B; Fri, 27 Jan 2023 11:24:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D0CAD6B0075 for ; Fri, 27 Jan 2023 11:24:06 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A074140FDB for ; Fri, 27 Jan 2023 16:24:06 +0000 (UTC) X-FDA: 80401100892.06.5AC1172 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 6280640012 for ; Fri, 27 Jan 2023 16:24:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QF2A4LeB; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674836644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rBcfIHEg4jZbTQIImkzkLN9g2iVk6db6jthiIxejuwA=; b=TPCQLDJtaThyfl9wyhmf4X8NWsXwIFM2QKWgNv6+T2fnFBk5wKLdqxXT0U01koeN7eKTSc dwDCK6TGp+CswWY0hm7af3rwwpZ5gvmkUQKZ7rlPPTLPIqyBiOyYCIGs3zPMXR/th7jaue kGusSlfqr+BOyuIwSDsgv2OLmIGwKf4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QF2A4LeB; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674836644; a=rsa-sha256; cv=none; b=A/rQ49MIf2iwWDVBzhdovOrCTHrMsawaFHRpuStEswZWnAV3/6ty5T0POYw7EkaXJAk8Sz 5jJMR7+dOpnjNYULmES7SqnTmBkVj1JKbZb7iWpYpVvd64CvP7PlbP8OEDiVWL27CeCXE1 ngNpMvrKKgBiZwj9djHTG0qABPTqIIk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674836643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rBcfIHEg4jZbTQIImkzkLN9g2iVk6db6jthiIxejuwA=; b=QF2A4LeBPwX65noixYO8JgYWTPdysstjERrxpemwJYwjzlWMxlvBL7TT87e8jpOLS7VqU7 qYKFmSIZvrGHdhbkJ13srv7omBT8UaVLFHnibnqnpLV4LqRCRE+W1Nd4CAvnud0PFGJLuy JgNRVyDK4NcRypbf8KvzfFd4jRSWwN8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-357-C4UmT0WQOyKoB3NYcrt6PQ-1; Fri, 27 Jan 2023 11:24:02 -0500 X-MC-Unique: C4UmT0WQOyKoB3NYcrt6PQ-1 Received: by mail-wm1-f70.google.com with SMTP id m15-20020a05600c3b0f00b003dc37d0e995so1296655wms.4 for ; Fri, 27 Jan 2023 08:24:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rBcfIHEg4jZbTQIImkzkLN9g2iVk6db6jthiIxejuwA=; b=gX79wqyH2ALewqho5QWuU6IhriO8WiUKWNppp4pSYW7/CbVD8g98QhuC0+4iK5Yp4w Ig0RaFfndTKLoO3I5viv5luc7c2Ag1VP3ZH245PPbXV0Nr2QYCYqyf+HlAT5lHHxBd8G HvGphBO0udNqWp9sFFpgCTzrMDJRHs19/vUCGQYSAkfAlF5272JKEjcfylI35XoFY7nk D4TO0sjxJln+heqhVdKi2i2m/Ysk6OrgFpwuCnaVWzZI6GL+f6GYeINPgeBkU5Pd8gd7 cSY1ZlrOa9t5aX2vWlEyjKlNqnfvQCdd6Q240h1ZCO+MLbIfth9GfE1KaNlwtOGbYp0S Q8NA== X-Gm-Message-State: AO0yUKUjyIhuje4XX3OqLYs4bK2/DVAztW+iPULPfEos2l/I5VtetGLr 8vh8D4O2JvBo2JlF18RX7IFk8jrF7IkfxsnsaFxGFm5nMdxAPcogIjh7IPENtiU6aSy9Q0CTvGz Xh36m0vpPaSk= X-Received: by 2002:a5d:5588:0:b0:2bf:cfb4:2e2 with SMTP id i8-20020a5d5588000000b002bfcfb402e2mr3530695wrv.17.1674836641199; Fri, 27 Jan 2023 08:24:01 -0800 (PST) X-Google-Smtp-Source: AK7set/Y+LNaZDyABiiOmf5N54VfZvfoeUt9bSW+AQh4dtqSkfuGAZY0DclafN1Se1z2VO+XUxpTjQ== X-Received: by 2002:a5d:5588:0:b0:2bf:cfb4:2e2 with SMTP id i8-20020a5d5588000000b002bfcfb402e2mr3530671wrv.17.1674836640968; Fri, 27 Jan 2023 08:24:00 -0800 (PST) Received: from ?IPV6:2003:d8:2f16:1800:a9b4:1776:c5d9:1d9a? (p200300d82f161800a9b41776c5d91d9a.dip0.t-ipconnect.de. [2003:d8:2f16:1800:a9b4:1776:c5d9:1d9a]) by smtp.gmail.com with ESMTPSA id z14-20020a5d640e000000b002bfb5bda59asm4467446wru.25.2023.01.27.08.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 08:24:00 -0800 (PST) Message-ID: Date: Fri, 27 Jan 2023 17:23:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] migrate: hugetlb: Check for hugetlb shared PMD in node migration To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Naoya Horiguchi , James Houghton , Peter Xu , Michal Hocko , Yang Shi , Vishal Moola , Matthew Wilcox , Muchun Song , Andrew Morton , stable@vger.kernel.org References: <20230126222721.222195-1-mike.kravetz@oracle.com> <20230126222721.222195-3-mike.kravetz@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230126222721.222195-3-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6280640012 X-Stat-Signature: sc3uq4osx4cz7qxoc1z7drrcpt9ia7qh X-HE-Tag: 1674836644-400719 X-HE-Meta: U2FsdGVkX192+kIqfVw8CYsZZM7GaQ62mOHvo/b0FU2oQZ9a5UyVBTcvQpyMZQofs+2i5Wv6cZ+DCte2stEf8cue0hMz7a6azMjU41MsqGaaCIE500DPqop+qgFmiiRYynW/xEjSgvUfP00XyqGy79dKcCQbjCGPMrMQksL5uaCXA/xzfXUeXcLiqoHbiqovolMyrRlalRYoSnx/oTtjMg4RQPx00YguDRwdkpcUzcufX5JkWpQcT+6Q1083zIosDVMt0uKnah8b+8ZbyoMblbZNwWfaem1nUyst4H797y1NDsyMGE7EzOWVnfTgVSSosAvurwqGVk1f+zTV3yuXR9ouDOP0nIIA/oQ+NqVeKCEfCwP6l4VaJsXgnHAFmbr3l+6xkZh27yHjADQGbxR1WgmeQCRbGrQRrJ1QhCz0JhfwIJS6iWjAEHaLR1KlNyIjZCnpVIEkcRrG8Fo2ghIhb7SxUxkQRLcyZxz3XxIR8zYmNeianJInZlnMVm3VuHeqKPOwz9tJhpBi95PZaw6MssyeBw9Rr2pB9q1LiTy0mrcJqJPRBzWG0inkDBNrLjtGdsg+DQjZXXwr9hioKNjxqR23Z9UmnnNjKR03xqJOOT+uWlTKa+tcSAOnyfHiPQZ8n1tfihLoZ3HCPjicwMuFSUOLgnO1xpso6OfdmJSm9w49yvjoWd/GmYW0XVt+bsjFXX6v6RywN+lERGfIbr/qzyXyKBG3SQFcTe/ylFBRqdJnGx5r90J3y62MzMyvbeJS+gAYGfwgp8oOKz2xJIjzgUFvRtp5H5HLAHllwQXQvB6NclIJPJXZCcqlL8ytc/ovCV6MRLCpThYBrPvTq9JFjs+d8KWP2+cIpuZRqcTYzPDH7jhgEHIALZgs8R44IK0TlAcXeH88aAn2BeR1Xg3Jvs59wLrXB8XGc5zHngSkc0txI8PilFt/8i4LSyJO/umcW8twRusYfacuiikCjgT xCy22+6w vIhRrTS0R85UpV/+fdviHzi2clhvhxCOvdbSTvRzvEfBzXne7W4VhfKy6nHxPfKW3v81DpmR8IDGZzO63J+J6gxkRTNeTM14Sodeo3L15TqTcOa5TZYH4hv9ScHNgi5AsZE55vTHVZl/4IzO2deYgwtU65Rhk69ABhB3jGIUadAtruejdO9yGjW1pDV8bhTRauiiKffd62k/6hSRcp5llf+nD43zPBmM0TF/Z4rRM7ew0BaQTs4chx/bm44SgSS5WnQZGguBFlCmD1k2KcebUuSNFqhD50P1G1gtEGxvtPyDSoPV5u/ylqAgExuYnLu3x8W3oML/eqlcCNZNFv/3q6QU9DpCR/+sWjP+oMCOUOg6NVsC9HL7dY7MCJLlXr587tayFnqGlV2vuvyiKr0shUbiQCMFv38GJTnwi/PUD+LoqAT+cjdfYc2JBzxSjRkdRll2S5O4Kxh9/wWvkEzANRLJnmZZUI0GfotM0GacuXEZslY4iUhckfrVD6UL/eMA18izCHy70kTAbGn++GeIU0mAShiWpASRWwY5NbMhq0CBONL9DrQc1/zhSmuIzVrZNOqSV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.01.23 23:27, Mike Kravetz wrote: > migrate_pages/mempolicy semantics state that CAP_SYS_NICE is required > to move pages shared with another process to a different node. > page_mapcount > 1 is being used to determine if a hugetlb page is shared. > However, a hugetlb page will have a mapcount of 1 if mapped by multiple > processes via a shared PMD. As a result, hugetlb pages shared by multiple > processes and mapped with a shared PMD can be moved by a process without > CAP_SYS_NICE. > > To fix, check for a shared PMD if mapcount is 1. If a shared PMD is > found consider the page shared. > > Fixes: e2d8cf405525 ("migrate: add hugepage migration code to migrate_pages()") > Cc: stable@vger.kernel.org > Signed-off-by: Mike Kravetz > --- > mm/mempolicy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 85a34f1f3ab8..72142fbe7652 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -600,7 +600,8 @@ static int queue_pages_hugetlb(pte_t *pte, unsigned long hmask, > > /* With MPOL_MF_MOVE, we migrate only unshared hugepage. */ > if (flags & (MPOL_MF_MOVE_ALL) || > - (flags & MPOL_MF_MOVE && page_mapcount(page) == 1)) { > + (flags & MPOL_MF_MOVE && page_mapcount(page) == 1 && > + !hugetlb_pmd_shared(pte))) { > if (isolate_hugetlb(page, qp->pagelist) && > (flags & MPOL_MF_STRICT)) > /* Acked-by: David Hildenbrand -- Thanks, David / dhildenb