From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE4AC433B4 for ; Wed, 12 May 2021 14:33:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E155361411 for ; Wed, 12 May 2021 14:33:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E155361411 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 56F566B0036; Wed, 12 May 2021 10:33:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 520A56B006E; Wed, 12 May 2021 10:33:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C1B86B0070; Wed, 12 May 2021 10:33:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 227D26B0036 for ; Wed, 12 May 2021 10:33:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D4E60181AF5FA for ; Wed, 12 May 2021 14:33:52 +0000 (UTC) X-FDA: 78132823104.11.C46E512 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf03.hostedemail.com (Postfix) with ESMTP id 1F012C0007F4 for ; Wed, 12 May 2021 14:33:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0D24EADD7; Wed, 12 May 2021 14:33:51 +0000 (UTC) To: Andrew Morton , glittao@gmail.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Paul E . McKenney" References: <20210414163434.4376-1-glittao@gmail.com> <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org> From: Vlastimil Babka Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects Message-ID: Date: Wed, 12 May 2021 16:33:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Queue-Id: 1F012C0007F4 Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam04 X-Stat-Signature: 7peaq3cb4d7ux55m4b5po88bn8ioqoxh Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1620830024-100792 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/10/21 6:46 AM, Andrew Morton wrote: > On Wed, 14 Apr 2021 18:34:34 +0200 glittao@gmail.com wrote: >=20 >> Many stack traces are similar so there are many similar arrays. >> Stackdepot saves each unique stack only once. >>=20 >> Replace field addrs in struct track with depot_stack_handle_t handle. >> Use stackdepot to save stack trace. >>=20 >> The benefits are smaller memory overhead and possibility to aggregate >> per-cache statistics in the future using the stackdepot handle >> instead of matching stacks manually. >=20 > Which tree was this prepared against? 5.12's kmem_obj_info() is > significantly different from the version you were working on. It was based on -next at the time of submission, which contained patch in= Paul's tree that expands kmem_obj_info to print also free call stack [1] so that= also needs to be switched to stackdepot to work. > Please take a look, redo, retest and resend? Thanks. I expected [1] to be in 5.13-rc1, but as Paul explained to me, it's queue= d for 5.14. So if we (Oliver) rebase on current -next, can you queue it in the = section of mmotm series that goes after -next? Vlastimil [1] https://lore.kernel.org/linux-arm-kernel/1615891032-29160-2-git-send-emai= l-maninder1.s@samsung.com/