linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	David Hildenbrand <david@redhat.com>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: remove io-mapping
Date: Fri, 25 Jul 2025 15:23:38 +0100	[thread overview]
Message-ID: <f9cf2e9c-6ff3-4a0f-a6d8-226f37f2bfa0@lucifer.local> (raw)
In-Reply-To: <87y0sd8lpv.fsf@trenco.lwn.net>

On Thu, Jul 24, 2025 at 12:53:00PM -0600, Jonathan Corbet wrote:
> Lorenzo Stoakes <lorenzo.stoakes@oracle.com> writes:
>
> > This is dead code, which was used from commit b739f125e4eb ("i915: use
> > io_mapping_map_user") but reverted a month later by commit
> > 0e4fe0c9f2f9 ("Revert "i915: use io_mapping_map_user"") back in 2021.
> >
> > Since then nobody has used it, so remove it.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > ---
> >  include/linux/io-mapping.h | 231 -------------------------------------
> >  mm/Kconfig                 |   4 -
> >  mm/Makefile                |   1 -
> >  mm/io-mapping.c            |  30 -----
> >  4 files changed, 266 deletions(-)
> >  delete mode 100644 include/linux/io-mapping.h
> >  delete mode 100644 mm/io-mapping.c
>
> [...]
>
> > -/*
> > - * The io_mapping mechanism provides an abstraction for mapping
> > - * individual pages from an io device to the CPU in an efficient fashion.
> > - *
> > - * See Documentation/driver-api/io-mapping.rst
> > - */
> 				      ^
> 				      |
> You'll want to get rid of that file --+ too
>
> jon

Thanks for this, but it turns out we aren't getting rid of the header at
all (doh!) just io_mapping_map_user()... It's been a long week :)

Cheers, Lorenzo


  reply	other threads:[~2025-07-25 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24 14:53 Lorenzo Stoakes
2025-07-24 14:57 ` David Hildenbrand
2025-07-24 15:39 ` Lorenzo Stoakes
2025-07-24 16:16   ` David Hildenbrand
2025-07-24 16:19     ` Lorenzo Stoakes
2025-07-25 14:04   ` Lorenzo Stoakes
2025-07-24 18:53 ` Jonathan Corbet
2025-07-25 14:23   ` Lorenzo Stoakes [this message]
2025-07-26 10:15 ` kernel test robot
2025-07-26 17:39   ` Andrew Morton
2025-07-26 19:16     ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9cf2e9c-6ff3-4a0f-a6d8-226f37f2bfa0@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=david@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox