From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D559FC27C79 for ; Thu, 20 Jun 2024 07:46:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 606456B00C8; Thu, 20 Jun 2024 03:46:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B5D06B00C9; Thu, 20 Jun 2024 03:46:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47D8F6B00CA; Thu, 20 Jun 2024 03:46:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 299DD6B00C8 for ; Thu, 20 Jun 2024 03:46:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9D67E1A0B0F for ; Thu, 20 Jun 2024 07:46:25 +0000 (UTC) X-FDA: 82250484330.26.7FBF91B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 42BD8140007 for ; Thu, 20 Jun 2024 07:46:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LxZX6U0n; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718869575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sx0c3J3POpSIOfrWSRK9QnsXZHV2ebmGDTqhVB4KN5c=; b=QAjMH3G9oFoR9HA4tgBSxo9kMa2z+Mj6i5iwEcEYdcOgUCvgTgVBQ1RqIm08MNvNvOodEP sn1aVH3tTcOwgHopQh1rDrvwDofNLobkhkgJ0LMUd1oCVM3ifEz1Uqf4zAO/SJbC6+bJG9 x/kGlzunb31SQ3RkI80Biq+ytjVlQ2I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718869575; a=rsa-sha256; cv=none; b=faS/HRq+X4jHg33KFgPobkzP1DNRWIOtE02qyCV00LP9YgoZAJQBC57pZtRSvbngz7kIah mnNYGZjVHh9/IZ5HMhHZjjYeHLbqaa/ebK0sVHOGRVz2yxeHtVpm7LhYu0Sup3gow5cS7a nTI7b9hmEVw7OQyEY8xBgJ4eIMH9K8I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LxZX6U0n; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718869582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sx0c3J3POpSIOfrWSRK9QnsXZHV2ebmGDTqhVB4KN5c=; b=LxZX6U0nVgtSzGRlqTycat5iZup00PUDKQhVjd+gurxEoAYFJdJQXV0VqS7knxpR6jKsmE Xe4K7qMegFsdt0IpXRjpqxB//HmOBmm7SekQMOrjMChMc7+ld+9YAL0xxcvIbHQ5JEnt2b RmistQDxomeQSVO1zpPDab/u3kGJI6s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-IDh3PVRnMEuiqJl6C4GqvA-1; Thu, 20 Jun 2024 03:46:20 -0400 X-MC-Unique: IDh3PVRnMEuiqJl6C4GqvA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4210d151c5bso4963755e9.3 for ; Thu, 20 Jun 2024 00:46:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718869579; x=1719474379; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Sx0c3J3POpSIOfrWSRK9QnsXZHV2ebmGDTqhVB4KN5c=; b=u3hBLOkKA+7pDiU72jGJ8TkYnjBKA3/vxLcdFps3hZkOfUyVgdDFC3FpiblBWsVtTF yjRtscA55syyqNsA9ID6SXkBzxQrvJHUEGmQ3FmfweLL3/YFqoGlLUPXLOwTfqCUQW6X 4y6rNJ8ecVxpiwqP0KGYvbk4/5aXDXE/BFpxMSTnur81XVvP21DUPU83VTN9NcLs47Jh M8OrTRbD4qFk6WBB353kDsC7wqVRCx7f9i8RffOd71c3bgozM5fqKAhAlIihV9eraco+ skOslFnub3nv9Q8ia0H9Xl3FMeTf8O66Xkyr83uwJp+QDSqU3OMhx7mb0a2eP/JeLjdG ncTA== X-Forwarded-Encrypted: i=1; AJvYcCXDW180VQ67fzTymqq/N+d7KP8Cybq2YepCbfF1/wc/glUA43ImyKks85NDVIiaxxBdqyEIJE/CrgSHWmlN9K1wTqk= X-Gm-Message-State: AOJu0YwZ+siRZhFcV1msjof8o43oiT/tYkVwYUPMKaYZJkBi/MzU6JNp Z5P71WufWsEKB4X1EWmwSt1MMqtvxd1QvUn2L/WQT7NTOWI6Mp4RcZZ5VnoeMHwzrKWug3SzFvR 95GUrM0ePqianmHTrMhpAfAtZjLC9jDoXzwFsKYiNoBH3zCg+ X-Received: by 2002:a05:600c:5107:b0:424:760d:75bd with SMTP id 5b1f17b1804b1-424760d775cmr30541205e9.4.1718869579632; Thu, 20 Jun 2024 00:46:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2mb6eOHDmA3/2fQgXx7tO6lDjbXqLNP6m7VYBhRvPYytt/Dqq1PnEr3TQDoGYeJACgcixsg== X-Received: by 2002:a05:600c:5107:b0:424:760d:75bd with SMTP id 5b1f17b1804b1-424760d775cmr30541045e9.4.1718869579230; Thu, 20 Jun 2024 00:46:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:5b00:61af:900f:3aef:3af3? (p200300cbc7195b0061af900f3aef3af3.dip0.t-ipconnect.de. [2003:cb:c719:5b00:61af:900f:3aef:3af3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-363e849375asm2914254f8f.107.2024.06.20.00.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jun 2024 00:46:18 -0700 (PDT) Message-ID: Date: Thu, 20 Jun 2024 09:46:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] mm: use folio_add_new_anon_rmap() if folio_test_anon(folio)==false To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, linux-kernel@vger.kernel.org, mhocko@suse.com, ryan.roberts@arm.com, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, Shuai Yuan References: <20240617231137.80726-1-21cnbao@gmail.com> <20240617231137.80726-3-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240617231137.80726-3-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 42BD8140007 X-Stat-Signature: ohokqf38mpp5gnyyq3o3ftr7msyw5y5b X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718869583-219301 X-HE-Meta: U2FsdGVkX19CrWjxmU2L15z2We6FcNUHAeTiD13k7caYbZBwxeH5u0d8xwFc9oJkD7R/Qc6KXKFAayvTGBoiyX+X/TVGbgZv1IM9koG5SOyFaSwiPWb3ttzXUvFYjmIjc6TRPwwcMo5xDKqcIyFT7TAWyom6pSmUMh8ksXHfQ0Gf6fkslFnjPP13wt7QTTBuBZQdTEQlzUMqRIEC/O2KsmVBz4WPKLlurg7vQgzI5/jCxUR2Xsb5eZhHGQHjZ3dCmvz8G4NDliBPVpRRaYMlcssepDOh2ITLqwLSAUrMMnHcP3FZjEq//+U5+Kz/AWx62LxoixYHlLKZzc2ZPVAd5lhAm24d0mTAhQFc4jwLnwzO3Q6JJS86VRLjq4IEbiqEbHafSsKfkDN5EOz/p5JdcO3PJ+XfLwt5sa8T+i2xRZ6h0fM0SIwxrLEdcRYPQsZJE1QxB5xPZvJ8AUEhhkW3qeRIgqK+gbC1tH6/wkeLFFjCSG+WNXecMYtQopEdS5CEXMmUrvt8396pA91Um/pzpMgykis3lkikd3Eo0F9yUsM564TN3vTYrJZMCnfsitUwICcpbwMPON2h7odivq0iYPjdBH62DSjmMX/WCWDpU+N9Q02g+6lFWmSsZFfN6op11aW2OKn7nTtlppQRSh3FzIe4kKB6kx7FzU6TqRUvqXfkpxNB00M4101di+QQkVbV99lf4aYhjDJzn+au3TG11C0UwrjrWvUPYFZBm4Kp5e6/b0sgarCiAbBY7CyGOudplYVIRgkITNgjN5p8HJmEv5TQ+vF9q3tMIHgto28/Vy2EH0hGH6J+JqBubg4oBLyS5iN62RRlhAQQs42wMUgSF8ZHzdFPRXqCsWiCFQKDXK9mHqOHuCekYmPuhcdGCPzt+JoddNSwccbY8mOZexx7ONJTZCqkgmz8igTMI231an+YSxohYUKdZwMv4euYUcGyQ13ZKuW4I9Z6CGbAuZQ SdfbZukp WrLaqJDSsEP2S2/1kcCh0Gk+Mn0HNSGDz3o548poCYbqKgpkSOVYyqx30ZTLlH8ndQwUWYmQKvzlCOdtCv//j8SCWPc8YLc1auzteeOVDZv3VAUu41All1OAyfA0EPd0GBqIPtSl2EPKCK6WwXHcXzcaA5po7GBVOLJppbWrtwnbY2naoeSp0pPxWFuwfRwPtgDlDU+pXRuABr/kwKs86kdzfbmzVfkXo3K6an2tx4znk9eb/8gD+AyGu8NZFDkYyCpLQNZ05z3vpERxU7Q1pd4tcFG3ieVqbe0gEr7OI6XaBSmABRABPBxz9E/fQdOuzaMHsdFZ7tGCutiI31VbWb46sG/g8bYZUrqC7MPIwIg6btBOHHZ7JmCPqO1ZGFImbKWPccqeoZHHTs0ga1zIkRJe9KqXPrNEF+9vHfYoRe+ijN7tsZW08/1LDJB3Fb8E+dNuczaI7y8VAchRT6EPxP3YpVz5J/j1zeQGwv+JalGlkBr8NRJqqw6WYKtQcbFzME4XhfKB6od6pq1gkXUQy46xQ8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.06.24 01:11, Barry Song wrote: > From: Barry Song > > For the !folio_test_anon(folio) case, we can now invoke folio_add_new_anon_rmap() > with the rmap flags set to either EXCLUSIVE or non-EXCLUSIVE. This action will > suppress the VM_WARN_ON_FOLIO check within __folio_add_anon_rmap() while initiating > the process of bringing up mTHP swapin. > > static __always_inline void __folio_add_anon_rmap(struct folio *folio, > struct page *page, int nr_pages, struct vm_area_struct *vma, > unsigned long address, rmap_t flags, enum rmap_level level) > { > ... > if (unlikely(!folio_test_anon(folio))) { > VM_WARN_ON_FOLIO(folio_test_large(folio) && > level != RMAP_LEVEL_PMD, folio); > } > ... > } > > It also improves the code’s readability. Currently, all new anonymous > folios calling folio_add_anon_rmap_ptes() are order-0. This ensures > that new folios cannot be partially exclusive; they are either entirely > exclusive or entirely shared. > > Suggested-by: David Hildenbrand > Signed-off-by: Barry Song > Tested-by: Shuai Yuan > --- > mm/memory.c | 8 ++++++++ > mm/swapfile.c | 13 +++++++++++-- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 1f24ecdafe05..620654c13b2f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4339,6 +4339,14 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > if (unlikely(folio != swapcache && swapcache)) { > folio_add_new_anon_rmap(folio, vma, address, RMAP_EXCLUSIVE); > folio_add_lru_vma(folio, vma); > + } else if (!folio_test_anon(folio)) { > + /* > + * We currently only expect small !anon folios, for which we now > + * that they are either fully exclusive or fully shared. If we > + * ever get large folios here, we have to be careful. > + */ > + VM_WARN_ON_ONCE(folio_test_large(folio)); > + folio_add_new_anon_rmap(folio, vma, address, rmap_flags); > } else { > folio_add_anon_rmap_ptes(folio, page, nr_pages, vma, address, > rmap_flags); > diff --git a/mm/swapfile.c b/mm/swapfile.c > index ae1d2700f6a3..69efa1a57087 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1908,8 +1908,17 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, > VM_BUG_ON_FOLIO(folio_test_writeback(folio), folio); > if (pte_swp_exclusive(old_pte)) > rmap_flags |= RMAP_EXCLUSIVE; > - > - folio_add_anon_rmap_pte(folio, page, vma, addr, rmap_flags); > + /* > + * We currently only expect small !anon folios, for which we now that > + * they are either fully exclusive or fully shared. If we ever get > + * large folios here, we have to be careful. > + */ > + if (!folio_test_anon(folio)) { > + VM_WARN_ON_ONCE(folio_test_large(folio)); (comment applies to both cases) Thinking about Hugh's comment, we should likely add here: VM_WARN_ON_FOLIO(!folio_test_locked(folio), folio); [the check we are removing from __folio_add_anon_rmap()] and document for folio_add_new_anon_rmap() in patch #1, that when dealing with folios that might be mapped concurrently by others, the folio lock must be held. > + folio_add_new_anon_rmap(folio, vma, addr, rmap_flags); > + } else { > + folio_add_anon_rmap_pte(folio, page, vma, addr, rmap_flags); > + } > } else { /* ksm created a completely new copy */ > folio_add_new_anon_rmap(folio, vma, addr, RMAP_EXCLUSIVE); > folio_add_lru_vma(folio, vma); -- Cheers, David / dhildenb