From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE45BC54764 for ; Mon, 19 Feb 2024 09:54:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A48D8D0003; Mon, 19 Feb 2024 04:54:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5552E8D0001; Mon, 19 Feb 2024 04:54:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46A7E8D0003; Mon, 19 Feb 2024 04:54:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 395868D0001 for ; Mon, 19 Feb 2024 04:54:47 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 042031A027E for ; Mon, 19 Feb 2024 09:54:46 +0000 (UTC) X-FDA: 81808094214.18.7218BAD Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 77B371C0007 for ; Mon, 19 Feb 2024 09:54:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cJVJhjkM; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708336485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HjH7v7MwvWWsSPBnkhGSwPRvi6ZG5EixZmbA5olhbF8=; b=C+QnWWyPJhgwvPquzcWQW7sdr7bAmJIAPZLtPT8wD3wwaM6lwHHUvngDS0uCC2UO2Sl2rw Zhk86sR+vmyHdqKMPm7LewAz1VNX+tdvMZdzo/aYbIS/BrgLgoI+DTRAPRBlFHw7l0cNUS wqn+3GkiNroaDtczqTambyylgxjo+ms= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=cJVJhjkM; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708336485; a=rsa-sha256; cv=none; b=EGC/8r9482Cf/eNC0HrA9PFP2n+2b0LHcEN5hpeTJo6uWXrRsJaJGd7i8Teuo8g+qlB/r1 LvKsbioFi0ihIiX8u0Mb4UDnO3wx8MEOeXhrQ/xofVL47jbp5+xMfAJ2rHcrtIpluFG4aM 1AAlOyuiS32kZtJHXf8JTlNuNTq/ma4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708336479; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=HjH7v7MwvWWsSPBnkhGSwPRvi6ZG5EixZmbA5olhbF8=; b=cJVJhjkMFc3/SgYQ5niz4Vqd0l0S7c6Bt+wDTOKDZ80IP5Yn0WA0Cg5q6YgfscolA3eCof5yPsHqECoqSxmUDOoNm5Edc9Vaax3M32e8ZCcN8e63ARlxPnsJfieIIgSDH6x04NNsK/PtPaRZ5i9mjafUA6esGWagQW5jaqg/45c= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0W0sB01V_1708336477; Received: from 30.97.56.48(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W0sB01V_1708336477) by smtp.aliyun-inc.com; Mon, 19 Feb 2024 17:54:38 +0800 Message-ID: Date: Mon, 19 Feb 2024 17:54:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: Fix a bug calling wakeup_kswapd() with a wrong zone index To: Oscar Salvador Cc: Byungchul Park , akpm@linux-foundation.org, ying.huang@intel.com, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, stable@vger.kernel.org References: <20240216111502.79759-1-byungchul@sk.com> <517e58d4-7537-4d9f-8893-0130c65c3fdb@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 77B371C0007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: r6bd3jsh6wz5m4ibtxu9zz1jxtu6tqz9 X-HE-Tag: 1708336482-893114 X-HE-Meta: U2FsdGVkX1+soOFrQue9vC/m/58KsaedP3KlxQdi6YqRdKE7OczlUmFg1AtIxA+UprEC5qPRMk12ECKMUgwOjZkcv/VYJINolDRLfS2SnMeqaD5cHpXXvbZQUiDIOisgR04bAFLN1hYF3n76yKYBUrA/Xj+8kx+kwJpa73y+EGXlNC9l4YGzxNf0P82IyDe2fpqUIvIOdinWRLaP58vMApHfcmEpU43fuwxwjq4LtDIV04x7+fRze+y29UbUxlMDioIrgIyW0CPJiXcRkgmQBRbn/1aVyDMTrf/nTkuxL0cOORdfTs2DWdc9Rz4JgcAWJmkleAb4tTdUqPGVUgIV0GqyntBD7cChIAJXQbIYyOZ88U3NTh7ZomiabYnbhn1C6V6JQlRBVtk7h8EOFEE4LsM/GP+wbg1LMoOhkH2LP5D+PfE0MVAeJnH3NUIpbALgrhVZq8fK25/DO0FFSJB+Pp52OGdTTbA47hRtWEtial0CKAOvczg2RC+liqQfkRts1bqNYrMsee96EmYFHnCwFwwBVbbbfSJsLj/tDdowaXcQWUlbB47L7pOTP9RF4HFF2upFdniicHJt8AyFDb48a0u1nPKn3CXsXEOGMBm3ehmngATR3hnKre+oYiEVnqsGGBiKdNP0x1wAEXnTZVsSIYsKBurSgzg3722rFtv77J02uugvYLhawJm4jQ/NGRZi+6l7iwNnfFusjxnvpCRdpPFT1C5iBBg8w6oCFUGdLVDLl/HvncyW4Dd8VN1lKbJSsPFpvp7aB0jWnBoON+bWZhxJ5aJp257irIEsVh04/1weOGfPuBxMhdMtR4k2zmjmwziJ4WEANzq5t7WExX1y4f9pqTejfDR9QFrhSwidjaaTHF99dIZkAoy8G+WJUE/E9UMgrH1P5El4PT5o85Y7s0UOtW2nsglTLpO7hoKpxKrG3rLf9Mg1fSi3bQtcZXiFSqh9qL0aPJc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/19 16:11, Oscar Salvador wrote: > On Mon, Feb 19, 2024 at 02:25:11PM +0800, Baolin Wang wrote: >> This means that there is no memory on the target node？ if so, we can add a >> check at the beginning to avoid calling unnecessary >> migrate_misplaced_folio(). >> >> diff --git a/mm/memory.c b/mm/memory.c >> index e95503d7544e..a64a1aac463f 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -5182,7 +5182,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) >> else >> last_cpupid = folio_last_cpupid(folio); >> target_nid = numa_migrate_prep(folio, vma, vmf->address, nid, >> &flags); >> - if (target_nid == NUMA_NO_NODE) { >> + if (target_nid == NUMA_NO_NODE || !node_state(target_nid, N_MEMORY)) >> { >> folio_put(folio); >> goto out_map; >> } >> >> (similar changes for do_huge_pmd_numa_page()) > > With the check in place from [1], numa_migrate_prep() will also return > NUMA_NO_NODE, so no need for this one here. > > And I did not check, but I assume that do_huge_pmd_numa_page() also ends > up calling numa_migrate_prep(). > > [1] https://lore.kernel.org/lkml/20240219041920.1183-1-byungchul@sk.com/ Right. I missed this patch before. So with checking in should_numa_migrate_memory(), I guess current changes in numamigrate_isolate_folio() can also be dropped, it will never hit a memoryless node after the patch [1], no?