From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E45EC54E58 for ; Wed, 20 Mar 2024 03:54:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 847A06B009A; Tue, 19 Mar 2024 23:54:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F7646B009B; Tue, 19 Mar 2024 23:54:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BFE46B009D; Tue, 19 Mar 2024 23:54:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 589FF6B009A for ; Tue, 19 Mar 2024 23:54:57 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1DA8A120EB9 for ; Wed, 20 Mar 2024 03:54:57 +0000 (UTC) X-FDA: 81916051434.08.6AFA06B Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by imf03.hostedemail.com (Postfix) with ESMTP id 6390F2000A for ; Wed, 20 Mar 2024 03:54:54 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710906895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vu0qllrSTaldILjVSOjGSnlA0IHzjykL6/AK/t7rtt8=; b=ccL4/nHCIwvV/Od5jtCvCTVPBEmBiKLcjzbrvR3lz64tEC4uvyoczsmOHfStHQwnY0QYwD zmyqkE9ZdGZei0DnugLc5B+ObNkf7FTtCDKQKrboMAEtEztL+iUwxv+/FrlqOGwWT0rgkM ZrlQh0tyCmcnLnGWxkjXeZKCb/qVy1Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710906895; a=rsa-sha256; cv=none; b=afOGgt5xiFAEQo4Tnvm+pZPuDSVSwQKo7zeEdQQoIUQ1G0ELMH7ZrpL9d6DkaoggiUU6YI si0CjeS7atwPHbgpDMc6aPCpULkZOiilaM+Jn1m5fBdYPjlPezIhuXgT1tO1Ny8TIeiduZ 7RJmiS12szWxkwnsjB0Vr17WLB9lFfw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of penguin-kernel@I-love.SAKURA.ne.jp designates 202.181.97.72 as permitted sender) smtp.mailfrom=penguin-kernel@I-love.SAKURA.ne.jp; dmarc=none Received: from fsav413.sakura.ne.jp (fsav413.sakura.ne.jp [133.242.250.112]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 42K3sPLu062256; Wed, 20 Mar 2024 12:54:26 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav413.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav413.sakura.ne.jp); Wed, 20 Mar 2024 12:54:25 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav413.sakura.ne.jp) Received: from [192.168.1.6] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 42K3sPRp062253 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 Mar 2024 12:54:25 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Wed, 20 Mar 2024 12:54:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] x86: call instrumentation hooks from copy_mc.c Content-Language: en-US To: Alexander Potapenko , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, tglx@linutronix.de, x86@kernel.org, Linus Torvalds , Dmitry Vyukov , Marco Elver References: <20240319163656.2100766-1-glider@google.com> <20240319163656.2100766-3-glider@google.com> From: Tetsuo Handa In-Reply-To: <20240319163656.2100766-3-glider@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: gscgwpeefhenafzzgr97shrkascxy5t6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6390F2000A X-Rspam-User: X-HE-Tag: 1710906894-901235 X-HE-Meta: U2FsdGVkX18G5KIBKPH9jsdIJFszLvV9An1GG7RJ2MtKf7XblDDuzJGyrFgD2UZOjCXVMURln6qRH9iXeX1BcCevRpyaROBZXfWAuw3oZS/seIGAyZ8Bqns0Rlaco5F0GYPBKII3//Nj8iJ8jOIxKpBSEjHb9LhCpARFjdMfkuXuVNzUkayOUvtnPYADdsM4HaApCPJ3gB3oW8t8S49ig5BHZWzHVDC3ni9Wxf/oboSnVj3g3jsVUYnmsEOW/1CwFd9637BBGXmjGhSiRr0a5gvWm66KtArt+ynTa155gEJMXSQrn3cM206lY0rkS/522x3qBPqOrYGqLVfj8u0N51BR41j8mZ8MyXHg/nacb2Hp0TRcp1dgBBYWJddhz2WAmMBOvXOppSYVlLsgvWnaUDV8QK/p6uxl1f/nWugbJrdu4jyV4lTbi0HSQCSNIgevH/6QMLNkeN8QIpPeTNHrmV9891RarGHZz/VCT8TuleAr55Yk70HapBQJg4Py91hvYFhS0jiXaztrceq6vgkfdzBzAWlYmbkBNCXFb6GfWo+4kFVDCiBmWdYUouEsxGnfM/GIJEaXSSWN9PzYv2kmPw/mKtvBoef/U4Q8pjLFNpk8sWpY+sf6XFDQQHqJc500nNcdwQb66ZqeRFKyVdXEB3IYTtao0ZIp/z3i2I4uDRKBgH/GieehfWxxbhesFtqyWgPBEtD4deLpdF45FbCDtvAuvU0C8Yc2UipphEDOQwvxygze6dHlB0xkpLcjG305PHScQuR63TCc3Y337gR7/0ff12vo4hNnjMGYuL1wPJjMgjZb+751fakwbIE75wdzrDArCEWaUxTVorRhNimKI8SP+bwJnuGXHw7tjjBiPj7x6kKNmVVsVmyUuQfwxl5SoD9dNfEPQkCtjj1T5xU2zyBbkKgLy70ITfG39hcwHij5l4NIFHTSVOLh7TGCOWLmNPfQUc3rMd9D7H091VV LBeaRa0+ TjXXZS5el4R22+NfBoRB2z+YOB3W3KpM0gE0is9YdNv/n6wl/1X5MbS0nwdN5LO+R3e/4B7NPJ87RK3lG6RZr4GjRz5ny+UXv3M1abFgdEGyu1SFpL8gWmiOsDcmblLnwqVy1QFKirOiJ2bpU+cdkXDNsbQwKOFCl0j3fmNdNKBvlHjLLzCD7Qjxr5nSq+M4qiZD/mv9txZioFeeg+Id7e14OM8srdegbdajw6yskca27nnpLkldeYyBOlxKWUGBfi5VDch7ai8Z8bj+TlGGdDS5njBUEokKupT8R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/03/20 1:36, Alexander Potapenko wrote: > @@ -61,10 +62,20 @@ unsigned long copy_mc_enhanced_fast_string(void *dst, const void *src, unsigned > */ > unsigned long __must_check copy_mc_to_kernel(void *dst, const void *src, unsigned len) > { > - if (copy_mc_fragile_enabled) > - return copy_mc_fragile(dst, src, len); > - if (static_cpu_has(X86_FEATURE_ERMS)) > - return copy_mc_enhanced_fast_string(dst, src, len); > + unsigned long ret; > + > + if (copy_mc_fragile_enabled) { > + instrument_memcpy_before(dst, src, len); I feel that instrument_memcpy_before() needs to be called *after* copy_mc_fragile() etc. , for we can't predict how many bytes will copy_mc_fragile() etc. actually copy. > + ret = copy_mc_fragile(dst, src, len); > + instrument_memcpy_after(dst, src, len, ret); > + return ret; > + }