From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30968C7115B for ; Fri, 20 Jun 2025 15:44:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C85F26B008C; Fri, 20 Jun 2025 11:44:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C366C6B0098; Fri, 20 Jun 2025 11:44:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFFA66B009A; Fri, 20 Jun 2025 11:44:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 981A86B008C for ; Fri, 20 Jun 2025 11:44:41 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 42A4212126C for ; Fri, 20 Jun 2025 15:44:41 +0000 (UTC) X-FDA: 83576201562.15.AD2D629 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf19.hostedemail.com (Postfix) with ESMTP id 54B1E1A000D for ; Fri, 20 Jun 2025 15:44:38 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RVtaYspR; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750434279; a=rsa-sha256; cv=none; b=8kkK4jjnb0iBwWadWyQwZ4An90ilyTtxwl1TcJxXTeLqwQ8uYQie35l7YgHnqq2OxBLZ6H 1/xzPnsqjpY+jhOUgd8vZeSmxIgIgMhPpWzNBdvjYv2Sphz6FmxmlCzQTl2kkI0nNWuxr9 +kS9WUpN34azKANR1Ytr0M2UHNpHpMM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RVtaYspR; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf19.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.19 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750434279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypF2UOOIRlcET3uw3gS4lozFGlZiJ09+5jjQYSZAIqA=; b=XmiXBkwy8tm4aa2EYnQ2/oE7rJKAPUTuAxbxJp+pb/fxVkMkQ2N13Be3rIzRMZn8L4DUGV ZmC8Aih4ModqPTerDkUnqsNBC0mCnfwIxoXWybMNw4XOp5YkX4A03VL+jE2kwo66LRXCN2 n+iswPhjueAS2zjQSrZSYTpMUiOENXY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750434279; x=1781970279; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4eJa5xbDcELWdsJk6KpEaKUJ8es/q20NBTbt7fi9Bwo=; b=RVtaYspRwzAx+DC4MBpdNyVukk/EZG35W4b2t4FjBUjESV2YPBDW1vDi 5+Qdq3V4HlHJWvzy1ZxCS5X5Y7dTK2/4aVgVjqzcvC7W0UBMIULxGj2rk rTFSdKb/FM8jZXuKD5dP2esvJ50ZS0nvnHBEpkqu69OPYzXPsJoIyoTs2 NTAd1KMMfI7gmwnQ+8UvX6SCcyAe2YynvfEDpQrLIZ3qioSIYcxKHFG25 C81rCJ6jUuzpml7vwhlgJrXCAZXCoN3PMfC3Qnzak0H0EK2aFEJc3ibTa 2b7VycqopUuI1LbcIpmaeloGXGh2b1tFhs7UnJbRNczn+ZVodpD3m3cVk g==; X-CSE-ConnectionGUID: n/+vVJ9OT7O5sS6o0oOM7w== X-CSE-MsgGUID: 77C381OcTXGW0EYOxLEfgg== X-IronPort-AV: E=McAfee;i="6800,10657,11469"; a="51814395" X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="51814395" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 08:44:37 -0700 X-CSE-ConnectionGUID: KFczqDHHQQWSuEshRwffvQ== X-CSE-MsgGUID: /I4sq9yASLmVhDtangNK1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,251,1744095600"; d="scan'208";a="151082647" Received: from aschofie-mobl2.amr.corp.intel.com (HELO [10.125.108.136]) ([10.125.108.136]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2025 08:44:34 -0700 Message-ID: Date: Fri, 20 Jun 2025 08:44:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv6 05/16] x86/cpu: Defer CR pinning setup until after EFI initialization To: "Kirill A. Shutemov" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin Cc: Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org References: <20250620135325.3300848-1-kirill.shutemov@linux.intel.com> <20250620135325.3300848-6-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250620135325.3300848-6-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: nrdn1a7tzcmbpa5km4keb5xtwx5rojqb X-Rspamd-Queue-Id: 54B1E1A000D X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750434278-135323 X-HE-Meta: U2FsdGVkX1874xggiRLi893tN6lKgPm8Ino/Ov1O8xnT8g3hJ6wZ7hKrm15hlC7iFpE1EUpedwvPa8x8LyWZXqBG/GiX52PoZ5x3f4iRZy3hTNrMMP9Y291FV/RZdBaGdYnDfewbBWB1/FM65772hK9E+UC5xZ6N8CIZrjPINp7E8O+wr2jvFnI60n6gJ2PjqWkd/ClEnWVeSItWgePa9UFNzLF5u7yOmz8tMIIQLafp56oB+S1CqFmq9nMLFjZUrueWkuwvG7pAyDjk4nx9yJS5Izioosg2K+6V6KWjIG7DBjeo+/MZ3ZXJyf4AeNgcdcywXjmI/qgkGoRolHSaDdpvMs2zbkrs8m3ySYLe7sokAf5HXa7G45YnXusTvNrrbum7n+aMe/7mYDErB7QrXKLzHeX9sILHg7GMEp8Q/6TW6iwpNvtH8txl9HV8H9rt0hQZbFpWZF5Lm3LQnTD1fEv9stzifxUJhancxP+r8iNOQh3W/AQ82jf78Tm7qVLCUC3AaUsunG0JvjmZr6PyNBBfh+3F6Rd9ohBX0k7mYqYEFzKR8rPzYJOC0BR19FMRrWL5oKABBqRjFLkmRniaaLl5YV/ZK0kZ8Y8LQX04PAbcWjFUpNmGWbS2lot7Ks0/PvxnBLuKDPcAz2LHo47kZE5rcIstV17oqjDSe36MxcZCgqs2VH+2/8+R7hvhmnWJjDBdurYqrsRsiFTu3QA1rajGhu/r360nltDbCmf40pP90wOqYeyzDH6rxIUeI201oZma0rqfTh/UBQcmbZ86sWZ0k6ehF1q19X+a/1o5WvrZJNVlqn4brjfkBVCOHnBrsWs4xWfeSrKMARky6z4Q6dC9ke/eJgZJfi/yH1tqGKZUtQR96ZZnHzWOD2wVDrqEu6JpmriXkRwlUst+b/Cq/2oEv7M7VfqSCX25EWH1/amZh2duS/Cy/ffVkbU0st9n7ecKixevM+P8Ezj4AEc Mp1kP6mM ocxxDIpr1rWdmg3RJO7DQzPlh7LGd8z7RuktxrHkFLyiSFwPpNU6XGYC54bpTlYxug2gZ10QBobAVCG+3wXuomaBx+Qoo3fXtZao4R/KAGtew2l4Kb9H1j155L2PIiCYkzWE2Vh2WMoQruc8Kk0AEpgsVQf8b36/xD+wnpR1lb9BMffBYRdJnSJ4/wg3/VMmxULNd3JyY68akTocclj08WLeo0LaLxd5XwULVESUJlbm/uY0AMaKK2YxABQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/20/25 06:53, Kirill A. Shutemov wrote: > /* > * This needs to follow the FPU initializtion, since EFI depends on it. > + * > + * It also needs to precede the CR pinning setup, because the CR4.LASS > + * bit has to be cleared temporarily in order to execute the > + * set_virtual_address_map() EFI call, which resides in lower addresses > + * and would trip LASS if enabled. > + * > + * Wrapping efi_enter_virtual_mode() into lass_stac()/clac() is not > + * enough because AC flag gates data accesses, but not instruction > + * fetch. Clearing the CR4 bit is required. > */ > if (efi_enabled(EFI_RUNTIME_SERVICES)) > efi_enter_virtual_mode(); > > + setup_cr_pinning(); This is a _bit_ too much of a comment for me in this context. This would be enough: /* EFI twiddles CR4.LASS. Do it before CR pinning: */ if (efi_enabled(EFI_RUNTIME_SERVICES)) efi_enter_virtual_mode(); setup_cr_pinning(); I also dislike comments where code will do. Could efi_enter_virtual_mode() actually check for CR4.LASS? Or check cr4_pinned_bits() or 'cr_pinning.key'? Also, the "lass_stac()/clac() is not enough" comment seems more like changelog material to me than something for a comment.