From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BD2C52D7C for ; Thu, 22 Aug 2024 12:09:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A5A6B00B7; Thu, 22 Aug 2024 08:09:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C9D06B00E2; Thu, 22 Aug 2024 08:09:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B8736B0190; Thu, 22 Aug 2024 08:09:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6CF656B00B7 for ; Thu, 22 Aug 2024 08:09:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0D5EF815A7 for ; Thu, 22 Aug 2024 12:09:08 +0000 (UTC) X-FDA: 82479760776.20.5885342 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf19.hostedemail.com (Postfix) with ESMTP id B15BC1A0011 for ; Thu, 22 Aug 2024 12:09:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724328529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5eMfSTqsnMDgTixmSEXU/4KokG2brpTknmj+Ick7gIw=; b=nGHGmT5tmO/snL0iEvyer1FpRuwJaMF9oYJnJLnyFxMMvEnkrNwhx3Vg4OjqfZKNckSTVH 2NMy8GpiDrR84+f3aYaXAYgoAOg/XdVmTa+9dW7UjvhP4Doe+dDOZ6GZZkiE/Blj0N3YPi jpcTnOsR3rv3Jh2IfrXOHUZyHVDdK6s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724328529; a=rsa-sha256; cv=none; b=YP8wiWsFmf9bu+A7VCKx78t56OtnUZzxDIdNmTJcw7fVRbbya+mttGO9dtkgx8iE5RUE7q YzfAOmI8Jof/GfIwkUpyeNmokouohEMLDvmiz0gSrv5B3mCJMeSr1uWQYxxHNHaa7YXhTx jDKhXmtxO9gM2/NLkWHX2JokBH9jHFI= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4WqMLl6Tr1z20m3V; Thu, 22 Aug 2024 20:04:15 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id B648B18001B; Thu, 22 Aug 2024 20:08:58 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 22 Aug 2024 20:08:58 +0800 Message-ID: Date: Thu, 22 Aug 2024 20:08:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation Content-Language: en-US To: Miaohe Lin , Andrew Morton CC: David Hildenbrand , Oscar Salvador , Naoya Horiguchi , References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-6-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Stat-Signature: mfsqbo3mdtc6dc9n9qcj75g7mw7adsca X-Rspamd-Queue-Id: B15BC1A0011 X-Rspamd-Server: rspam11 X-HE-Tag: 1724328544-93354 X-HE-Meta: U2FsdGVkX18rJP4pAjtqLP9gsYikaGCOsbSXcDQ/Vlj/S9SvbZC39juMKmoXCLSRURGxFSRN7RxdoHazKiTMzDTV/4P76O2XPQXxQ9R8r30DTm8vMm11wkhDJqnXFfu38z0ijKm29dO+11ArOk8vzDhYDOA5VW8FjSz2GCg+HzbUmtP0GlxiCsGXPcImXpFXEDCurY3zpRvUuCzVg9OuZ699UKmK/ht6qobesjuKOV0rzGbefZK9UzlWmfWtw3hCRL5tero2+neCs1vAVtlCa68EaA07+5gtkiSz8qgpv5o5WU37/KuqCOd8NJEsX25sGDNmwoamWSb6IRJA1dpqa/ua93r8g22Yhdinb1+qGhSV/82Gv8Dk7hz88RHL2Pvc21Yoo0zFm4V3kUXUyLphfZR2W6D955+b2MZ5CsRK4r/91q2Nfu+K/LKTrBO7m95Ma/jnIjjVGeUyXaKn31RrHqQ1CndvKkre6eUnHlIUFQZGEK0Jv5AJJFXHXFiIifAyBb2HIIgiSSaoqryqJ1bYbVwasG/464Q1Z9vSxlCdOAlwAlmbzxePEUKmKmct+TcxvhxN+T2xzgwkzJFpPeNsHRco1UH+VCWKcQZB9riNqf/LK1bisP0UoSg/6DrxgaI1WbgxBcsfLNuAuVqfbK0EN1VliU1UDC+luSqp/jLvxiOGK/6Qgwp9qvFOkoJycUkGW5WZwOzyBJMLCQlTgFB6APACfgl7JcZug2r83ypkayhY2aPRKcbghGeyvyCGX+68ZfuVUSMSEJ4wVQiaaBcYVfAFQ1D0ONTPMdTvJi8Z1kzgurQfJhD5kv7tdpszvS0KRZmrwKEwrymwcltfDHlIQwCxHBZNY6RRsewRP/YZTzq3pVUMtpAIxA61h0NMyP06L48B8a539AYlO4GVLsQgX7zDyz96OVgEG7ixQasWw3HQcOzRsSSabkb62t6Iu+nxRL9TLfBhleGYz/QTeWB qH9UJgWu Sk0F6iifIFcfwnUOX9fef6UOE0m0pCcOnlnBoSJ7jtK6xpGB6hy56rwPOCfnrXd01UaLyFfr92D1h790UW8XK4jR+iOnHZ0R9ZZnoyS3XgMeiTT8ruNX04YeBtPqDiu+phGFGAedcAR0BgviKtI28H0ch6w01gt/YZ65IwmjQjgETO6HOsQP9/YXtc7EazOk5IbIpdMiZutf/ZbaMvjGI3mENaZuswvmF49zs7DKpaOIqY7kNnpe5CZY1pWZxcnAjYqkpkWQQte1RS+oIWp3jlZxqsTE7F7OqRKNihOR9S621VKxOn/GKOYmv7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/22 15:20, Miaohe Lin wrote: > On 2024/8/17 16:49, Kefeng Wang wrote: >> Use the isolate_folio_to_list() to unify hugetlb/LRU/non-LRU >> folio isolation, which cleanup code a bit and save a few calls >> to compound_head(). >> >> Signed-off-by: Kefeng Wang >> --- >> mm/memory_hotplug.c | 45 +++++++++++++++++---------------------------- >> 1 file changed, 17 insertions(+), 28 deletions(-) >> >> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >> index 02a0d4fbc3fe..cc9c16db2f8c 100644 >> --- a/mm/memory_hotplug.c >> +++ b/mm/memory_hotplug.c >> @@ -1773,14 +1773,14 @@ static int scan_movable_pages(unsigned long start, unsigned long end, >> static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> { >> unsigned long pfn; >> - struct page *page; >> LIST_HEAD(source); >> + struct folio *folio; >> static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, >> DEFAULT_RATELIMIT_BURST); >> >> for (pfn = start_pfn; pfn < end_pfn; pfn++) { >> - struct folio *folio; >> - bool isolated; >> + struct page *page; >> + bool huge; >> >> if (!pfn_valid(pfn)) >> continue; >> @@ -1812,34 +1812,22 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >> continue; >> } >> >> - if (folio_test_hugetlb(folio)) { >> - isolate_hugetlb(folio, &source); >> - continue; >> + huge = folio_test_hugetlb(folio); >> + if (!huge) { >> + folio = folio_get_nontail_page(page); >> + if (!folio) >> + continue; >> } >> >> - if (!get_page_unless_zero(page)) > > Does page always equal to head? Page is used in most cases in this function and head is only used to calculate pfn. > If not, folio can not simply replace page? Not very clear what your mean, no guarantee for page == head, that is why we need use get_page_unless_zero or folio_get_nontail_page to get the folio, then try to isolate folio, since we only migrate the wholo folio, I don't know why we can't convert page to folio here. > >> - continue; >> - /* >> - * We can skip free pages. And we can deal with pages on >> - * LRU and non-lru movable pages. >> - */ >> - if (PageLRU(page)) > > I think this check is incorrect. We should check __PageMovable(page) instead. So this patch > fixes this issue too. > > Thanks. > .