From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4CFC83F0F for ; Thu, 10 Jul 2025 02:49:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5186E6B00B2; Wed, 9 Jul 2025 22:49:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F0116B00B3; Wed, 9 Jul 2025 22:49:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42CCA6B00B4; Wed, 9 Jul 2025 22:49:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3343E6B00B2 for ; Wed, 9 Jul 2025 22:49:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F2824B97A9 for ; Thu, 10 Jul 2025 02:49:13 +0000 (UTC) X-FDA: 83646823386.14.B27388B Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf19.hostedemail.com (Postfix) with ESMTP id 649441A000A for ; Thu, 10 Jul 2025 02:49:12 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Rtj1GYIu; spf=pass (imf19.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752115752; a=rsa-sha256; cv=none; b=Lu54Ml+AjO89N7zdPo17d9cec1vfl5o+UWI/6+X1MLHw9zlUdf8Jz3seAqsz5fULO7ip3K F/sjGZi2Q3J15WykybEsu2kX8YDvpt7u4JD1bdJDRKpQzSdbIXAcfIzTGAkCHpHut1MgK2 sk/NDzpv4arMnus76FaVeGTmo8XRyK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752115752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rGub8rjx+mnwzeSATZsYngbxCItCiY7i6tQqrFSacj0=; b=sn3J/ZxuAD0AnIRWDMafy1GbsKZC5lVhHXzhBPTxJb2QHrBV11FWOWLOXhjMCBqsTnWVsc rlpE0Fj0v4y1wTWMT2gFzgMI6MX+3YyrRlmvBcSpuDYVx0WRWmWHDyZd0hEkMLtPObYxe/ 9zAEc/ikdvE4gqQmvA00hEjJwFeddxg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Rtj1GYIu; spf=pass (imf19.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id E145D61139; Thu, 10 Jul 2025 02:49:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1F95C4AF09; Thu, 10 Jul 2025 02:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752115751; bh=En+Iya8BEITJchISNZUlAS9xNApPSGz+tWs96YVWasQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rtj1GYIuVkOk5l25BPrGzLsdrPA8HXWMNO7QkCRBiFthatnOP1tTlQ6nXVlF0F13w TfdqSVccohtn7+DGwYcAmy3AGKeO6B0yg8uAM0he/tIt6XfhvWffHHFyJXr2mSBPEG nQiMvDyFKD/s9ZNMzlBpL1SD+sb2xoi24+pd1UTR2Ii3TKyghjRFYWgmV2RchFE0nl sYkn858HvVgORUAkLtArJlA5bUJ5/JZgrHemxn1D2/1plkJO/Vb//S/T1XOxMUwH0T zo8cqA1D1jWvLxkOGxH5mvh/I0YJuEsAokH00Q95Z/pps+RTCT2iFC8YyQrFRfi7+8 +1A7nLLEJvjbw== Date: Thu, 10 Jul 2025 04:49:03 +0200 From: Alejandro Colomar To: linux-mm@kvack.org, linux-hardening@vger.kernel.org Cc: Alejandro Colomar , Kees Cook , Christopher Bazley , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Rasmus Villemoes , Michal Hocko , Linus Torvalds , Al Viro Subject: [RFC v4 7/7] mm: Use [V]SPRINTF_END() to avoid specifying the array size Message-ID: X-Mailer: git-send-email 2.50.0 References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 649441A000A X-Stat-Signature: j5f73bu5ctoa39g8eorq99ouqi54a8rd X-HE-Tag: 1752115752-600997 X-HE-Meta: U2FsdGVkX1+ROiDxUCtgME9tS6DPOs4J3ouPvpwXdMttZ5v7LWx5KXiB7JjX8sdD+DZVFNpQRTr/f7JhEQZyolTG4SLs21X5d4z67+1od1XDfcVj0qMOYt6rc4r7nYGKrsxiAUpeRW0fbClue9meCcD3iYJQz0WJToX+RQS0fEEUWK65y2LtW65q+y1DGBnurN/kv3iBP5dm55jqrSxR3ygYs9K8DW/adN7Ihp8RncsJWzb/N483R3J7Wg5QjKuvk6YM2e3JaStwBiI7n9SgEhp/tm+zQtvaIUIelqsIby3uSYCwuEA1mF2A789T+VncViEE7L+r8CqY1rcu2HOn8rvToFnuhR6gYhx8ThRXbZre01Un8kWgLlr/zGGdIkdfDd2GQjpBsEMmZYIQLSJ7XHsS9V9ekNcqljcoKOnpJvxw4KvncwEkqUC0j6WrMv5CMmW/lCo2ETsxkFjRfVyRLMa36QlVjEJovOvKDgicpQBNgbDJSZHTC4k/UpmTCWKdJt2TnImOj6FFvsBfChxLCMG/z0jmuVtcjdElO/mFAPtB3MWBK63ovIhxyX5F7OeZ+qsuTwjDUH6D6Xx5AbgoRWdss0y1IkpUIClxyNijgeW4tywXZKghYETgkWhUixtOOQaHnrT/ljb5/oXfjKlMnvcZ3SeldzDNGptXlFKpWjxSiXXwlor2+8TbwVOV7r1JzJiCeXCD63gWmJB9xl6s4wT8UPDnK7CEhpAMj1W7w2DmUE1tT32l4JaT9lmpW/ThXXL9JN5C/1qPHOO1lV/eSG+vtTOewoVkXkwzW7/1vd2c0rwg0w8twPfO91O0yyYPehasMrtTUqdDu4e9ZEhv9IAz926dc4k+XXjSkNwK610l/X+OWwNwZaWqQte7cSA282XA9/4Lu71gG8aofSnDUEuldr0nvsevkdqPMw1UqDWd9xFFLG0dyu0EJeEH+9oz41cBFTA7UVKiGfFyvww UmcI58eS fxcUbdpHr3+OgpSWQuxKF8SORurmHGFbAoyXllu6+12uBAKTKKflGYvV04iwq7cdjgQuGLfAxI2KxbQayWRfxGr9UAh1Kwf8/P2nTv0Nwym5OUkIGt0zztsyaL6uD//47VIebWaWmVyhjWpnm2SrB90naFTfMXM3/Rw1qxO464K+HHmHHrumei3Y0Pp5cbG6Syr44tcviAAr1mK45oIRrPhHi+sauUFYXRAQqn6JMAUcEqU8hOuNA4wDV+Ouz/VWiBqWYwrD9F0VKbuNKKFvDxAWYAqDz/Rc4G9HgO702yRvaNV4RmNNn0qlLVcOLBnIDkgGzf5LtKKsPmgNj6e24qzotyaLThIGnTWP3AU0K8AVx9jrDtL8168UI7e00X3ag5crp4f0y0NVlAulgMKUFHu9jK3czFnfF4wI6HsNrwJAMaaKv2k6TgwnO9w0exvd9KEyyoOCUe4lPJAesfRFc25/8iFX2XfUMcssuidw9GXYohRt6PO9wntI9C0foMzKcpNSWUO7LNu5l1cTuRSucSuWqnyZHGwSTh5PHLbGvTx1ObUTaM4UiLVoaFLkmA8BO0593I/Abtca7o+EkKdlWLPZiPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Cc: Rasmus Villemoes Cc: Marco Elver Cc: Michal Hocko Cc: Linus Torvalds Cc: Al Viro Signed-off-by: Alejandro Colomar --- mm/backing-dev.c | 2 +- mm/cma.c | 4 ++-- mm/cma_debug.c | 2 +- mm/hugetlb.c | 3 +-- mm/hugetlb_cgroup.c | 2 +- mm/hugetlb_cma.c | 2 +- mm/kasan/report.c | 3 +-- mm/memblock.c | 4 ++-- mm/percpu.c | 2 +- mm/shrinker_debug.c | 2 +- mm/zswap.c | 2 +- 11 files changed, 13 insertions(+), 15 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 783904d8c5ef..20a75fd9f205 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -1090,7 +1090,7 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args) if (bdi->dev) /* The driver needs to use separate queues per device */ return 0; - vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); + VSPRINTF_END(bdi->dev_name, fmt, args); dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); if (IS_ERR(dev)) return PTR_ERR(dev); diff --git a/mm/cma.c b/mm/cma.c index c04be488b099..05f8f036b811 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -237,9 +237,9 @@ static int __init cma_new_area(const char *name, phys_addr_t size, cma_area_count++; if (name) - snprintf(cma->name, CMA_MAX_NAME, "%s", name); + SPRINTF_END(cma->name, "%s", name); else - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); + SPRINTF_END(cma->name, "cma%d\n", cma_area_count); cma->available_count = cma->count = size >> PAGE_SHIFT; cma->order_per_bit = order_per_bit; diff --git a/mm/cma_debug.c b/mm/cma_debug.c index fdf899532ca0..6df439b400c1 100644 --- a/mm/cma_debug.c +++ b/mm/cma_debug.c @@ -186,7 +186,7 @@ static void cma_debugfs_add_one(struct cma *cma, struct dentry *root_dentry) rangedir = debugfs_create_dir("ranges", tmp); for (r = 0; r < cma->nranges; r++) { cmr = &cma->ranges[r]; - snprintf(rdirname, sizeof(rdirname), "%d", r); + SPRINTF_END(rdirname, "%d", r); dir = debugfs_create_dir(rdirname, rangedir); debugfs_create_file("base_pfn", 0444, dir, &cmr->base_pfn, &cma_debugfs_fops); diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 6a3cf7935c14..2e6aa3efafb2 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -4780,8 +4780,7 @@ void __init hugetlb_add_hstate(unsigned int order) for (i = 0; i < MAX_NUMNODES; ++i) INIT_LIST_HEAD(&h->hugepage_freelists[i]); INIT_LIST_HEAD(&h->hugepage_activelist); - snprintf(h->name, HSTATE_NAME_LEN, "hugepages-%lukB", - huge_page_size(h)/SZ_1K); + SPRINTF_END(h->name, "hugepages-%lukB", huge_page_size(h)/SZ_1K); parsed_hstate = h; } diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index 58e895f3899a..4b5330ff9cef 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -822,7 +822,7 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft, for (i = 0; i < tmpl_size; cft++, tmpl++, i++) { *cft = *tmpl; /* rebuild the name */ - snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name); + SPRINTF_END(cft->name, "%s.%s", buf, tmpl->name); /* rebuild the private */ cft->private = MEMFILE_PRIVATE(idx, tmpl->private); /* rebuild the file_offset */ diff --git a/mm/hugetlb_cma.c b/mm/hugetlb_cma.c index e0f2d5c3a84c..6bccad5b4216 100644 --- a/mm/hugetlb_cma.c +++ b/mm/hugetlb_cma.c @@ -211,7 +211,7 @@ void __init hugetlb_cma_reserve(int order) size = round_up(size, PAGE_SIZE << order); - snprintf(name, sizeof(name), "hugetlb%d", nid); + SPRINTF_END(name, "hugetlb%d", nid); /* * Note that 'order per bit' is based on smallest size that * may be returned to CMA allocator in the case of diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 8357e1a33699..c2c9bef78edf 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -486,8 +486,7 @@ static void print_memory_metadata(const void *addr) char buffer[4 + (BITS_PER_LONG / 8) * 2]; char metadata[META_BYTES_PER_ROW]; - snprintf(buffer, sizeof(buffer), - (i == 0) ? ">%px: " : " %px: ", row); + SPRINTF_END(buffer, (i == 0) ? ">%px: " : " %px: ", row); /* * We should not pass a shadow pointer to generic diff --git a/mm/memblock.c b/mm/memblock.c index 0e9ebb8aa7fe..6bb21aacb15d 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -2021,7 +2021,7 @@ static void __init_memblock memblock_dump(struct memblock_type *type) flags = rgn->flags; #ifdef CONFIG_NUMA if (numa_valid_node(memblock_get_region_node(rgn))) - snprintf(nid_buf, sizeof(nid_buf), " on node %d", + SPRINTF_END(nid_buf, " on node %d", memblock_get_region_node(rgn)); #endif pr_info(" %s[%#x]\t[%pa-%pa], %pa bytes%s flags: %#x\n", @@ -2379,7 +2379,7 @@ int reserve_mem_release_by_name(const char *name) start = phys_to_virt(map->start); end = start + map->size - 1; - snprintf(buf, sizeof(buf), "reserve_mem:%s", name); + SPRINTF_END(buf, "reserve_mem:%s", name); free_reserved_area(start, end, 0, buf); map->size = 0; diff --git a/mm/percpu.c b/mm/percpu.c index b35494c8ede2..efe5d1517a96 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -3186,7 +3186,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size, pcpu_fc_cpu_to_node_fn_t int upa; int nr_g0_units; - snprintf(psize_str, sizeof(psize_str), "%luK", PAGE_SIZE >> 10); + SPRINTF_END(psize_str, "%luK", PAGE_SIZE >> 10); ai = pcpu_build_alloc_info(reserved_size, 0, PAGE_SIZE, NULL); if (IS_ERR(ai)) diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c index 20eaee3e97f7..9a6e959882c6 100644 --- a/mm/shrinker_debug.c +++ b/mm/shrinker_debug.c @@ -176,7 +176,7 @@ int shrinker_debugfs_add(struct shrinker *shrinker) return id; shrinker->debugfs_id = id; - snprintf(buf, sizeof(buf), "%s-%d", shrinker->name, id); + SPRINTF_END(buf, "%s-%d", shrinker->name, id); /* create debugfs entry */ entry = debugfs_create_dir(buf, shrinker_debugfs_root); diff --git a/mm/zswap.c b/mm/zswap.c index 204fb59da33c..7a8041f84e18 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -271,7 +271,7 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) return NULL; /* unique name for each pool specifically required by zsmalloc */ - snprintf(name, 38, "zswap%x", atomic_inc_return(&zswap_pools_count)); + SPRINTF_END(name, "zswap%x", atomic_inc_return(&zswap_pools_count)); pool->zpool = zpool_create_pool(type, name, gfp); if (!pool->zpool) { pr_err("%s zpool not available\n", type); -- 2.50.0