From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 177D2C636CC for ; Tue, 31 Jan 2023 15:50:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A1F56B0071; Tue, 31 Jan 2023 10:50:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82AB46B0072; Tue, 31 Jan 2023 10:50:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A4CF6B0074; Tue, 31 Jan 2023 10:50:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 52BEA6B0071 for ; Tue, 31 Jan 2023 10:50:11 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F30B9C05B6 for ; Tue, 31 Jan 2023 15:50:10 +0000 (UTC) X-FDA: 80415530622.25.FCD3F2B Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf08.hostedemail.com (Postfix) with ESMTP id D82F9160009 for ; Tue, 31 Jan 2023 15:50:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=FBtrIrhs; dmarc=none; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675180209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ie1Tu6T5P7OyMvhaX+1We9mgq07ImgIcLLeG4SwMOjQ=; b=NjJQK81CFRzqOkb+SEx+PKLrKKe0BV7Ymr2MCwKZLQWbXQtAAbQ62WIKT3p9xZqeEPFhQb KRgzWiCiwG9cII9IpD6Bx+63VMfUYEbIp/JAldQicCjGQs0t3dkrBv3TnsQDDLelZ7YOIF DHCCkoJu0c3DpEyikXVZJvYIGeGvdMc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=FBtrIrhs; dmarc=none; spf=pass (imf08.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.176 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675180209; a=rsa-sha256; cv=none; b=44Smv/4XfkI2/Uj2H4ExokS8i8dAiAmugf5Hb1RkdLksiU/I7DPP9k1syTJ86MbURoS9gs ONfzOs7w9SAlvudzm6nYLlkSxeGxYHY2Td62/HMOKGd59OBvOBJM5kXmplaJ43JCI7aFx6 v2MigiEyNsoacZpVc79cmXtmC4SXfpU= Received: by mail-pf1-f176.google.com with SMTP id g9so10509323pfo.5 for ; Tue, 31 Jan 2023 07:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ie1Tu6T5P7OyMvhaX+1We9mgq07ImgIcLLeG4SwMOjQ=; b=FBtrIrhsOIusHWuD924kR02et5pmQOo5ll3SDYlQz1OpzF3wU7RhZoQ8QkA7psTAkw O/0S6cJ9x7tC8fxl9qbqLsZgluGJH637m0WSyW+8t46HfWl5CMTucaUizbWwuzmptkzp swVL+p9joaxNus898fhg+0Rfr9UMOZHLlbfnwSwPnxk5E/UVMuAbxEiAWYtfubwOqPce JFX18ON3fu8Tqmn47ViDigQg9nZxIODr3wSQ1BCLIb02cKzR1/pthU2HZ0la+If4INIT GUq6WLZyPjb6JYNwGkTRheCsETaGvK2QX5FMYCZDFqJbRY0i434VPfnc6AEIU0DgPHil dAvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ie1Tu6T5P7OyMvhaX+1We9mgq07ImgIcLLeG4SwMOjQ=; b=p282WE+LBtE7NVRmXav9W+RZWsBxHV6A5ZLC5GGGJkkWiSwMpnO26DX6rutpwVNnOO DIgJTsBuqYuX13afL6/k2aSgq886DAqVr5T6zLhJALilHKUfv1Dh3RLIyWmLkI5eX4Hg wJD2NpXvNKVBlMoK+qA81VwZM9KSATC5ASnKy/nZik2JZ5YGsPeDb5S+pjEJF1GzY+km A4pR65+9epV5j2w23fYvRXaePq+GWWeh0QOE0N+jZIiCityryPGwTExVzCHgPSOUhHt7 qDci/DzHBHCsm4wG/JLRQKDHf96zSHvfsmzbX+juVoSlduoZh+8ajgW+ghWVD1hPx1K1 6z5Q== X-Gm-Message-State: AO0yUKX91RlJBrVM4kZqLmCb3dAfEXfhmot/7rYYeqxL5/3/bDH5FGOb eKv8k3qBfENveqq7Hsz81SBP/Q== X-Google-Smtp-Source: AK7set/Qs0lcf5OqHcsAR85kec39013TaL9a+mcutiC/DbFPsIp01hRf242WzD+iCei392fcSTBUWw== X-Received: by 2002:a05:6a00:1804:b0:587:bdcc:bf0d with SMTP id y4-20020a056a00180400b00587bdccbf0dmr149966pfa.0.1675180207578; Tue, 31 Jan 2023 07:50:07 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id bw6-20020a056a00408600b005810a54fdefsm9637183pfb.114.2023.01.31.07.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 07:50:07 -0800 (PST) Message-ID: Date: Tue, 31 Jan 2023 08:50:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] mm: move FOLL_PIN debug accounting under CONFIG_DEBUG_VM Content-Language: en-US To: David Hildenbrand , David Howells Cc: Linux-MM , "linux-block@vger.kernel.org" , John Hubbard References: <54b0b07a-c178-9ffe-b5af-088f3c21696c@kernel.dk> <057142a9-b190-905a-5539-02d9d8a5d26e@redhat.com> From: Jens Axboe In-Reply-To: <057142a9-b190-905a-5539-02d9d8a5d26e@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D82F9160009 X-Stat-Signature: 3seqye6zy8sxkk5aw74sa1ggp6mhh4zj X-HE-Tag: 1675180208-665441 X-HE-Meta: U2FsdGVkX18J7OILJoWjqwnV5B8Bl2CGVli/k6UATafNXhNnp6hsKDy6fPT0ahd/vANIyx7s1fr3bsAOQM/3OhmAIzZK/lw6IUNSFH2zC1rFVmG06sSqkyBV7uT+LDOGpBJ7iQ3Uq0nmp0ZKyY0ABbqcoBe2mwNwsf4c2znzmXQdBx5cUoeOwfSb5ATJp6+sWTIT01hSXtSwGKjIE4/PONTt9FSDcFrO5RIC/hhopQzOF9lsSLvMwTzCQEBNZ6VNL05X9fJPM8957f0AFAxT/L+Lse9nz8Ccz/QsXlqwmZkoY5C+ByG5Uvl+qndvvrLKW7jdugyer/QrWYJYVQxTtetVoLyFr8QwnsgbNfC03yZodSKP+my7gYqTTLBDd9Yhi78jhg2uhch8HuzezMqt2HdW0e76Zily1K2K+/o+UP9IFhxRZvh+Vx3XetyuaHG5kQjNqQ/LX5JZtOrTDP4lVCR1VCA1JEbMfN51TJyzaAwOUHbQwfnE8aZeCTBBoQ3eB2ADLmA6Xj1y0KskACwQqERCkj7DNRjWKbY3kpUOrbVens2lL21Sc03HOdtk5+6cWFEk305mCO+ZH84rmUzHYls/6HJhGX5wq9TQ8NnmeJzFk6512bDjzZwRex3HWWgr2MsQAL6CAMOyBvo6ADxGqpnwqVunp8lxkIS2hk8WovWNU3vOP7BPHeOV2w2UaBi5yE6LX7jRtiQlCDFfm+DteDLLZ8muUPsVq5xgMdkKGlPNjI7wS0iEd47xAIHwES2+/4XEPzdmvpPjdnrPw+GjMvV5vaKEIfAVBaN2x14qKkyT/cBh9OT9tMn5P18REzqVS1A7at4vmkzc3fJQOM7gsE1BwL1B1Qnm6uOCvs0swiariqutvkg6zliDGGxYukdexlpxsUv53owBuQWKkvB91HyER+H3CWaY1qjYr9rEwpf/rVY0lI5XptofkPbww+1xKpPJU8ZgRGM42Ra87xz ziueHxGk Bbyv3hYn5By1AXIGCwAuoQrU3qjwYdT/f2UQK7rS9OTxCItoOvtHFWHa3lhEjwFK5HRf2UrnumHTyuEZFdoLBw7qN1zPr7+FtDw4k3zrAlXUplb9/u+tT9ln35jle8ZaYBCNy2I5Q0m6zqP+aPhcJTvhU8YBCWHsJ9q6EzWOLTiSmBrXxwIf/TZ9aESf8B6yz7XKKlc/lbyAocKCXInu/RTpzjCgjH6rw+nzrpPTH3cGcQAf7MrTiTXgnp5k/c+VRFySdJfFyk8SAn8g8KxsqM07hY1lH99Zw/qjtYry2sKqgkOppalDV08g3701KQO9dM9CW4tTGud8CaOvA6afLX6LD/SxBscqr090pc9cMbmnBOaom1j7+nduKuZoTv8V/ihZk0yNuMJrlNBOKr2/P1n9UCzIBYhZxr/r1RLpciy6mQOYHyqt+A14+OUeecyIJqKf9p7DZHurBA8osPrxeNXTNuGjHMb3O69Ye29EingesaItN3fdyw/vqnNDg4E3OdgDTBlzhHY18QZN9pTWnY/iR0lxHZhaygUlgKlP+nOgAW5sAIvPH6EZaNnQymHGRVOh6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/31/23 8:48?AM, David Hildenbrand wrote: > On 31.01.23 16:36, Jens Axboe wrote: >> Using FOLL_PIN for mapping user pages caused a performance regression of >> about 2.7%. Looking at profiles, we see: >> >> +2.71% [kernel.vmlinux] [k] mod_node_page_state >> >> which wasn't there before. The node page state counters are percpu, but >> with a very low threshold. On my setup, every 108th update ends up >> needing to punt to two atomic_lond_add()'s, which is causing this above >> regression. >> >> As these counters are purely for debug purposes, move them under >> CONFIG_DEBUG_VM rather than do them unconditionally. >> >> Fixes: fd20d0c1852e ("block: convert bio_map_user_iov to use iov_iter_extract_pages") >> Fixes: 920756a3306a ("block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages") >> Link: https://lore.kernel.org/linux-block/f57ee72f-38e9-6afa-182f-2794638eadcb@kernel.dk/ >> Signed-off-by: Jens Axboe >> >> --- >> >> I added fixes tags, even though it's not a strict fix for this commits. >> But it does fix a performance regression introduced by those commits. >> It's a useful hint for backporting. > > I'd just mention them in the commit log instead, but I don't > particularly care here as long as the commit ID's are stable. Sure, I can move that bit into the commit message. > If still possible, I'd include this as a preparational change for > these commits instead. Anyhow That would be preferable in general, but I don't think it's worth rebasing the series just for that. > Acked-by: David Hildenbrand Thanks! Will add in conjunction with updating the commit message. -- Jens Axboe