From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAC8C282CD for ; Mon, 3 Mar 2025 13:39:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCCF1280002; Mon, 3 Mar 2025 08:39:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7DE26B0088; Mon, 3 Mar 2025 08:39:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1D22280002; Mon, 3 Mar 2025 08:39:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 957B86B0085 for ; Mon, 3 Mar 2025 08:39:46 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4CAD61209A2 for ; Mon, 3 Mar 2025 13:39:46 +0000 (UTC) X-FDA: 83180347572.04.32ECDC8 Received: from smtp-out3.simply.com (smtp-out3.simply.com [94.231.106.210]) by imf07.hostedemail.com (Postfix) with ESMTP id 6C05240005 for ; Mon, 3 Mar 2025 13:39:44 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gaisler.com header.s=unoeuro header.b=p0KolgJx; spf=pass (imf07.hostedemail.com: domain of andreas@gaisler.com designates 94.231.106.210 as permitted sender) smtp.mailfrom=andreas@gaisler.com; dmarc=pass (policy=none) header.from=gaisler.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741009184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U9UNcI/nx3v8USmf6+dAWPsF1rNLmjoWXEBhsh+2uHs=; b=OLcAzLVL/HVtasH6jDLPRoED6DMy03xmdpiSNxjBCzbHP1p7nkl3793YwkQOLpkLOpG/jJ cxkWfpNAudnD+R1ZH7ACpyjRTUJYhS48VWfaoqurE5UQd5NgiT8NT6D2GsulIdxZWOhT4Q Rf1xsCtnuJc9cUK0m4qLsGx0f0TvxPQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gaisler.com header.s=unoeuro header.b=p0KolgJx; spf=pass (imf07.hostedemail.com: domain of andreas@gaisler.com designates 94.231.106.210 as permitted sender) smtp.mailfrom=andreas@gaisler.com; dmarc=pass (policy=none) header.from=gaisler.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741009184; a=rsa-sha256; cv=none; b=ybbpWf872XZLYs7m3sWL1a9p57AbmjVP3Vgcd4xmjL51Hb6OE/b6CU9lm1gmizsNoNfFrI VX5PaxEudJ9x+3KjGY8F6hzpp3ewFyYpoDFqEVQhfAW7TrPpiR/QkkS60vmr7jKgk8e3zJ vsbP4yh82VUXyN9E0M2vP7v6lRAQLf8= Received: from localhost (localhost [127.0.0.1]) by smtp.simply.com (Simply.com) with ESMTP id 4Z60Kp3w73z1FbbW; Mon, 3 Mar 2025 14:39:42 +0100 (CET) Received: from [10.10.15.10] (h-98-128-223-123.NA.cust.bahnhof.se [98.128.223.123]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by smtp.simply.com (Simply.com) with ESMTPSA id 4Z60Kn4PqSz1Fb3J; Mon, 3 Mar 2025 14:39:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gaisler.com; s=unoeuro; t=1741009182; bh=U9UNcI/nx3v8USmf6+dAWPsF1rNLmjoWXEBhsh+2uHs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=p0KolgJx4p9btvk6fYlk/66A1PpkCAcDXoLwwd13tXWlLgCyaTRqeAZoowkRKGUcz a93BO8cm7m7V9NR5W2AabYKC+pmXp6QfOyzdLHkjLMMme9YAVr/Jk545VauJVRJBRF f0+BgLYnD++BR/MTcLl9Jh8F872XyJXNOzOZA4ck= Message-ID: Date: Mon, 3 Mar 2025 14:39:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] sparc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes To: Ryan Roberts , Andrew Morton , "David S. Miller" , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Matthew Wilcox (Oracle)" , Catalin Marinas Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20250302145555.3236789-1-ryan.roberts@arm.com> <20250302145555.3236789-4-ryan.roberts@arm.com> Content-Language: en-US From: Andreas Larsson In-Reply-To: <20250302145555.3236789-4-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: fczycr5pw98zfhreyr3916fyyhaaukxr X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6C05240005 X-Rspam-User: X-HE-Tag: 1741009184-261290 X-HE-Meta: U2FsdGVkX189Ae5Kv9IpTDzfyqpIFtQvK6XqMAM7lURAOnASbqAAWql/iFrxQmPiJCilV58lZoH8zi/l6SddbYa09OcGPiiiev2JxlsmbeIu+GKl+h5N7CXV1ej3CXLhnxljKqhl7ZRYlV1X2dhbN9pNaVLSRHwxJyTVL9zvwYni0t9yEOar1mxafKpnH2Veeo6dNfPdhJd+UG7XSzlu9yT0TH1zUySrqSaltItFnHZ4ZrIBGBnA5r58UoBY6jOyCLxEFAsfB4T8k4e5IiOEk56iDpp8A0nh6EMZa26+MRTu9o1i9/iIheW2AWQWbuagluSXaVoYph/7XbQgR/91wbuOD7gRxAQSi++sZA13mpHCd0wuaZo8QjqHShiNisijQtoK7XyIHd40W8nwii7yEJbr/ZXnZl2mlKrqF0MFrojLg7cWWx+rpIoT9TmYTSSv9TozwgBhx75QF+qd77sKoP7UTBNNLHp3nSHZnEFMB9q4JKiU5SP7ka+BXcaD3THSqThH/NrXjh5C70arTxiykHfn62pubtnvliCCvoNqtXafuao97h+KbLM7ZBmZ7rB9TdI83vxgfzFzawqpAohZdpozspk7cYQDhe3BO4moaRKBPjWNNRuHgBUNIclofktCFhD94IhnKNh/Zk2ffVY/pijTLlp3YReBEb8NvJR3udEjngcUSmTw7S4zpfWvnKonrAIZ+xDZbnwM8KVpdKtDjPRHQdWXXshRlpdgd8STasQT41uf5a/a9AqGZxayas4kePZAEvxWPCJwHOgAU+P43jdMDEVxC5qHLYDj23DAt94Isj1o7jFq+kbf9wa+TBgWGMTQdz5nZhoCp3ocDZHiER9DQIcL0sTTHbUc+sAVCU1lfDfwZqQ4Cxa2PHRuS6dFe3EdmDzZNae/9zbf+gVL/OmdbesSScp5f65Jv+FFPGYs1XTGpNhtZ9rNyW48nZKnQOyErxuy0HWfDkQewyO p9UbZ7MF molGKYtRowGoFoVbBiTQCPyRx7AEOKD4XzGefB1IMIFxgWE2MtwQziK7DerchPebPRbJNUgJ28LjX9HzPVjecGu0ry/dOxa23Z2UPVrv7Jt769sCgbKQhEKQU4wRZ0+5KXNdafeo2zEmgeZ8+iXInZw3bZ3Ut9lKZXK81q+WLzxjaAwC+acfTpTTxzYaSpIWEsIPT9yjxtapxElYQtDXjN6pA9nVYHzOAtGSg0rt9I4ci9kSwxp1eKMn3QrG131JUFP4WPPi+a/LhtYofVFMq/Bvm27cfMwO5oXGMy73FvYF80vfnNF2tBP4f5+MLXyYgrOu5oiTWMJaS0w4HGKERCGJ36M4XE8nzJOnLqYFzZoxtn1orfCFUNbISwXj6/ecIqW0GC22iiTBslfhAGnf+ZaZN2uKg/KSqmks7lA28QmoRc7BOgKN5fIUFP0SFNyHaGad9ksUhnXO6YLUR3wUJJQqS2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-03-02 15:55, Ryan Roberts wrote: > With commit 1a10a44dfc1d ("sparc64: implement the new page table range > API") set_ptes was added to the sparc architecture. The implementation > included calling arch_enter/leave_lazy_mmu() calls. > > The patch removes the usage of arch_enter/leave_lazy_mmu() since this > implies nesting of lazy mmu regions which is not supported. Without this > fix, lazy mmu mode is effectively disabled because we exit the mode > after the first set_ptes: > > remap_pte_range() > -> arch_enter_lazy_mmu() > -> set_ptes() > -> arch_enter_lazy_mmu() > -> arch_leave_lazy_mmu() > -> arch_leave_lazy_mmu() > > Powerpc suffered the same problem and fixed it in a corresponding way > with commit 47b8def9358c ("powerpc/mm: Avoid calling > arch_enter/leave_lazy_mmu() in set_ptes"). > > Fixes: 1a10a44dfc1d ("sparc64: implement the new page table range API") > Signed-off-by: Ryan Roberts > --- > arch/sparc/include/asm/pgtable_64.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/sparc/include/asm/pgtable_64.h b/arch/sparc/include/asm/pgtable_64.h > index 2b7f358762c1..dc28f2c4eee3 100644 > --- a/arch/sparc/include/asm/pgtable_64.h > +++ b/arch/sparc/include/asm/pgtable_64.h > @@ -936,7 +936,6 @@ static inline void __set_pte_at(struct mm_struct *mm, unsigned long addr, > static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > pte_t *ptep, pte_t pte, unsigned int nr) > { > - arch_enter_lazy_mmu_mode(); > for (;;) { > __set_pte_at(mm, addr, ptep, pte, 0); > if (--nr == 0) > @@ -945,7 +944,6 @@ static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > pte_val(pte) += PAGE_SIZE; > addr += PAGE_SIZE; > } > - arch_leave_lazy_mmu_mode(); > } > #define set_ptes set_ptes Acked-by: Andreas Larsson Thanks, Andreas