From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f197.google.com (mail-qk0-f197.google.com [209.85.220.197]) by kanga.kvack.org (Postfix) with ESMTP id 25BCC6B000D for ; Fri, 10 Aug 2018 07:23:35 -0400 (EDT) Received: by mail-qk0-f197.google.com with SMTP id z18-v6so8775402qki.22 for ; Fri, 10 Aug 2018 04:23:35 -0700 (PDT) Received: from mx1.redhat.com (mx3-rdu2.redhat.com. [66.187.233.73]) by mx.google.com with ESMTPS id 2-v6si2516526qto.190.2018.08.10.04.23.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 04:23:34 -0700 (PDT) Subject: Re: [PATCH V3 1/4] kvm: remove redundant reserved page check References: From: David Hildenbrand Message-ID: Date: Fri, 10 Aug 2018 13:23:29 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Zhang Yi , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, pbonzini@redhat.com, dan.j.williams@intel.com, jack@suse.cz, hch@lst.de, yu.c.zhang@intel.com Cc: linux-mm@kvack.org, rkrcmar@redhat.com, yi.z.zhang@intel.com On 09.08.2018 12:52, Zhang Yi wrote: > PageReserved() is already checked inside kvm_is_reserved_pfn(), > remove it from kvm_set_pfn_dirty(). > > Signed-off-by: Zhang Yi > Signed-off-by: Zhang Yu > --- > virt/kvm/kvm_main.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 8b47507f..c44c406 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1690,12 +1690,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty); > > void kvm_set_pfn_dirty(kvm_pfn_t pfn) > { > - if (!kvm_is_reserved_pfn(pfn)) { > - struct page *page = pfn_to_page(pfn); > - > - if (!PageReserved(page)) > - SetPageDirty(page); > - } > + if (!kvm_is_reserved_pfn(pfn)) > + SetPageDirty(pfn_to_page(pfn)); > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty); > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb