From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997B2E732C8 for ; Thu, 28 Sep 2023 13:05:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13B4A6B01A5; Thu, 28 Sep 2023 09:05:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EAF86B01A8; Thu, 28 Sep 2023 09:05:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF5066B01AA; Thu, 28 Sep 2023 09:05:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E13C76B01A5 for ; Thu, 28 Sep 2023 09:05:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AC189140E21 for ; Thu, 28 Sep 2023 13:05:23 +0000 (UTC) X-FDA: 81286027326.19.F2CCDF7 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf10.hostedemail.com (Postfix) with ESMTP id 1D655C03E9 for ; Thu, 28 Sep 2023 13:04:04 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nyq0dCCp; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.43 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695906245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=omorxDUJU6DA7j6L5QbKAtoIJ23+upKuuEHJSKVOvtI=; b=Zd1cXC/vHCpmVH75kE+1hJJxjbq+BfbCW/RoM6xX4ixhPpVS8BqXKW4Q5aQy2uqid8h52Z OSof7oB9LAzBiK98/VL+5hbn61D043yUWm7sK1Kjp0p1Iwql6WVeFfIC8jpp64FeF0HfYu iaKlzel50Roq+39zHXT042WiDArCifM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=nyq0dCCp; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.43 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695906245; a=rsa-sha256; cv=none; b=zM/H43++qOghxI7HanmyY+muvuf03C2qg41n1qj7q1NGd/VkdQaCTcfAhasz/M3xxEKh8P 21kCrhEssMefgy/jx6sdremEFCL+Q8rUzaxWVJMS2lQqHR+zfx2Fx6NBsiQm2rDHg2ok9r dSjAWFWS2j/wQSZiCWWELU3OqjKUFRk= Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-405524e6740so110528695e9.1 for ; Thu, 28 Sep 2023 06:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695906243; x=1696511043; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=omorxDUJU6DA7j6L5QbKAtoIJ23+upKuuEHJSKVOvtI=; b=nyq0dCCp50YTO8Zu9Twto/K2uJJ36FSl99HjEFbyGE0akrSnXmfntXTePhqmQ3w9Xc FCjY3gPqiavg3OIp5OjCQ9Mk/U2soBsoAMo3YYxj4CTypo0wehHGkPko3YWF9OfKeSvC +PI/slODie+SqkG50reffLOs3krBCOb6Huh0mL6WPRHw27xsUqX56YtocNsfZIHbQmuA 9l1b2kxQ3gDp+XcEQt7lavX4GH2+9JUvvYnM+U3Ujs1TUXfKWPI2UqnRLmUlnrSRUppT bVZ9tH/r5/zS2jDZItaxeLjnjjceJpvJp4Zlal/evdtsOEXpVCYheaIREELmYcjEPhUt aMAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695906243; x=1696511043; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=omorxDUJU6DA7j6L5QbKAtoIJ23+upKuuEHJSKVOvtI=; b=AY0d08UY7xZmSKdkX8KAq8Xf73nzOOrzl0yuUqp98LAD87ZldO5/6Vdg3PHa2yn9Q2 MEqhTk13q5CTuvg0RPczv8wptXtaT/qKTEiQ0y9PdO/HZ7xr2X0Lo/tWIre2J4y42I3I Z5JBrwmA87AuZ1Fqucam4OzCIeVbwzPVPne/ogLk+DopRbdXlMVkyOCUSSsoi7IGCNDv y3TIYyuzJt9qA41iyRDyxMmXLtTJL6zle0Vq18qwtC7611vKZi/u+Wa/RCZ28qSMVmDV NmWAmnd58YHHVI088C5P06PF+3/NllFQXdlwYldCb29ilLbujyovDnesq+SYD+ot6mKc fTXw== X-Gm-Message-State: AOJu0YzcLn+JsUqzaaB8KWNVSEy7Epkehuszh8k1yGGURgK9bqCvwq92 O+zYpSXnCgIfjY/wVXPG3Us/DA== X-Google-Smtp-Source: AGHT+IGBuT0iLB2Mu0svfei/QYlffmqz7XA0ltE6E+aOKtprrONLRrAAVcsZ2hCCeNc8H9mUPBQhNQ== X-Received: by 2002:a7b:c456:0:b0:401:eb0:a98d with SMTP id l22-20020a7bc456000000b004010eb0a98dmr1179307wmi.24.1695906243379; Thu, 28 Sep 2023 06:04:03 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id q25-20020a7bce99000000b00405ee9dc69esm7569293wmj.18.2023.09.28.06.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 06:04:03 -0700 (PDT) Date: Thu, 28 Sep 2023 16:03:59 +0300 From: Dan Carpenter To: zhengqi.arch@bytedance.com Cc: linux-mm@kvack.org Subject: [bug report] mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred} Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 1D655C03E9 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ws7du1y7c3mgdhy1ij57buxp5w944ii5 X-HE-Tag: 1695906244-529826 X-HE-Meta: U2FsdGVkX1/04+d4QaO/HEyqS9KXcrPdY1vGroNptgEQ3eToCFej9/+9AV5XUqZ/SNv5SIH1v70KtTqXgP5oRI16GD/51btrGydrXpBQ0uFpsrEVcTTRApgzATUoZtsMqyHf8VryhNf4K2fyaiXvtszIrcVB0B3uZbxykn2D1Cznt7Bg159nl4zyRedj33PFkkXALY7jdRx5IhsKhhsgETCDefY6beSpoKNUbwagPrHfQa8KVKqBOU0v5lbeiQFhic2eTVlS6csDCCPI2QH/X1IHC8bze+mo0JkuvjIK9/hBjLVvwHbUbBW//rMFaw8Oaf6SCyYunFqJaQuSI+pwgtGe5793zX2rCVzFvfpbHZWMYHGYlYIOKnriq9hi6r8M81zoXvArxD8u+n4Sej3gM6CXizMZa3V2wDB7vqX/j5J35VuYDIVAB0JIFj3Iqfk6G5RwJ0fuxzEtjscxOfo5+N6ktavyH3Abx6R3qXgnO9p33IUp45RtnJBv+d5A+xIYqpyPOsEpuOWF8Ow9gcvRKOFaX7tfjCj6fNMNXvlOIoAVhMgXlcx30WXGTAqhwpY3Z+jJhZ2ObK9QdtO9LdAzMqSN2av7XT4589QDOpKl9O5hUBtAK4fO5ei6pJiZKs0rgVyFAWn+eotsaHbjN2c8vDSsIaGdEAV/FYeG2oA1krb4EjXMkmtJALYQIonOVkKk1c64HyGDmKC7mOMcIe13OJoqMzS8uqEo0tX8wavhCnGwOZetrz5rIvPmHtXhb6mQ1WWWQFFGmqSJvoK4Ffk1I6b2PEb0F5jVutcqrHO6Es0bvyt8BLSV4HGObM+iGutPS1UOgzloGAAOa3RNWF1ulOB71i4rg9ahNiDhgeYABCnBQY+rFOKNFi6tPE2ZsX5jmKr+R8fhxeeBuUn6+98hChEMz8FUzE/kEaTuO4A2i4lUPsvyFu9Mc+wRZ60LXasITkGpClwGcQs8p6NrzXK 7d/REW8G VVUXDI4jFsrA0uWPUKdEaf36Lg1uirGgHmglQFNPDOSpzuicGHAUR7Gm8XAvOr0QS6sPbrgxCeAAaDgyZgenqghhLQTla68DF+aQdB0zeRAR/AzLeY1zOK1DulKmd62oigWDzuCdbG7qRs7PPkTzzzE9Ag/49CI65LpgiQzEuQG2YsduOxLh/exzYKy5GRMrH6v9eTscMYkCz7KFP7ZfCU5L6sF/MW9Ip7A7iH5dEoIYQpJhwyKW54OAQ/P2iUSjnXW0xjDyLxj68/G4I0UQCZlE92KVuk2O04dSPJ/EByo5qS+/E1j+A9kgB9X5rn/3tngUgO6hqyQUTYFeNLSuMuwu1R0tgRbt8Ikgp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Qi Zheng, The patch b6884b5f15cf: "mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred}" from Sep 11, 2023 (linux-next), leads to the following Smatch static checker warning: mm/shrinker.c:100 alloc_shrinker_info() warn: inconsistent returns '&shrinker_mutex'. mm/shrinker.c 77 int alloc_shrinker_info(struct mem_cgroup *memcg) 78 { 79 struct shrinker_info *info; 80 int nid, ret = 0; 81 int array_size = 0; 82 83 mutex_lock(&shrinker_mutex); 84 array_size = shrinker_unit_size(shrinker_nr_max); 85 for_each_node(nid) { 86 info = kvzalloc_node(sizeof(*info) + array_size, GFP_KERNEL, nid); 87 if (!info) 88 goto err; ^^^^^^^^^ 89 info->map_nr_max = shrinker_nr_max; 90 if (shrinker_unit_alloc(info, NULL, nid)) 91 goto err; ^^^^^^^^ These error paths need to unlock. I'm not 100% positive if you want to unlock before or after the call to free_shrinker_info(). 92 rcu_assign_pointer(memcg->nodeinfo[nid]->shrinker_info, info); 93 } 94 mutex_unlock(&shrinker_mutex); 95 96 return ret; 97 98 err: 99 free_shrinker_info(memcg); -->100 return -ENOMEM; 101 } regards, dan carpenter