From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 885C6C83F01 for ; Wed, 30 Aug 2023 06:51:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 033D38E0046; Wed, 30 Aug 2023 02:51:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F25148E0009; Wed, 30 Aug 2023 02:51:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E139B8E0046; Wed, 30 Aug 2023 02:51:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CE4548E0009 for ; Wed, 30 Aug 2023 02:51:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9542C14024F for ; Wed, 30 Aug 2023 06:51:10 +0000 (UTC) X-FDA: 81179849100.29.DF714A7 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf09.hostedemail.com (Postfix) with ESMTP id 75C58140014 for ; Wed, 30 Aug 2023 06:51:07 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=none (imf09.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693378268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+R1F+7vPhIXTLDC5z5AyYG91oUAirtkF+DVw7HPkdtk=; b=bIwhxRpm/d6ntARISUBnNmNbOLIiCS8KJVv9cN1yNQL5g+WN653RVWtwAYL8dlCBolbZqJ J5I4fhouZWfhvXeszG3Dd8FpVkvTelhGZDuj9BHq9CAVTdpf3mk4DpgUzoqUQKfurS8YYm n1zIYDpFnqq/8m158T4XDCOXWZJtVEQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=none (imf09.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693378268; a=rsa-sha256; cv=none; b=y8tE1C/quAFvzL+uiNy4jJnHyXxSX8z7oy8Um/KQKybYnhueKYWYejY+teKs4wRLHCMN9J cfgzkQbBYakuLGoK4rcXyGsOxKsoGbr3Dl6lhec6B84y478Ne7m9zO+U35U2QVyKd+s2Zk +QnbVebZrfakKAFqU7M4ccuRAVkzjfI= Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RbFLV3fPMz4f3l8W for ; Wed, 30 Aug 2023 14:50:58 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgBXecHS5u5kO1E_Bw--.63649S2; Wed, 30 Aug 2023 14:50:59 +0800 (CST) Subject: Re: [PATCH v2 3/7] mm/compaction: correctly return failure with bogus compound_order in strict mode To: Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-4-shikemeng@huaweicloud.com> <20230829093909.4hpria3qtouvdv6a@techsingularity.net> From: Kemeng Shi Message-ID: Date: Wed, 30 Aug 2023 14:50:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230829093909.4hpria3qtouvdv6a@techsingularity.net> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgBXecHS5u5kO1E_Bw--.63649S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtF4rtw43tr4xCFyftr1DJrb_yoWDGrbE9r WkAFs7Aw1FgrnxA347uw17tF4fK3yxCr15Cry8GFyUu3yqvF43J3ZrAr13Za15Ja4xZwnx C3Wruw4jyw1YvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb7xYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0E wIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E74 80Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0 I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04 k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIE c7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07UQzVbUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 75C58140014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wugynu7nsq4g7dpru8atda18c7oy5p9h X-HE-Tag: 1693378267-321612 X-HE-Meta: U2FsdGVkX1+wc3OrRJq368qhkoM85LpJFFn9H7hY5bKCepryVVIeKcvO27DCW/ma2zvGGALRgxDYZd630kLU8azGPWRwgag47O+cVme786E16FCiv6U5jPOH2+o0U8ap1GiA9Rg3xxRdxij1aQJeJliA2PQRyKFxYQzDTmFAc9p4wgneW+UZsB1YPglSwdgLQy41ULbZjOQILC+ovxb0iUrRXzDEfjKCR/zfFQ3l1IsWni9QZV5FE6At/zQklgE9SflWBYVhRgnrfLO+yZ1+VDM6r1eywM1Fas8DnC/OItdSyLK4u6Cb4O6NufD73UDkxdFBipUVt5ujBb6pIFTqiCbAGq4WEGbCalcfhs4Qw3EhSvH2bCces+ICKImIZA6rhXtT0HjsktJDvmhRpAPJRIAyzbWQOQKZA67IMHBvAUzFuneWRcx7chtvY19mmhvTm8jGxV0UM+PohGwOuMN6iFgmIGt6z3wlkqpM1I2F8XjmMumx23z8WA7dwa+Yqftumwv06FIfkKvq2aqfvXWLaSo8LjEa3702LCy9kIQMJnpw4mdCBxDQ5k0Yd2Tjj4Jic5BY5ezpIN40iIGpgYRMET6hmi00JD2SnMJh/uBtCvGiIeptHglN4srARDNtTs5Cdr3ahi/gQKUqRCIz7WcL0fQD5whEwsuPC11IGwJl+tcM23yQt3Dg95uRjlFISnU8NtdKJx0n4a2aTgZencfqsC26SonudeE4YDTILZ+6puXNjWsuXdB78An8CiD2OL5xEd4seMpxFxKDVvH5JFdrtqpMFzWDAVq6nHP6CRp7qbJegORrrpPBq7wxZJz4cplh0qyPcYSejAhN5GuUyTV5a+mGC0OMBS5BNfFh5tqYAh1Mfv1Uj/BnA7AYlcNrNTMe+cetaWMOAIzH+UFEfE71FmXUa0iUCx7+R75yX/Rzbgl4ZY7sIcKs9yPvHgY0iDutbOo2r+r516mG4q9CxyZ deGTxyHE L+ZX9IEVbhhIg1gQxRbA88HykR7YBSR5L9nwv0rUkTvtNbAHTy/tNFhhWCGr8VXp1j6oRHHtD2mW/LNJ6Qe7q1Et/rf2uonJt2F6OLaMNXX8P7nNYSsspV7uzNx8msPL55fQFCBwrLz3Y1/RZ2vANC9Jxr7Y8WmyV4HNWL4WNEf+JdC54SQGJZmp2KLHMkCtP3bhAMEUJ2SNbh8Vba1GjLHBeOBZA6n5LbGuuBikQBJtR0TpJLRyMIWDMbq4RQ7MQnMo2LLgGr8DhBNjQTXjc+x2GTQ2Hls1a9ck0mkzGr/Yj4fY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 8/29/2023 5:39 PM, Mel Gorman wrote: > On Sat, Aug 26, 2023 at 11:36:13PM +0800, Kemeng Shi wrote: >> In strict mode, we should return 0 if there is any hole in pageblock. If >> we successfully isolated pages at beginning at pageblock and then have a >> bogus compound_order outside pageblock in next page. We will abort search >> loop with blockpfn > end_pfn. Although we will limit blockpfn to end_pfn, >> we will treat it as a successful isolation in strict mode as blockpfn is >> not < end_pfn and return partial isolated pages. Then >> isolate_freepages_range may success unexpectly with hole in isolated >> range. >> >> Fixes: 9fcd6d2e052ee ("mm, compaction: skip compound pages by order in free scanner") >> Signed-off-by: Kemeng Shi > > Modify the (likely(order <= MAX_ORDER)) block to avoid ever updating > blockpfn past the end of the pageblock. Then remove the second redundant > check. > Sure, I will improve this in next version.