From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B2D6C07E95 for ; Fri, 16 Jul 2021 12:59:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 29A6D613E9 for ; Fri, 16 Jul 2021 12:59:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29A6D613E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7FCCC8D00F6; Fri, 16 Jul 2021 08:59:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 785088D00EC; Fri, 16 Jul 2021 08:59:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D8F68D00F6; Fri, 16 Jul 2021 08:59:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 329E08D00EC for ; Fri, 16 Jul 2021 08:59:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E9EF328486 for ; Fri, 16 Jul 2021 12:59:18 +0000 (UTC) X-FDA: 78368456796.07.AE8309A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 83196D0000BA for ; Fri, 16 Jul 2021 12:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626440357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/E38vCggOBKVR3p8p3Q4Jef+K2A5RWkpHXZoCknxgoA=; b=OKKUwHiDIeYBbc1oFoh6VhPT2/t8rRYqUNYoiuo0zUSoQ2IKmWKnL5jtzfnWg/O1OP+aIU 7ZKGK2OEeqiLpcdaTbM7Y0g4iW4TRurKbGQJBl0jB60JFyIW/5bMMiHIH6oUXN4gefx7uj K+dBQ4KcwsFDM/q0B0bLgk254cBEOL4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-aWunxdz0MlyXWwwNCNEQoQ-1; Fri, 16 Jul 2021 08:59:16 -0400 X-MC-Unique: aWunxdz0MlyXWwwNCNEQoQ-1 Received: by mail-wr1-f72.google.com with SMTP id y15-20020a5d614f0000b029013cd60e9baaso4790578wrt.7 for ; Fri, 16 Jul 2021 05:59:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/E38vCggOBKVR3p8p3Q4Jef+K2A5RWkpHXZoCknxgoA=; b=TZiBTUFM9dl7xw5ENwKRTU6/aTovi3zNnduktUhzrOx4OyGz7rBW/niXv1AeEhFwlZ zGuD7QHcq/w68RLsExeK4F1Lwnvizz4RFwBClFAOOBw9Cvj2Oam7RHzCYtrLvUMuw/zF FUWkEL2PQjQbQobbepXIMGo6QddEK43oyRffbgUUwrIXmRIpFCo0osmAwNgF21q25b9r vDLr6shOu7ARgxZ2xiVB4/CMVqnR7lHFJ45hAZ29qRAXR6kOWztUMfWH5YaMrRBMBtuH aXwW04HBSOYWonrqCrSfCQGQjnLilmzld9vtabDPv4AxOaxvyERU7ZqYlWzNLZg5AK53 /UDw== X-Gm-Message-State: AOAM530j3pwqL/+BlhsYaheMqD+urbPJhdnFAAF0I9yKHfisaJDG+v+S VoiY0JsKORz8uA9022bbaQ5sWKSKJnSUFXOMxQymmBO2jYXj3lF15b7rgx6W1urd7r0fcgs7uT/ DBA6AKjRxYZQ= X-Received: by 2002:a05:6000:2a1:: with SMTP id l1mr11962711wry.128.1626440355334; Fri, 16 Jul 2021 05:59:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVNVuudcvKFRSJKwazJh7rObTjbVK7ZYCl+TaQuI4AkyJjJMv7QgZhE0mkK3DAA+amKSH1xg== X-Received: by 2002:a05:6000:2a1:: with SMTP id l1mr11962688wry.128.1626440355105; Fri, 16 Jul 2021 05:59:15 -0700 (PDT) Received: from [192.168.3.132] (p5b0c621f.dip0.t-ipconnect.de. [91.12.98.31]) by smtp.gmail.com with ESMTPSA id h130sm811710wmh.1.2021.07.16.05.59.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jul 2021 05:59:14 -0700 (PDT) Subject: Re: [PATCH 3/3] mm/vmstat: remove unneeded return value To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210715122911.15700-1-linmiaohe@huawei.com> <20210715122911.15700-4-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Fri, 16 Jul 2021 14:59:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210715122911.15700-4-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OKKUwHiD; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 83196D0000BA X-Stat-Signature: i3domcueeyddttrnxpt6z4i58t6768z5 X-HE-Tag: 1626440358-106703 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.07.21 14:29, Miaohe Lin wrote: > The return value of pagetypeinfo_showfree and pagetypeinfo_showblockcount > are unused now. Remove them. > > Signed-off-by: Miaohe Lin > --- > mm/vmstat.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 76aef9510f6d..6246bab9fae2 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1452,7 +1452,7 @@ static void pagetypeinfo_showfree_print(struct seq_file *m, > } > > /* Print out the free pages at each order for each migatetype */ > -static int pagetypeinfo_showfree(struct seq_file *m, void *arg) > +static void pagetypeinfo_showfree(struct seq_file *m, void *arg) > { > int order; > pg_data_t *pgdat = (pg_data_t *)arg; > @@ -1464,8 +1464,6 @@ static int pagetypeinfo_showfree(struct seq_file *m, void *arg) > seq_putc(m, '\n'); > > walk_zones_in_node(m, pgdat, true, false, pagetypeinfo_showfree_print); > - > - return 0; > } > > static void pagetypeinfo_showblockcount_print(struct seq_file *m, > @@ -1501,7 +1499,7 @@ static void pagetypeinfo_showblockcount_print(struct seq_file *m, > } > > /* Print out the number of pageblocks for each migratetype */ > -static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > +static void pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > { > int mtype; > pg_data_t *pgdat = (pg_data_t *)arg; > @@ -1512,8 +1510,6 @@ static int pagetypeinfo_showblockcount(struct seq_file *m, void *arg) > seq_putc(m, '\n'); > walk_zones_in_node(m, pgdat, true, false, > pagetypeinfo_showblockcount_print); > - > - return 0; > } > > /* > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb