From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC4AECAAD8 for ; Wed, 21 Sep 2022 10:14:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F79E940007; Wed, 21 Sep 2022 06:14:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 280BB6B0073; Wed, 21 Sep 2022 06:14:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 122A7940007; Wed, 21 Sep 2022 06:14:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F32156B0072 for ; Wed, 21 Sep 2022 06:14:38 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C2CFF81031 for ; Wed, 21 Sep 2022 10:14:38 +0000 (UTC) X-FDA: 79935683436.25.865C43D Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf05.hostedemail.com (Postfix) with ESMTP id 5126F10001E for ; Wed, 21 Sep 2022 10:14:35 +0000 (UTC) Received: from [10.180.13.185] (unknown [10.180.13.185]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bx32sG5Cpj+WYfAA--.45921S3; Wed, 21 Sep 2022 18:14:32 +0800 (CST) Subject: Re: [PATCH] mm/vmscan: don't scan adjust too much if current is not kswapd To: Mel Gorman Cc: Mel Gorman , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220914023318.549118-1-zhanghongchen@loongson.cn> <20220914155142.bf388515a39fb45bae987231@linux-foundation.org> <6bcb4883-03d0-88eb-4c42-84fff0a9a141@loongson.cn> <54813a74-cc0e-e470-c632-78437a0d0ad4@loongson.cn> <4bd0012e-77ff-9d0d-e295-800471994aeb@loongson.cn> <20220921091303.hihmb3qvfvl3s365@techsingularity.net> From: Hongchen Zhang Message-ID: Date: Wed, 21 Sep 2022 18:14:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20220921091303.hihmb3qvfvl3s365@techsingularity.net> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CM-TRANSID:AQAAf8Bx32sG5Cpj+WYfAA--.45921S3 X-Coremail-Antispam: 1UD129KBjvdXoWruF18AryDAFW5ur15Zw47Arb_yoWfCFg_ZF W8Ar4vkw4qqF4qqay3tr42krs7WryvkFy8X3yrXwnF9a4UKa4DXFykt3s3X3Z5tan7t3sx CFyYv345Ar9a9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbx8YjsxI4VWkCwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCY 02Avz4vE-syl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1D MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07j04E _UUUUU= X-CM-SenderInfo: x2kd0w5krqwupkhqwqxorr0wxvrqhubq/ ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663755277; a=rsa-sha256; cv=none; b=R5iyP2xAJgqc5/YLyqsL2MfybcPP+2FhxN1TiTSLbUTHsKa8WDu2tN3krxTqFr/jdZCvVL 9dZxdZ/DSB5Chmkvx2WAyAtRMZsaplz0ofjZgv1YgEXbjitOtrtVsBe4wKGI2cKuWFoaFE NL3vLSVzY/LIMnsVn2sH1D5xhim8Iqc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of zhanghongchen@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=zhanghongchen@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663755277; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSiSh1obMHYvuA+1uiyqrcGYHFrEodT/dyXvAzDIB+Y=; b=JhSWnlaFubVW1p8PCkpEqbu+c4DR4BLR4UyybQ3D8qB8cxydtY/fnhZbiPJM0qxOqwxLYu S5Uki+qs61P4gT239MDcsqMaLPYfSBRKxq8gjfzjvatJqAoHc79p+IpQkYRirUKV9RQABT WZEQpt1/MTLxz9y2+qWS0KjmJXWnx+E= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5126F10001E X-Stat-Signature: jpep414n4ddmoontcggey9uftyqni7mx Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of zhanghongchen@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=zhanghongchen@loongson.cn X-Rspam-User: X-HE-Tag: 1663755275-785482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mel, Thanks for your reply. On 2022/9/21 pm 5:13, Mel Gorman wrote: > On Tue, Sep 20, 2022 at 10:23:05AM +0800, Hongchen Zhang wrote: >> Hi Mel, >> >> The scan adjust algorithm was originally introduced by you from >> commmit e82e0561dae9 ("mm: vmscan: obey proportional scanning requirements >> for kswapd"), any suggestion about this fix patch? >> In short, proportional scanning is not friendly to processes other than >> kswapd. >> > > I suspect that 6eb90d649537 ("mm: vmscan: fix extreme overreclaim and swap > floods") is a more appropriate fix. While it also has a fairness impact, > it's a more general approach that is likely more robust and while > fairness is important, completely thrashing a full LRU is neither fair > nor expected. > OK,got it. Let's wait for the 6eb90d649537 ("mm: vmscan: fix extreme overreclaim and swap floods") enter the stable repository. Best Regards Hongchen Zhang