From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD89C3ABBC for ; Fri, 9 May 2025 09:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7A358E0008; Fri, 9 May 2025 05:38:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B28BD8E0007; Fri, 9 May 2025 05:38:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 955058E0008; Fri, 9 May 2025 05:38:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 72DDA8E0007 for ; Fri, 9 May 2025 05:38:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 39F5D1A0801 for ; Fri, 9 May 2025 09:38:12 +0000 (UTC) X-FDA: 83422868424.17.E097858 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id A39FA1C0004 for ; Fri, 9 May 2025 09:38:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eliBvBGO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746783489; a=rsa-sha256; cv=none; b=Zugrqcc7PdZW6FlWjdWZDJxKedDGrea+Yb7QUI7r4br/fjlisvXbUcC37rwTIhpuJqwRpr dtyoisQ448SudfI/tZ+0Y3DqUD3ok6PmqMugbbetkx0JZrajStCipofGO/c9e0jyL8vnuS khn5cH8V7UDTOLQHWFgXnf6Lg+FNP/g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eliBvBGO; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746783489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3hUhtyxYJYbw99c3I/tz5acTbZ7x9KccXKxTFtyDPoE=; b=0X+bz+EHmUI452dpF+Srg64COgInmh0HOCGr+lCFaFPTqtcXffSaeLnB4Y3I5ZNVvHu01V llgiJ9Y7JTxPtTxu2eqOfc5Nn4xSaYX/Po14TltOb5/bofWsPryjY/p1pR1D5Er55Sc3VM 58wUqKGZUNur7ZzAQ/OSkLqfIjRQaVA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746783489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3hUhtyxYJYbw99c3I/tz5acTbZ7x9KccXKxTFtyDPoE=; b=eliBvBGOjeQzwMUU8k1qRGcYicyOkD4IOW7/TW85ZDrQ2mhyF5RM0rm0STmdHY7bjlKI96 zmaRC7pwaul50itXkfgQoIDu7xeJ41Du8PQNWqcbnE7FdXYxkifwMlpahLyzfQk2S1lI/x ichNgtqgqmnP9zreaNUTo/3BJ1E3ud4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-Q7fvkxZuND6DxtdO7ys6Lw-1; Fri, 09 May 2025 05:38:07 -0400 X-MC-Unique: Q7fvkxZuND6DxtdO7ys6Lw-1 X-Mimecast-MFC-AGG-ID: Q7fvkxZuND6DxtdO7ys6Lw_1746783486 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cec217977so9517685e9.0 for ; Fri, 09 May 2025 02:38:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746783486; x=1747388286; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3hUhtyxYJYbw99c3I/tz5acTbZ7x9KccXKxTFtyDPoE=; b=MViyFQu1ObDbitDT5/VKE+h9cAYQD6fG5gmlPz9aYRoq6evUZNvabpubtxj5p8TT04 0InokLSj43vHu0cG3b7NWEquxtSdVDLJZIoodKvFuG0akbLod8vujPklnOL6AkTpwLV/ whX1edDO1KI/mA3tOXaUJcZu655DKfm+xTEeC48LPleWPRzBPAL30NH67j/UluaJdzIU oDCgjhyeP2zPFp2ufFRPFz0wkX+n8CHkxdYbVnaSuydKC9J4W6rEKcmWi99XFP/GtUJb T51T0NJGmNMhzFccySshbPhuCEmaQrGmkDtbFeP51K4h/ElAdaDBsAqPQweqJf61Redr Cuag== X-Forwarded-Encrypted: i=1; AJvYcCWDH/lar7LnM5UqWjTGdcsP+ll6JW/B/Na6l1duMWeECL/ugD4GyIhT9BF1WNK3n9zb9rMpXKqZEw==@kvack.org X-Gm-Message-State: AOJu0YxhIO/W7f4ZQW05eZYYqcimsdFo1NiwEEbzWQc5P2M5tuYrk8kI gg/Lb801vUELp58aesF7exTnD4j5kp4J+0y4/LHvulgln0Rl8XaqR09h6g39PR/XBZsiN9TvO5J ynIAJtQU2jcLvp9ySjzIQ/d7D9yeA5fp5KwFiCMDz0iRECW9k X-Gm-Gg: ASbGncsc5+v8KV26wNFlF+Wxi8IMC2l7YOW30yLgt/ukDYTvXQ2+SwnwVizj9kJx+1q mXolF/1b0WoRVplEtt4VRr0hgh+Ykf0OpviIhKtg529W53MdZTuscUv90+82dv2ffNXnlfobVD6 Bjn1DmZXCPCvaHKwRZVLRJkuPJJONt/1fH+7RNSqnCv/aMf+yKgA/Aihrs3muljxRvZUAqENh+r gVWoWyYHajZZo9SeRcailRAQsG0HIus+9h6F9qvfJjz/Jz7evAELa/0FmyN2SMntX+oFNedSWsV 7lpO1xJs0XTSZh6P56qNNIwJQhSp55w9UniL5G5U9oro1/N+o8SvyVsR4k5qo13/OwC7ZM/lkuR yWydNfmR4gwj/0DUYP0AHSRx2Z0jfA8BQtO0GSRc= X-Received: by 2002:a05:600c:548d:b0:43d:ea:51d2 with SMTP id 5b1f17b1804b1-442d6d44918mr20687455e9.14.1746783486434; Fri, 09 May 2025 02:38:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcTro5FHgTcGgAPOwFLaYfLvXYGrp/OdrqtZgrae9BTUGXusjtXgLtdT+shONyKdv0GJTp0Q== X-Received: by 2002:a05:600c:548d:b0:43d:ea:51d2 with SMTP id 5b1f17b1804b1-442d6d44918mr20687265e9.14.1746783486027; Fri, 09 May 2025 02:38:06 -0700 (PDT) Received: from ?IPV6:2003:d8:2f45:5500:8267:647f:4209:dedd? (p200300d82f4555008267647f4209dedd.dip0.t-ipconnect.de. [2003:d8:2f45:5500:8267:647f:4209:dedd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442cd3aecb0sm66649365e9.28.2025.05.09.02.38.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 02:38:05 -0700 (PDT) Message-ID: Date: Fri, 9 May 2025 11:38:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Memory hotplug locking issue: Useless (?) zone span seqlock To: Mathieu Desnoyers , Andrew Morton , Oscar Salvador Cc: Michal Hocko , Anshuman Khandual , Vlastimil Babka , Pavel Tatashin , Linus Torvalds , linux-kernel , linux-mm References: <8a4a5d6e-d2cf-420d-91f3-2797618e7255@efficios.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <8a4a5d6e-d2cf-420d-91f3-2797618e7255@efficios.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mbJccKrbjt5TnTnBjxhBIKs0ok6dfSrt_gL66Acxzaw_1746783486 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A39FA1C0004 X-Stat-Signature: mskrrp38w6gg666am81gjw7sugswnpxc X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746783489-552754 X-HE-Meta: U2FsdGVkX1/IpBqns+puLeMvBGzW9ZX0EkuqzF64ME9+C+F2OHdhFTHHNmGF2i3gLjudWM/uIHtlNt90I+N4vkvqlOZM7MwcOPjHzBEzEg9ryrtfDQrVk73o3KueCVd2prZ35e1APQzBQlFh2jQ01yN70uWsNpyWJdkd+Ou0BV2CUDy0DbLKyrdsFonYrAXlQ24fCZwIaiOCi0pKzbjo7D7THBzKdnZVDR+1QrAg+xsueas7a23eF3SoGljWrSnKRRt3essdQBDGpK2lhkSQFqX85AHezcMkl05tvPfokrgF8gOMM0pwkmQLrnS8vJdf12Dkk633uh89+Xx2aeyhCXFCRIr1DQefR+O1K0CrUmmmzH2oK83K9R3B2Qi5y6KR7tK368hk5wacDBi2/ION5Da6ypHRsYIjcbornjoWmTzWoToxz5yat/CrjHcRRB4GbJteC6Kar0+Tk4EZfcFqhE7qlj9JP36LAAh5w32eKDege9nLV9hfy+l4oF55UMF4IUUts0kLJyQc/81K2e5u7wwjepOtGLj2+zw0vM1VTUfINgL9uyH524+FLBxDG+k8Jb1oSl2NEUnjAWdDivGOR1bis4ul+0Z3JKGMCr67mGdjSAiMh/rj8zKnfWF9q2/Hd8zGy53q0YJZgddaSJMF/IWh1WZG1EieWeZt50+xyRLG7KMo1uMDBmr28QMHi7murDzTf9OPIueaPbLzytao3pMF6eVPruq7Hs2OxEVMcvj90UDbMBPCWyeLeQQVziZhXFSaFETSkLIWRkFBybpX8UnAr6mZI8lPqGQHhPvOXJKZqgA27Z2UunsIH8F/tdGjJLDXG89z047rIc08fakvi09hROwKz+soTUU0hQ6TH1UDWeBKRSVfFK3vFxFjN+RoxudKBJA+PAdyng2S8zbYf02D/kSX05yIQA5cNUTcnaEaFNVXA0JO4WXork7BvXN3Wnqu/ljmiCqGqWsW8sW sWJqILpw yr+qijAenjeCUwkion9x72IiXBhgJiihE9f+HjwlKRLdakCAA2ft1dnGot6M1Om80wygPZUwbNy21JtlW3qgzf7EY4l1/q4CfYAJpc6TtTeCkTaaVK6+wdT7ZTP++wnIJOu5VNkSG2twoNycNC+a0vfMOjRyIk0ykOdiKYHNRSlkw53NrNgsShIvxIiiqgis16zVFoX3CVK8HYdJfm64QfQCyq+Nor+qzlOZkixdpTrYinVNbR8xxecX824/E69vy2Mu0u+wQ28d3FaBQZoxjLAm3gJUjKEfAp2Vrcq6u3Q4uMKpcvRfL43XWGHzCT5ddz12Q/bom+lwHYxqSPw9O7NpngfQPFr2ciTvKAuzga5Ka+Mtiq8maLBmhlKa1Z08R6nT/tTubDfUZy76KMKL8WCFP2vlKYH+trCQB6zUUKZhOYtN9UN8D1ZuRE3ujku/DErBL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.25 15:11, Mathieu Desnoyers wrote: > On 2025-05-08 06:45, David Hildenbrand wrote: >> On 07.03.25 21:22, Mathieu Desnoyers wrote: >>> I'm currently perfecting my understanding of the mm code and reviewing >>> pieces of it as I go, and stumbled on this: >>> >>> commit 27cacaad16c5 ("mm,memory_hotplug: drop unneeded locking") >>> >>> This commit removes all users of zone_span_writelock(), thus making >>> the inline useless, but leaves the now useless >>> zone_span_seqbegin()/zone_span_seqretry() in place within >>> page_outside_zone_boundaries(). >>> >>> So I'm confused. What's going on ? >>> >>> And if this commit got things very wrong when removing the >>> seqlock, I wonder if there are cases where its partial >>> pgdat_resize_lock() removal can be an issue as well. >> >> I stumbled over that myself recently as well. I think I mentioned in the >> past that we should just store >> >> start_pfn + end_pfn >> >> instead of >> >> start_pfn + nr_pages >> >> >> Then, concurrent resizing could happen (and we could atomically read >> start_pfn / end_pfn). >> >> Right now, when adjusting start_pfn, we always also have to adjust >> nr_pages. A concurrent reader calculating end_pfn manually could see >> some crappy result. >> >> Having that said, I am not aware of issues in that area, but it all >> looks like only a partial cleanup to me. > > I wonder if all callers to zone_spans_pfn() prevent concurrent modification > of the zone start_pfn and nr_pages ? I think compaction does not protect against that (e.g., no mem_hotplug_begin()). My understanding was that compaction can mostly tolerate it (e.g., recheck pfn_to_online_page() + page_zone() check) > > For instance set_pfnblock_flags_mask() (called by set_pageblock_migratetype) > does: > > VM_BUG_ON_PAGE(!zone_spans_pfn(page_zone(page), pfn), page); > Yes, that might indeed trigger in some weird races. > If we look at zone_spans_pfn(): > > static inline unsigned long zone_end_pfn(const struct zone *zone) > { > return zone->zone_start_pfn + zone->spanned_pages; > } > > static inline bool zone_spans_pfn(const struct zone *zone, unsigned long pfn) > { > return zone->zone_start_pfn <= pfn && pfn < zone_end_pfn(zone); > } > > A concurrent updater which shrinks a zone by moving its start would have > to increment zone_start_pfn *and* decrement spanned_pages. If this happens > concurrently with the loads from zone_spans_pfn(), then it can observe > an intermediate state (only nr pages reduced or only zone start moved). > The first scenario at least can lead to false positive VM_BUG_ON(). Jup. > > Likewise if the updater expands the zone by moving its start left. If > the observer loads an updated start pfn without observing the nr pages > update, it can lead to false positive VM_BUG_ON(). > > I notice that zone_intersects() also uses zone_end_pfn(). It is used for > instance by default_kernel_zone_for_pfn() without locks. In this case, > reading both nr pages and start pfn concurrently with update could cause > a false-positive match, for instance if the start of the range is moved > but the nr pages prior value is loaded (concurrent shrink). This could > match a zone outside of the function parameter range. > > Another reader of those fields is update_pgdat_span(), which appears to > be called only from remove_pfn_range_from_zone with mem_hotplug_lock > held in write mode. So that one should be fine. > > AFAIU, updates to nr pages and zone start pfn are done by: > > - remove_pfn_range_from_zone (AFAIU always called with mem_hotplug_lock > in write mode), > - shrink_zone_span (called from remove_pfn_range_from_zone), > - resize_zone_range (__meminit function), called from move_pfn_range_to_zone() > also called with mem_hotplug_lock in write mode. Yes, I refactored that at some point. mem_hotplug_begin() could protect against it, but we really don't want to grab that all over the place. > > So I think your idea of keeping track of both zone_start_pfn and zone_end_pfn > would solve this specific issue, however we'd have to carefully consider what > happens to users of spanned_pages (e.g. zone_is_empty()) callers, because it > would then require to calculate the spanned_pages from end - start, which > then can have similar issues wrt atomicity against concurrent updates. We could easily just store both things (spanned pages + end_pfn), such that we can read both atomically. -- Cheers, David / dhildenb