From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 199E8C369D3 for ; Mon, 28 Apr 2025 07:18:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D98446B0005; Mon, 28 Apr 2025 03:18:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D22EB6B0006; Mon, 28 Apr 2025 03:18:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4B776B0007; Mon, 28 Apr 2025 03:18:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 91AAC6B0005 for ; Mon, 28 Apr 2025 03:18:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DACF8160AEC for ; Mon, 28 Apr 2025 07:18:26 +0000 (UTC) X-FDA: 83382599412.07.B909E2F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 7C2DC1C0009 for ; Mon, 28 Apr 2025 07:18:24 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P0IjFoEQ; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745824704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hl/eg/Xd5t08sY71UU5pvHE5cX2PnfJ+PDNMH8JdN/k=; b=2RfHxxgnJsl2g8pQW9x3oV/fk6g6OOzi7YM8XEgVeMjfZLSEuZMoS3oQvCI9H+K/mlZTSw N9s9mVIqtNDOmSNTkPt2WS091mC2xyTM8hGuuHwDVKBJppibsWu/0P+P6MHXskr9Xwdwjd qEZd6X69LjBT68lRtkN92N5yIMy6DVI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=P0IjFoEQ; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745824704; a=rsa-sha256; cv=none; b=Ws9QQZBtgQO4EeRe/xDHNKIaKOdXJciHJxDhdBE7wqslN831fEpXc+Z9TsshUVr+0yMvax MrUK2WzeRrIkL0xv6J88PLEVtM7hzsDINlJCz9Jli7hqcxwSLNi5TZFp6A25tl2OjBR3J1 hEy2PEp/a5jtO+2UizY1v4j6PxylGSM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745824703; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hl/eg/Xd5t08sY71UU5pvHE5cX2PnfJ+PDNMH8JdN/k=; b=P0IjFoEQjbIoiYzrJyk68YbUOT+/GXxhP7vbTCZUML8vNXdSXQ7GUEBRSeB+AN7w13Xxdn Gc6NqGhJLAQwB1kWXmeFQpww59puaCmKRWLzDpqRwy6LUBLkaCrIdbnSJA1RfDwOJGcTx+ yfNygMUO7DV+IqTeVCtmTZ1Eeg/Op2E= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-Te0jsG0UO4-ipEE24-gf3w-1; Mon, 28 Apr 2025 03:18:22 -0400 X-MC-Unique: Te0jsG0UO4-ipEE24-gf3w-1 X-Mimecast-MFC-AGG-ID: Te0jsG0UO4-ipEE24-gf3w_1745824701 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3912b54611dso2218109f8f.1 for ; Mon, 28 Apr 2025 00:18:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745824701; x=1746429501; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Hl/eg/Xd5t08sY71UU5pvHE5cX2PnfJ+PDNMH8JdN/k=; b=fJI0a2Yu5hsk3evnkFQIfGA7lLdld2MYROQFVtf9LjKOfvy+pXgTuj3sIuA6GsOmyU YfMze1PpxshD6amTJozHD/OxDw/LwNhOm+QjQxfBtmmEfIl/K0bvOIVbcSGWbv0qrfl0 zfscZA7vO+saFbXoUVypAdtvOJXjEDXVelu5B2VCkhFvWoNnXe96YUNGLKslWh78APvR zbza1hsX3rmRAlWqvWC7/LXRQKiCc7u5jrSQnpYMgpvtEUO9LLhdTN80MPDjaJGBnJP0 S+mhT4ByljJzN5MzEpCUFX90XdSROukQw9PgExz91EAV6tJK++MtL5T2T+TqXyBFV1a7 WufA== X-Forwarded-Encrypted: i=1; AJvYcCWozfoRIU+fuwq/4/k1vPG45g6ZSlSsaOw5baf+RQjV79Dkf/9V2+rbT5ofr6o8gnqZ2tX3TKCBpQ==@kvack.org X-Gm-Message-State: AOJu0YzXFo2vARaJGx0uXgC+iL2vilw0uWhTwx3mAsLILSsdh4yELIRJ g8cnSNWzFQ/jbnUj2gjS0rpfkP2mIDZXQV5bHSCLBtd9QwGn6avt9PLqhqBlHf/PjwBV4Ek4FRB SK5ENwCKVT1/2s3n2rTKcgbgS4dcre+73UMvMKIE7zrOfAuIE X-Gm-Gg: ASbGncu/idhhoW0cFL0SJ8yEkBO1NNsyaPxXg0/W4+JuCo/jVr3ESTTI1FUhOjEkUWU pEU3rha6dwvocmoGLfuJtHr3zMygT6YYOuFB0mTAPG9mQSN1rxpokC+UvZAU+Rvls12jPo1FBdX XrLJHHn/LMnn6tl/Q9KLP8H5aTrIIgp7gb4EVYqb1i/eHkf7zhv5G92IOOb/dTmqCaRkWmnVZiV MPW5mT8+GeFj5Cmcncktw1SaGny0EkR7Jpd9VcZpu5xvojwmpIJtk2SoVAv+QCwS777SkRts0JB eyk3TN2UIyhP4DF42IlQNSAthiYVSLLEHl3Spec8joN7KTtWoJwqJGs0FW/xGjv7Aw1hUYLam7P SHqFsW9QYthJ0nEuc/Rfj3wZfbfDFXSnK+oRSttY= X-Received: by 2002:a5d:5f82:0:b0:39c:30d9:3b5c with SMTP id ffacd0b85a97d-3a074f39730mr8804940f8f.39.1745824701054; Mon, 28 Apr 2025 00:18:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8Z9SYwV7X/D46qnbh7MvRm+KRJA6BuSKYTHlRlSf9NZYpN57m1RNCkvqmYsbjHqGLwnfpgA== X-Received: by 2002:a5d:5f82:0:b0:39c:30d9:3b5c with SMTP id ffacd0b85a97d-3a074f39730mr8804905f8f.39.1745824700642; Mon, 28 Apr 2025 00:18:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea? (p200300cbc72fea002f00e7e58875a0ea.dip0.t-ipconnect.de. [2003:cb:c72f:ea00:2f00:e7e5:8875:a0ea]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073e5e198sm10475664f8f.97.2025.04.28.00.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Apr 2025 00:18:20 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2025 09:18:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm/io-mapping: precompute remap protection flags for clarity To: Ye Liu , akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250427100442.958352-1-ye.liu@linux.dev> <20250427100442.958352-2-ye.liu@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250427100442.958352-2-ye.liu@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TiZIDYHiw66KUXueS_9VwV_-zEsCKUNCwrTFb0Vd-fk_1745824701 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7C2DC1C0009 X-Stat-Signature: rrm8wk6kbdd6o5nwcjxodbrtaz1nno5s X-HE-Tag: 1745824704-616607 X-HE-Meta: U2FsdGVkX18cCtc/tXInolAkIHW2LDqO60665KJwmlKpVYRmuNSvfflpT5+ugOmv1bBd4E9I6BkLOCrK94kcCE9ysVOvd/7pL2b6Cw5RwnjD+6DJmp5flL62i1lHpDj8atKymAamL9nuB6ahoHr2tZq7AURo0NGFuUFDOsehpniSM1XuTz6HCTxwJ0950IOplnMFH+ly13PLznudUcdxtdDnDER/WTRMbaDIlwR5uTi3UvcrdW4+7rc5JVwzuAOghWtE2v7K3ui40CqDq6kElgy30ByDO33jjLH/8I4z3F8Jtp9W83S/60Fz/i/SkmexJktcY0UNo6t+FL5xwM1Fof7jjjlPg0MDeDoGyZM8J7pZ3Jc8d9npnCPXDSv53+VjzaQnflwNMJU7/GGbUEyyVl53jDsp7vVHKAFbZoxT0VbxQw3/kbLDvbqJQi40g5XMgwho+lM+9fH3R4Q6D8NG/EMMX8OhOYqLSxSxJCRvsBgZ925uRZn8cKf/I7D1cpmFRV8ltF382iSMbMKPJWMqwESkM+n6ty5ORWN887iqHjpCp/XRe6qQLEqdH6HLfoCALlnNZohZH/kUbm5sF5tOIGAIHi2qaWKGd8l6Z2oodpV6ocHtA0ZJrM1MKLvptcwLUGdKiCJejg9wY8ksL9P9WW2lRPe4l4/SnIW36yKIDxtERZezwo6GI0Yn5iE3WiL1U1RQaxH1TR9vecDFa8OYGR61zmh0bwb5JuoZRhjuTZJ8XpKA4ZLbxezrArsckYbnI2g6id7RmkttclHfmW9D3s135KmM6fN1bU+vhXlQayqX/yJ1uKG99jTlGVBgz360Sj5eV/EOrsEZTrN468fZM+nV+1oeEUxGccHaXpxWb4WIJhnaZP+LODo8HW8EV0YOp2oUevWB5GXBmDZ8dFcHKEsxnP9pBGSi/kmRZksgFBjCM78yVnVC68T+kQUY27aJhsNnEBR3T294tU2P9bW 1EtQq30M 7JQ4rhKYt4ysnaDp6jzPu6hjnoR0+PbJ4pbXCjPK7nhdWK0Ln3/mFKzjFhYBpj0nIg32wlh9gtUY7S71cbzOd8fQVFcaO9mgoHr67yW9PAOOfc36fx8lJkmHJqJZY+h5ZiAOJTlJHIdtHC7pQp92xRxn36K+1dlzkrfMAnpemyU0UtFf2UHVGr96U96Oyqou7GDXCxnR1zs0CwK89n360FukJFxQREYfefCbfDW8ZUG0lIIJDvc5DT0/ExaHyZY5jgKwivBTB36q+Ut9Nea/nv1WezMt3xAAYnHEAPglGI4PZbH2pTFKkvAC5LMWQ0tkyXvTYOB4XdpH1fn86Tu000RNXdZslrmnaIZKUO5fKyMJ2Jgou8hXVCDp92wjkih8MzCDbWq9W7nwafHUNzTV5Di2Fe8A16MkDSzX7KLE8TDlSBvg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.04.25 12:04, Ye Liu wrote: > From: Ye Liu > > In io_mapping_map_user(), precompute the page protection flags in a local > variable before calling remap_pfn_range_notrack(). > > No functional change. > > Signed-off-by: Ye Liu > --- > mm/io-mapping.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/io-mapping.c b/mm/io-mapping.c > index 01b362799930..f44a6a134712 100644 > --- a/mm/io-mapping.c > +++ b/mm/io-mapping.c > @@ -21,9 +21,10 @@ int io_mapping_map_user(struct io_mapping *iomap, struct vm_area_struct *vma, > if (WARN_ON_ONCE((vma->vm_flags & expected_flags) != expected_flags)) > return -EINVAL; > > + pgprot_t remap_prot = __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) | > + (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK)); > + > /* We rely on prevalidation of the io-mapping to skip track_pfn(). */ > - return remap_pfn_range_notrack(vma, addr, pfn, size, > - __pgprot((pgprot_val(iomap->prot) & _PAGE_CACHE_MASK) | > - (pgprot_val(vma->vm_page_prot) & ~_PAGE_CACHE_MASK))); > + return remap_pfn_range_notrack(vma, addr, pfn, size, remap_prot); > } > EXPORT_SYMBOL_GPL(io_mapping_map_user); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb