From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD37BC25B75 for ; Thu, 6 Jun 2024 05:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E9496B009D; Thu, 6 Jun 2024 01:56:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49A166B009E; Thu, 6 Jun 2024 01:56:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339E26B009F; Thu, 6 Jun 2024 01:56:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 15B636B009D for ; Thu, 6 Jun 2024 01:56:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 82EB1160E2B for ; Thu, 6 Jun 2024 05:56:23 +0000 (UTC) X-FDA: 82199403846.22.28C9C09 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf10.hostedemail.com (Postfix) with ESMTP id 077EFC000D for ; Thu, 6 Jun 2024 05:56:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iwKwqsfj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717653381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+8Z5XmpUE3zx1Y8cy7cbU/CoYCfPRTM2B2i5o3MFz18=; b=baY2VscejWCahmvMqCuZwk7F8uLeIqgSAHKD56FqQnYSfp+fmSfMo9A5E5k5iO8iYdvj99 jNIsx+jdn192PwzuGvgH4KcW37ugxKIGDHp+CZSU9zlnrgHOvV2XfSLUvhFv55CY3q3HWT Idn/w/8VWEhw5GZ1/tNYo4jRDCb6oNs= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iwKwqsfj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf10.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717653381; a=rsa-sha256; cv=none; b=WlzRGjZpZaKkL65AMu0DFPZRHXAoiYc3JemdNeDr5Dudp3mloAe4oE0iRRyz2UGOcVV59+ W7HHB2+ZYqt3UJztXoSah3s8ePUQjxHUQIk7zcY4DrB6PGqfJ2Q8thZkRmJbGC8cuEDSWg C4GqehkxX+SUlgPMwBs5/WoEN1khwsk= X-Envelope-To: senozhatsky@chromium.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717653378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+8Z5XmpUE3zx1Y8cy7cbU/CoYCfPRTM2B2i5o3MFz18=; b=iwKwqsfjoGXVgQe/po1O8i4bOhN+NhoK5vwBxCPBRqhvuJO6LC62WtY9E5l6kKozckGXAN ENQD0kw1r5cy9frpP4esDYHVVJkYEgPMeRbsQqoP8S+NpNI4S+mRQgCBad5qPF4uRF7Akg A+vmKupx/CjWu2gH98ucZkabpnMTcQs= X-Envelope-To: yosryahmed@google.com X-Envelope-To: erhard_f@mailbox.org X-Envelope-To: yuzhao@google.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: linuxppc-dev@lists.ozlabs.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: minchan@kernel.org X-Envelope-To: vbabka@kernel.org Message-ID: Date: Thu, 6 Jun 2024 13:55:50 +0800 MIME-Version: 1.0 Subject: Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc) Content-Language: en-US To: Sergey Senozhatsky Cc: Yosry Ahmed , Erhard Furtner , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Johannes Weiner , Nhat Pham , Minchan Kim , "Vlastimil Babka (SUSE)" References: <20240604231019.18e2f373@yea> <20240606010431.2b33318c@yea> <20240606043156.GC11718@google.com> <6335c05d-9493-4b03-85a7-f2dd91db9451@linux.dev> <20240606054334.GD11718@google.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240606054334.GD11718@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 077EFC000D X-Stat-Signature: kjo5txfdm11spb3zf57fgr3igdz8d3ix X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717653380-655816 X-HE-Meta: U2FsdGVkX19PuDC4pZW5nzv6kE7ORbnWr3YrYGJhTVBWFnFV+bJ3VjFb5QauFR5ZgLuH5zvRD45J3G4fEf9hV8gp4V/Ui/oL5bmmYWVCtsl57jfSijbxkCOvRbSVrTdGiaac52lQD7dpuWhPNkLsggv/lB8VTEE/QDo/WyU6VU8/7eTWE+DDLbBYHXLKJuiekDn5P6CR1TGHgdXoAGzSWzMGLXUJF6svU4W0Yj2e+3x2q8N8ABQYEag1ffp3c1fIxtqK9g/exLJ1uYzpcEIS9yuPXW5II7eZFfp9/5KlRyKZsPRU9zPgl0SdyACOBK1eldRiGITQvCWNwG2rOBAvvnIl3jPBNA6i4OIx4Oj0p3BDlTpVXvi9FLGbtmMYK+JSoksCbJzuC2ltnzp5bcV3Kse1QOt3tTP7YAsmE2MfIEooLcL4CeOwLELgE72sL33xaGutalvmu1ApwX6vcH+6GKzNHwtaNDF3FJC58l4EEWObEJnVxVwCX7BmMIASP77MtAiuYDbqaqmFaUe5QKax3Gysow/gEgFCGt5vw9m9r2+kALgngQNdyMhrtWGUWL6M1lchxQuCxxtsxf5xRj60RbU9KXwvLV074BdemlT+p94KqGUmL+XIWtUxlZ3gXGisHcQggp2JRbQlPBeXlR65ddc+0oMUn6z2yE1J8XIDy83gwVFoyYI6cmNaqjKldjFzo3n9SJLD+rcL9J75Q09oOZoydekqXIZtZDg62TeEnmyn4Ad8FierE7mte/sh6EueoExpRpjsXZ6oeqaA+N4uwqK3qyuAXJ6LXZ2gRtftUjGUcyBXHOgNyjMpRdOWSCqVkwfUYqGhGNrbf1y2Rqa5q4ysiMXiAALLys1TJBPOsN/70Gf/fnNNE+RYG28bG7CIkW26sautPuSY5rmc9qmtoOxmp6Skdm/90SG0PN5HKfHhR0BuwjSgJCv32AB29wvpBNWRNk/Hm6UYiMDLRPl XR5DeWLX aPVoSkS033XpY6K7TvZheLNJQGnyPF+n5fX6JX4labayq0J3Tl5+fiL9YHgOOkPE0ZfDSC6B+YZTNwss7IevWID2scpMAk9g0cXdRqzvyHUS1T2Jvx16kNj09kX5Bv8swIS73 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/6 13:43, Sergey Senozhatsky wrote: > On (24/06/06 12:46), Chengming Zhou wrote: >>>> Agree, I think we should try to improve locking scalability of zsmalloc. >>>> I have some thoughts to share, no code or test data yet: >>>> >>>> 1. First, we can change the pool global lock to per-class lock, which >>>> is more fine-grained. >>> >>> Commit c0547d0b6a4b6 "zsmalloc: consolidate zs_pool's migrate_lock >>> and size_class's locks" [1] claimed no significant difference >>> between class->lock and pool->lock. >> >> Ok, I haven't looked into the history much, that seems preparation of trying >> to introduce reclaim in the zsmalloc? Not sure. But now with the reclaim code >> in zsmalloc has gone, should we change back to the per-class lock? Which is > > Well, the point that commit made was that Nhat (and Johannes?) were > unable to detect any impact of pool->lock on a variety of cases. So > we went on with code simplification. Right, the code is simpler. > >> obviously more fine-grained than the pool lock. Actually, I have just done it, >> will test to get some data later. > > Thanks, we'll need data on this. I'm happy to take the patch, but > jumping back and forth between class->lock and pool->lock merely > "for obvious reasons" is not what I'm extremely excited about. Yeah, agree, we need test data.