From: David Hildenbrand <david@redhat.com>
To: Mark Brown <broonie@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: Fix test result reporting in gup_longterm
Date: Fri, 16 May 2025 10:02:16 +0200 [thread overview]
Message-ID: <f924f789-5269-4046-99a4-2991f9a3ab3c@redhat.com> (raw)
In-Reply-To: <20250515-selftests-mm-gup-longterm-dups-v1-1-05f8f731cf63@kernel.org>
On 15.05.25 10:57, Mark Brown wrote:
> The kselftest framework uses the string logged when a test result is
> reported as the unique identifier for a test, using it to track test
> results between runs. The gup_longterm test completely fails to follow
> this pattern, it runs a single test function repeatedly with various
> parameters but each result report is a string logging an error message
> which is fixed between runs.
As the person who wrote that test (that you apparently didn't CC for
some reason), what exactly is the problem with that?
We run tests. If all pass, we're happy, if one fails, we investigate.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-05-16 8:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 8:57 Mark Brown
2025-05-15 9:35 ` Dev Jain
2025-05-15 9:41 ` Mark Brown
2025-05-15 9:43 ` Dev Jain
2025-05-16 8:02 ` David Hildenbrand [this message]
2025-05-16 12:29 ` Mark Brown
2025-05-16 12:55 ` David Hildenbrand
2025-05-16 13:09 ` Mark Brown
2025-05-16 14:12 ` David Hildenbrand
2025-05-16 18:07 ` Mark Brown
2025-05-19 13:28 ` David Hildenbrand
2025-05-19 14:55 ` Mark Brown
2025-05-21 18:48 ` Mark Brown
2025-05-22 8:42 ` David Hildenbrand
2025-05-22 9:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f924f789-5269-4046-99a4-2991f9a3ab3c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox