From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F47EC5B552 for ; Tue, 10 Jun 2025 10:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF5EB6B007B; Tue, 10 Jun 2025 06:31:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA7256B0089; Tue, 10 Jun 2025 06:31:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C95F36B008A; Tue, 10 Jun 2025 06:31:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ABBC36B007B for ; Tue, 10 Jun 2025 06:31:41 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2DDDB8184B for ; Tue, 10 Jun 2025 10:31:41 +0000 (UTC) X-FDA: 83539124802.05.D1FE524 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id A388E180007 for ; Tue, 10 Jun 2025 10:31:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="hDYw/6L0"; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749551498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N1iMTIMQ7+7DUjp8KDqPoWh+KLZ78KCNqt1HLSEYoGw=; b=qfsWwn2fHaFze5jnI+cQ6Wnh5Qp/W2Y9mp566xEPktL3fXpQOv1iKFNzGlLt6mQYsilIMj 94pJl4/a5LT0ObhL4PMoQPm3pvY31k5Eafz+7iK97bhRCYZCwRThHCVQDGI9z3obV1fHiP AtRmycr9Bg9tefEeKJbat+q4liHHDvM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="hDYw/6L0"; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749551498; a=rsa-sha256; cv=none; b=ISKP4Z1cNDqX3L1gIYLM3D93/BrCDgn/huLevsjRyORkzyAKAB2HHgGRVyfmyCVxamD97b 3Jbh3lqXJ7zf2a2vdtwBMBzfs3IM90mCByhDhtw7p6ePH+DJATO63HpEMqTyiyNnca6JAV cjk+jAAqvaiK5hvy534r7SGdyG18uLw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749551498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=N1iMTIMQ7+7DUjp8KDqPoWh+KLZ78KCNqt1HLSEYoGw=; b=hDYw/6L0GhHCLhPXqxYBJIxhjk4ZYeQjZJ9NL6bpcHe6G7dQx8EVBghEALKiRJ/M32bpan 5gMG/zVS70gtxNkUGOrOXHip/Qd9Rv4PadFGQ1IY+TJ5XxqQwi0X0egvY69Cpl+tRpLEej 7XRV0B+hEF+3IRu+xNLEadYdAysTZs8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-muRdPnYFMYK-po1qB9OvZA-1; Tue, 10 Jun 2025 06:31:35 -0400 X-MC-Unique: muRdPnYFMYK-po1qB9OvZA-1 X-Mimecast-MFC-AGG-ID: muRdPnYFMYK-po1qB9OvZA_1749551494 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4e6d426b1so3142204f8f.1 for ; Tue, 10 Jun 2025 03:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749551494; x=1750156294; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=N1iMTIMQ7+7DUjp8KDqPoWh+KLZ78KCNqt1HLSEYoGw=; b=kRxrArVBthU3cqp3ud+2Fbtyy3nmzttORxjbohxqqYC70FwBzEXC3255E913LS0SiX h02ZXQhWhMRMMrd8FhC6XWjvISEpWyA8aysFEv4JsxGojJsWPqnQM6p/UeWZ38gtm+SY g9ocMrxacJ0ymKd25sZ90uJToYdwA/ujtp3sf6YuenOKnepbk6ImlbsQig5LZjNbqsLF ZyN9T/LduGxOkGBBKBGwhmJDtM+BxKxrMYNrfaNRxIds1fuatpG0z/3nrW3KO+WVWNVa p5MIXRhiiPHLm1O6RK15OSrTOQDr+HI+VMaviJXaQmAkpvEc+/rUy90VU0a8cZGQ537Q Ij0w== X-Forwarded-Encrypted: i=1; AJvYcCUsCIDQRqX3QInkXvUAG1QvjhjpUFaVvpvbSv8aZISYRm9X9ODG1Mz5TmQmAtG8JCAABNS8AgMj0w==@kvack.org X-Gm-Message-State: AOJu0YyMQp00Bqolc1qzhpXQ1aOHfP+4HE4pCYP/xc1TkdF2L4q5idX5 ooGgNdUxkMMO+SJqrzdOKacS3NY88UFKpCWW8IcCjCcC7AjZ3Fu00jMztrkcTc406UFEP+DMtS6 e6rmCVpZzVu87ZcSofV8k/J/2coJez2zIFNePji2emvt30CTFsAd8 X-Gm-Gg: ASbGnct7SqgF2eCuyYCBRt7wdiDuGQ7Oyd4CbAydcrSRmp5s46feBEKCHTZ+KAtsT3X opQZOLjYezoSyr3cNs6DF4wksmdP4v1HTrkro1Ogw7Kv5LL1xO4nVSVLHjciPCGWF3mVjk6jM9f nxRkbh/pMyr2zJcSIGQ1uQk/jeDHEj0Il+maG7TAsFJj42LCkQ9S/l1rMLpDweHBsHHrN3/j0vs nDyun6rWEm+XD6yVrtBIgbjWpZ/5u/tUWpfbIMmvGRg15g+sYsfyN/p46/yM+6RZYnkeSK/o1dE 7KwtD91fuur8hmvxC9iEfQMK59OQyTST7Z+OgekkmlBDLlcDkM5wbB4= X-Received: by 2002:a05:6000:2582:b0:3a4:eee4:cdec with SMTP id ffacd0b85a97d-3a5513de345mr2353233f8f.6.1749551493748; Tue, 10 Jun 2025 03:31:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELymAnGPTU47bn5imUR1l2ClSyV29BnZs5PUjEk1sVG38IO8kWXeey+NsP5zTE8kHRmyj6VQ== X-Received: by 2002:a05:6000:2582:b0:3a4:eee4:cdec with SMTP id ffacd0b85a97d-3a5513de345mr2353208f8f.6.1749551493381; Tue, 10 Jun 2025 03:31:33 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4526e155ce7sm135671755e9.10.2025.06.10.03.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 03:31:32 -0700 (PDT) Message-ID: Date: Tue, 10 Jun 2025 12:31:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib/test_hmm: reduce stack usage To: Arnd Bergmann , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= Cc: Arnd Bergmann , Alistair Popple , Jason Gunthorpe , Thorsten Blum , Jeff Johnson , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250610092159.2639515-1-arnd@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250610092159.2639515-1-arnd@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KRtRG2EsV3AuUYb5Ly1HD8c-pJtkDhlPEQlYWny16mE_1749551494 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A388E180007 X-Stat-Signature: gjw9mf31f476oh6ret7aq14dffteffw4 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749551498-355085 X-HE-Meta: U2FsdGVkX19Vel3weW97npMvfRtkppqZuSAikYL8NDfk6bPJRBIBwzh2nXXLxcfLbIhjOzsefSCox7J96ba/fnYrRNCs870i9rDVnyjDsHjZWogDy27aZkAAMWnl+Mzx6XJnGhDrZo7WLZAuPTF0/CmjguUnwLhXXzioqeRoXQSewcy2IAGX6VjadpiVSIpTzxSN1SgZ2l4VRpJdT8E+H6Le5rD9h6A+YE5lCx+IlCmaoHkzv969SBkO5N1tZ1tkaFKICqSPQxTkusHMfaj4b9CwAxbyurm8t0h1G7L22WdEo4Ujmn0PcZMNEI8pdFv58YrKjNEfiNZdkvSMgc1bQQBA063LoAKoHWED1STuRL7b6u1ifmlBvNFMkRzA/pJ5zUIwxwQjviw8PD3bRLfsjCY1F3PuBToEyj4IUmUAnv+bFcFuk4Ptj/w7O3qcHTBLSSvKaGa2WcF+8INyh+DKfHYKGscfz4BUwupy3Kh/Zxt5AaDqVGegRjdE0W4WmsjX3wVD6ywxtjuxxhz0JrlYue//EvueOcrilLECMKqYKfphvQg0DZhpMYmor7s52KXHvxe3egDTVbHD4BO0ynZNkef851ErDgDQ8xLqhI6ndtbY0oHUQui5UCjAgVzJKjg8rtclXDe23h6Ox9JsyZ8+p7XiXVX1XEI0byafeRfS8Jp3B3mOSFuJMOowbg9w8ejf+P4RnCt+WIR+Dzr0WVsUVvAPPaSxsen2EtsqAim795DjQLfGjegCHAMqqZ6UFPx0RMVpRyfbGNyt17Y9B626zf/WRIeeb4zzWPS8EbrUfOgyX2ZVXecD9dHSW6FtVsrx2QXZxL/APMZhD26HxJtWc3zJbuwK+9KLPBkWXmYabuvMbxsJmw5Uao1Qgma/6HCdUvjX/gnVmus2qWr2qAEH3I6VJnj3aAXoHhsIuqSia8T63IMCtz9RMyhZtCvuVzIhGRDI6ok72SvUYO1wqzz fBfLYzyu iGwUJ+bI7t5cuF6LoTU+S09uBR9U7UFvqx4DbDbl6ghRGm7zq9dz4ozOG2J5FI2ABFToAEbtRaX/KRc9BxnBB/HZmwyrLvlUIbwtbBq7rvaXt4d+cub/zYRbDMp3MrlcHMwblz9SZ3oX+C1Di7YASUrnKHbsIv9nX0XVaqEZLce8ssbCQ/fJuc13uEK/wq/K+oO3JYnamEdvnPp7xASqR++Rrr8tcUzq4kzi1Ot+H7f7WRCEVmlExOYhzVK9OeZR31flVpFuoPAwhC1wpOgSMKvfQVnuZP3LH2UOUq1bsgugwJrFFGD6qjLwXmFJSJmA0xZme+RrxnSlgcEpWoG76HBMe+YEC94lc256njYMbqrmvHp+upOlGfA5fNPID0H/P20GMJ8qCVXNnrfGyTMvor+2ulo5RUj/GxE1Oj03WtkNFXzEXZ98nuQ1aHBRqtGhGLQk71eqy4E9yoCzZwe8fclKIzL0TvhQUUIRq2Z8bvuGh9JYyqfQCqVqGQayhaQ6+VEwC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.06.25 11:21, Arnd Bergmann wrote: > From: Arnd Bergmann > > The various test ioctl handlers use arrays of 64 integers that add up to 1KiB > of stack data, which in turn leads to exceeding the warning limit in some > configurations: > > lib/test_hmm.c:935:12: error: stack frame size (1408) exceeds limit (1280) in 'dmirror_migrate_to_device' [-Werror,-Wframe-larger-than] > > Use half the size for these arrays, in order to stay under the warning limits. > The code can already deal with arbitrary lengths, but this may be a little less > efficient. > > Signed-off-by: Arnd Bergmann > --- > lib/test_hmm.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/lib/test_hmm.c b/lib/test_hmm.c > index 5b144bc5c4ec..761725bc713c 100644 > --- a/lib/test_hmm.c > +++ b/lib/test_hmm.c > @@ -330,7 +330,7 @@ static int dmirror_fault(struct dmirror *dmirror, unsigned long start, > { > struct mm_struct *mm = dmirror->notifier.mm; > unsigned long addr; > - unsigned long pfns[64]; > + unsigned long pfns[32]; > struct hmm_range range = { > .notifier = &dmirror->notifier, > .hmm_pfns = pfns, > @@ -879,8 +879,8 @@ static int dmirror_migrate_to_system(struct dmirror *dmirror, > unsigned long size = cmd->npages << PAGE_SHIFT; > struct mm_struct *mm = dmirror->notifier.mm; > struct vm_area_struct *vma; > - unsigned long src_pfns[64] = { 0 }; > - unsigned long dst_pfns[64] = { 0 }; > + unsigned long src_pfns[32] = { 0 }; > + unsigned long dst_pfns[32] = { 0 }; > struct migrate_vma args = { 0 }; > unsigned long next; > int ret; > @@ -939,8 +939,8 @@ static int dmirror_migrate_to_device(struct dmirror *dmirror, > unsigned long size = cmd->npages << PAGE_SHIFT; > struct mm_struct *mm = dmirror->notifier.mm; > struct vm_area_struct *vma; > - unsigned long src_pfns[64] = { 0 }; > - unsigned long dst_pfns[64] = { 0 }; > + unsigned long src_pfns[32] = { 0 }; > + unsigned long dst_pfns[32] = { 0 }; > struct dmirror_bounce bounce; > struct migrate_vma args = { 0 }; > unsigned long next; > @@ -1144,8 +1144,8 @@ static int dmirror_snapshot(struct dmirror *dmirror, > unsigned long size = cmd->npages << PAGE_SHIFT; > unsigned long addr; > unsigned long next; > - unsigned long pfns[64]; > - unsigned char perm[64]; > + unsigned long pfns[32]; > + unsigned char perm[32]; > char __user *uptr; > struct hmm_range range = { > .hmm_pfns = pfns, Should we just add a define for the common value (now 32)? TEST_HMM_NR_PFN or sth like that. -- Cheers, David / dhildenb