From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4A7C83F01 for ; Wed, 30 Aug 2023 07:07:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E7E88E0045; Wed, 30 Aug 2023 03:07:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 397BA8E0009; Wed, 30 Aug 2023 03:07:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25F5E8E0045; Wed, 30 Aug 2023 03:07:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 157868E0009 for ; Wed, 30 Aug 2023 03:07:56 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CA8748028B for ; Wed, 30 Aug 2023 07:07:55 +0000 (UTC) X-FDA: 81179891310.15.658F3A4 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf20.hostedemail.com (Postfix) with ESMTP id 58E2C1C001B for ; Wed, 30 Aug 2023 07:07:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693379274; a=rsa-sha256; cv=none; b=jPD6BPn7JdLphLrf+S/kddwcLME/iUiudRdK4hDEQNfS3iTAeqtMRPmJf0GCSbLF+msldZ 3wyKx0YA1pY4XwxQutu0/j1yAe2+8SpbBMwVqoRY3wnOWGoihXtqsFEGGSLrVZBzxXnKg/ iogtqjM+c5LPFp2y80Ni6ErkpX5dGsU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693379274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s8QMT8sCI/CBZ836/aLC9oaU/WvH9iB0YDLbqi+cm2U=; b=l+issRbIlxfLbtS/MIyUWIEabcXQX5Y4ekd4FfYQprAR/4w7AIpT1tBNLu2QOTGzv0jQOg Cr9OJ9xJ6N1HwwoFwLzB2MNKGGN1os8Sc2dlb3dbydnNEu9uX4Jf3thcIptMArT0nB2g86 1iM7fMANM5avBW/eJWbwCEnbUvkMv9Y= Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RbFjh5wGXz4f3nwR for ; Wed, 30 Aug 2023 15:07:36 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP3 (Coremail) with SMTP id _Ch0CgD3Eru76u5kEDVABw--.65276S2; Wed, 30 Aug 2023 15:07:40 +0800 (CST) Subject: Re: [PATCH v2 5/7] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable To: Mel Gorman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-6-shikemeng@huaweicloud.com> <20230829150523.ktn6ktdtl7n22akp@techsingularity.net> From: Kemeng Shi Message-ID: Date: Wed, 30 Aug 2023 15:07:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20230829150523.ktn6ktdtl7n22akp@techsingularity.net> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-CM-TRANSID:_Ch0CgD3Eru76u5kEDVABw--.65276S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtrW5tr1kJry7tF43trW5Jrb_yoW3Crc_Gr 1F9rs7CrWUAw1kJFyayrnxursYgayUAF1UuryrKayYga45WrZ5Jws7J3W7ZF48JrWUuFy0 93Wfur45CFWjqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb78YFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2 j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7x kEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487MxAIw28IcxkI7VAK I48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7 xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xII jxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw2 0EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY 1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IUbPEf5UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 58E2C1C001B X-Stat-Signature: idfn13n6bseq3q66rher9wa3epabymgn X-HE-Tag: 1693379271-135394 X-HE-Meta: U2FsdGVkX1/Xq244PBa1S2UzSood44gZ9vz/w3bfrX4BcZR+bH/vh8kH5jk4emmZ7b+2iI48Gqwn22CWxXmWrWSTfYG1yd68POzpyFAG7BmmwNYlPzXHUPcft63tFtOQqXWlbH/h0DwywMSQ5qdGKFb8xHYMK/SKh66PrwJSWvjw66ct6ZXln6JEQ+40Xl93v0zv8bNEikriBLpmuLfVocNtKOHCzYycBrnArirwoope0ByYYSNbF1r15BPQe9zDPYn1ywM0t8hTyTwhoyOxswLykorq9nkxtmPDQcxWQjx97iWEk6P+0eYmq0A5wIAcD604UYwXA7jJMV63Ns+aowwW+mB/rTAgBgR2d079VXqZoXc8kDc8p1mMRy8okd/5Jcf8vY1JX528bAXiFTfstAgy0lzmqsRGJfs4FeYK5m1dOfXx8H8ABdUD4jg4PBqJ9xDpi8Dfhqaw0zfnKYK9YHJ3URsTyJvLNeeD4z+aE4cijeWu19Iy3+GmfAIE/RBsI59QrJbtDfL5lroFTCnuvWYdHpbcFXw2SkyUNsEymkmwFgaaIXQDEiLWHmhrExvvV1+oVAI9bzPxj2Tq1HXiLpyxJkjVjytkQKx01r1xBgYvl8cpY88TR+YsAI9q+euuwqho+IIHjpzteNhptQvgzAxDQUpMjn3HaM5YgMNb0OHwKvfajQ0xiawD6UN9Iqn8RvoALYx2oj1RQPRNkN+6tOxeu+qcjV06jrR78k6KCUOjj3ZYmKJZ7RmTGo0HTTjoUZ8llcxehu0JSPgjjq/vDikdQjY/JJ43EKUv3HL7scLOvoHwQ37lSYGJKPUJqbYqYjw33bcdkBbQ170xKpxAswCCyi4tqsK6dSaD4sThWxc0SwZGAV5DffUd5+EmEV2Zp8NOnA8MqbZ347M6r9HLmplt7LDwEDhAb1Sa6vRqK75NYo3717mn3q3lh/VMUYwcf8Kdt1NZklnMYlw+9/3 QMdaHteJ uAJItr9fXZL5O4wiJwAo+ieN9guaLVPOKAK44Zb1pK+c0VZURwqjB1RI+rsRj1q9x566iq8skFA6KXFtuLFGFaagnVN84A4wA0Xfq0kXZitTV9PGaTmVNUtktsiNvTk82VFP5Am3Ib9zJa9mUaLRXUPMYfzVUHLNLMX4m4k7eK7UFgD3A9/NVqVjVxZggWEsJ7sgITCqhD4Oyb9mmi3az9OmlThie7zMfx5hQGT4acbVBbGKP61uEiVj1Tq+7ejCPj+jNA6xWfwbLQYfl0MiCA/qRvFksbQN+GNEjyT2tz3mvAjGnl0Evxltl60fQ0vctMDtHXTbQK3NnxlpWFkLiPy6o5jY9sOX3PubN3E8Il3F4htNyesSwNBCZ7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: on 8/29/2023 11:05 PM, Mel Gorman wrote: > On Sat, Aug 26, 2023 at 11:36:15PM +0800, Kemeng Shi wrote: >> We have compact_blockskip_flush check in __reset_isolation_suitable, just >> remove repeat check before __reset_isolation_suitable in >> compact_blockskip_flush. >> >> Signed-off-by: Kemeng Shi >> Reviewed-by: Baolin Wang > > The comment should move to __reset_isolation_suitable but otherwise > Thanks for the review, I will move comment in next version. > Acked-by: Mel Gorman > > As a complete aside, the reset_isolation_suitable and > __reset_isolation_suitable were badly named because locking is not > involved but it's meaningless churn to fix it. >